Skip to content

Commit 79fad8f

Browse files
committed
WIP - this is drastic, but does it fix it?
1 parent 9c20aff commit 79fad8f

File tree

4 files changed

+14
-12
lines changed

4 files changed

+14
-12
lines changed

rb/spec/integration/selenium/webdriver/action_builder_spec.rb

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,14 @@
2121

2222
module Selenium
2323
module WebDriver
24-
describe ActionBuilder, exclusive: {bidi: false, reason: 'Not yet implemented with BiDi'} do
25-
after { driver.action.clear_all_actions }
24+
describe ActionBuilder, exclusive: { bidi: false, reason: 'Not yet implemented with BiDi' } do
25+
after do
26+
if GlobalTestEnv.rbe? && GlobalTestEnv.browser == :chrome
27+
reset_driver!
28+
else
29+
driver.action.clear_all_actions
30+
end
31+
end
2632

2733
describe '#send_keys' do
2834
it 'sends keys to the active element', except: {browser: %i[safari safari_preview]} do
@@ -172,9 +178,6 @@ module WebDriver
172178
.pointer_down(:left).pointer_up(:left)
173179
.perform
174180
expect(element.property(:value)).to eq('DoubleClicked')
175-
ensure
176-
# https://issues.chromium.org/issues/400087471
177-
reset_driver! if GlobalTestEnv.browser == :chrome && GlobalTestEnv.rbe?
178181
end
179182
end
180183

rb/spec/integration/selenium/webdriver/driver_spec.rb

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,10 +25,12 @@ module WebDriver
2525
it_behaves_like 'driver that can be started concurrently', exclude: [
2626
{browser: %i[safari safari_preview]},
2727
{browser: :firefox, rbe: true, reason: 'https://github.com/mozilla/geckodriver/issues/2219'},
28-
{driver: :remote, rbe: true, reason: 'Cannot start 2+ drivers at once.'}
28+
{driver: :remote, rbe: true, reason: 'Cannot start 2+ drivers at once.' }
2929
]
3030

31-
it 'creates default capabilities', exclude: {browser: %i[safari safari_preview]} do
31+
after { reset_driver! if GlobalTestEnv.rbe? && GlobalTestEnv.browser == :chrome }
32+
33+
it 'creates default capabilities', exclude: { browser: %i[safari safari_preview] } do
3234
reset_driver! do |driver|
3335
caps = driver.capabilities
3436
expect(caps.proxy).to be_nil
@@ -60,8 +62,7 @@ module WebDriver
6062

6163
it 'refreshes the page' do
6264
driver.navigate.to url_for('javascriptPage.html')
63-
sleep 1 # javascript takes too long to load
64-
driver.find_element(id: 'updatediv').click
65+
short_wait { driver.find_element(id: 'updatediv') }.click
6566
expect(driver.find_element(id: 'dynamo').text).to eq('Fish and chips!')
6667
driver.navigate.refresh
6768
wait_for_element(id: 'dynamo')

rb/spec/integration/selenium/webdriver/select_spec.rb

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@ module Support
2929
let(:multi_disabled) { described_class.new(driver.find_element(name: 'multi_disabled')) }
3030

3131
before { driver.navigate.to url_for('formPage.html') }
32+
after { reset_driver! if GlobalTestEnv.rbe? && GlobalTestEnv.browser == :chrome }
3233

3334
describe '#initialize' do
3435
it 'raises exception if not a select element' do

rb/spec/integration/selenium/webdriver/target_locator_spec.rb

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -89,9 +89,6 @@ module WebDriver
8989
expect {
9090
driver.switch_to.new_window(:unknown)
9191
}.to raise_error(ArgumentError)
92-
ensure
93-
# https://issues.chromium.org/issues/400087471
94-
reset_driver! if GlobalTestEnv.browser == :chrome && GlobalTestEnv.rbe?
9592
end
9693

9794
it 'switches to the new window then close it when given a block' do

0 commit comments

Comments
 (0)