[rb] improve flaky tests with explicit wait

Author: titusfortner

rb/spec/integration/selenium/webdriver/driver_spec.rb

@@ -337,7 +337,7 @@ module WebDriver
 
         it 'is able to pass element arguments' do
           driver.navigate.to url_for('javascriptPage.html')
-          button = driver.find_element(id: 'plainButton')
+          button = short_wait { driver.find_element(id: 'plainButton') }
           js = "arguments[0]['flibble'] = arguments[0].getAttribute('id'); return arguments[0]['flibble'];"
           expect(driver.execute_script(js, button))
             .to eq('plainButton')

rb/spec/integration/selenium/webdriver/select_spec.rb

@@ -23,7 +23,8 @@ module Selenium
   module WebDriver
     module Support
       describe Select, exclusive: {bidi: false, reason: 'Not yet implemented with BiDi'} do
-        let(:select) { described_class.new(driver.find_element(name: 'selectomatic')) }
+        let(:selectomatic) { short_wait { driver.find_element(name: 'selectomatic') } }
+        let(:select) { described_class.new(selectomatic) }
         let(:multi_select) { described_class.new(driver.find_element(id: 'multi')) }
         let(:single_disabled) { described_class.new(driver.find_element(name: 'single_disabled')) }
         let(:multi_disabled) { described_class.new(driver.find_element(name: 'multi_disabled')) }

rb/spec/integration/selenium/webdriver/spec_support/helpers.rb

@@ -60,6 +60,12 @@ def long_wait
 
         def short_wait
           @short_wait ||= Wait.new(timeout: 3)
+
+          return @short_wait unless block_given?
+
+          result = nil
+          @short_wait.until { result = yield }
+          result
         end
 
         def wait_for_alert