[rust] Use mkv as video container for all recordings

Author: bonigarcia

rust/src/ffmpeg.rs

@@ -39,12 +39,10 @@ const FFMPEG_WINDOWS_RELEASE_URL: &str =
 const FFMPEG_LINUX_RELEASE_URL: &str = "https://github.com/BtbN/FFmpeg-Builds/releases/download/latest/ffmpeg-n{}-latest-linux64-gpl-{}.tar.xz";
 const FFMPEG_MACOS_RELEASE_URL: &str = "https://evermeet.cx/ffmpeg/ffmpeg-{}.zip";
 const FFMPEG_RECORD_FRAME_RATE: &str = "30";
-const FFMPEG_RECORD_DESKTOP_WINDOWS_COMMAND: &str = "{} -f gdigrab -i desktop -r {} -q:v 1 -y {}";
-const FFMPEG_RECORD_DESKTOP_LINUX_COMMAND: &str = "{} -f x11grab -i {} -r {} -vcodec huffyuv -y {}";
-const FFMPEG_RECORD_DESKTOP_MACOS_COMMAND: &str =
-    r#"{} -f avfoundation -i 0 -r {} -pix_fmt yuv420p -y {}"#;
-const FFMPEG_RECORDING_EXTENSION_AVI: &str = "avi";
-const FFMPEG_RECORDING_EXTENSION_MOV: &str = "mov";
+const FFMPEG_RECORD_DESKTOP_WINDOWS_COMMAND: &str = "{} -f gdigrab -i desktop -r {} -y {}";
+const FFMPEG_RECORD_DESKTOP_LINUX_COMMAND: &str = "{} -f x11grab -i {} -r {} -y {}";
+const FFMPEG_RECORD_DESKTOP_MACOS_COMMAND: &str = r#"{} -f avfoundation -i 0 -r {} -y {}"#;
+const FFMPEG_RECORDING_EXTENSION_MKV: &str = "mkv";
 const FFMPEG_RECORDING_FOLDER: &str = "recordings";
 const FFMPEG_DEFAULT_DISPLAY: &str = ":0";
 
@@ -183,14 +181,9 @@ pub fn uncompress_ffmpeg(
     Ok(())
 }
 
-fn get_recording_name(os: &str) -> String {
+fn get_recording_name() -> String {
     let now = chrono::Local::now();
-    let extension = if MACOS.is(os) {
-        FFMPEG_RECORDING_EXTENSION_MOV
-    } else {
-        FFMPEG_RECORDING_EXTENSION_AVI
-    };
-    now.format("%Y-%m-%d_%H-%M-%S").to_string() + "." + extension
+    now.format("%Y-%m-%d_%H-%M-%S").to_string() + "." + FFMPEG_RECORDING_EXTENSION_MKV
 }
 
 pub fn record_desktop_with_ffmpeg(
@@ -201,7 +194,7 @@ pub fn record_desktop_with_ffmpeg(
 ) -> Result<(), Error> {
     let recording_target = cache_path
         .join(FFMPEG_RECORDING_FOLDER)
-        .join(get_recording_name(os));
+        .join(get_recording_name());
     let recording_name = path_to_string(&recording_target);
     create_parent_path_if_not_exists(&recording_target)?;