Skip to content

Commit 7d983ba

Browse files
committed
rb - add legacy firefox tests to travis
1 parent 5d7eb2a commit 7d983ba

File tree

2 files changed

+8
-5
lines changed

2 files changed

+8
-5
lines changed

.travis.yml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ env:
1818
- TASK=rb TARGET=unit-test
1919
- TASK=rb TARGET=chrome-test
2020
- TASK=rb TARGET=firefox-test
21+
- TASK=rb TARGET=ff-legacy-test
2122
- TASK=rb TARGET=phantomjs-test
2223
- TASK=py TOXENV=py27-chrome
2324
- TASK=py TOXENV=py27-firefox
@@ -26,7 +27,6 @@ env:
2627
matrix:
2728
fast_finish: true
2829
allow_failures:
29-
- env: TASK=rb TARGET=phantomjs-test
3030
- env: TASK=py TOXENV=py27-chrome
3131
- env: TASK=py TOXENV=py27-firefox
3232
- env: TASK=py TOXENV=py27-marionette
@@ -45,12 +45,13 @@ script:
4545
unzip chromedriver_linux64.zip && chmod +x chromedriver && sudo mv chromedriver /usr/local/bin
4646
fi
4747
- |
48-
if [[ $TOXENV == *"firefox"* ]]; then
48+
if [[ $TARGET == *"ff-legacy"* ]] || [ $TOXENV == *"firefox"* ]]; then
4949
pip install --user mozdownload mozinstall
5050
mozdownload --version 47.0.1 --destination firefox.tar.bz2
5151
mozinstall firefox.tar.bz2
5252
sudo ln -sf $PWD/firefox/firefox /usr/local/bin/firefox
5353
firefox --version
54+
export FF_LEGACY_BINARY=$PWD/firefox/firefox
5455
fi
5556
- |
5657
if [[ $TARGET == *"firefox"* ]] || [[ $TOXENV == *"marionette"* ]]; then

rb/spec/integration/selenium/webdriver/driver_spec.rb

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -266,9 +266,11 @@ module WebDriver
266266
expect(result).to eq([nil, 123, 'abc', true, false])
267267
end
268268

269-
it 'should be able to pass multiple arguments to async scripts' do
270-
result = driver.execute_async_script 'arguments[arguments.length - 1](arguments[0] + arguments[1]);', 1, 2
271-
expect(result).to eq(3)
269+
not_compliant_on driver: :phantomjs do
270+
it 'should be able to pass multiple arguments to async scripts' do
271+
result = driver.execute_async_script 'arguments[arguments.length - 1](arguments[0] + arguments[1]);', 1, 2
272+
expect(result).to eq(3)
273+
end
272274
end
273275

274276
# Edge BUG - https://connect.microsoft.com/IE/feedback/details/1849991/

0 commit comments

Comments
 (0)