[java] allow changing chromium driver log timestamp formatting

Author: titusfortner

java/src/org/openqa/selenium/chrome/ChromeDriverService.java

@@ -46,6 +46,11 @@ public class ChromeDriverService extends DriverService {
    */
   public static final String CHROME_DRIVER_EXE_PROPERTY = "webdriver.chrome.driver";
 
+  /**
+   * System property that toggles the formatting of the timestamps of the logs
+   */
+  public static final String CHROME_DRIVER_READABLE_TIMESTAMP = "webdriver.chrome.readableTimestamp";
+
   /**
    * System property that defines the default location where ChromeDriver output is logged.
    */
@@ -155,6 +160,7 @@ public static class Builder extends DriverService.Builder<
       ChromeDriverService, ChromeDriverService.Builder> {
 
     private boolean disableBuildCheck = Boolean.getBoolean(CHROME_DRIVER_DISABLE_BUILD_CHECK);
+    private boolean readableTimestamp = Boolean.getBoolean(CHROME_DRIVER_READABLE_TIMESTAMP);
     private boolean appendLog = Boolean.getBoolean(CHROME_DRIVER_APPEND_LOG_PROPERTY);
     private boolean verbose = Boolean.getBoolean(CHROME_DRIVER_VERBOSE_LOG_PROPERTY);
     private boolean silent = Boolean.getBoolean(CHROME_DRIVER_SILENT_OUTPUT_PROPERTY);
@@ -252,6 +258,17 @@ public Builder withWhitelistedIps(String whitelistedIps) {
       return this;
     }
 
+    /**
+     * Configures the format of the logging for the driver server.
+     *
+     * @param readableTimestamp Whether the timestamp of the log is readable.
+     * @return A self reference.
+     */
+    public Builder withReadableTimestamp(Boolean readableTimestamp) {
+      this.readableTimestamp = readableTimestamp;
+      return this;
+    }
+
     @Override
     protected File findDefaultExecutable() {
       return findExecutable(
@@ -282,6 +299,10 @@ protected List<String> createArgs() {
       args.add(String.format("--port=%d", getPort()));
       if (getLogFile() != null) {
         args.add(String.format("--log-path=%s", getLogFile().getAbsolutePath()));
+        // This flag only works when logged to file
+        if (readableTimestamp) {
+          args.add("--readable-timestamp");
+        }
       }
       if (appendLog) {
         args.add("--append-log");

java/src/org/openqa/selenium/edge/EdgeDriverService.java

@@ -46,6 +46,11 @@ public class EdgeDriverService extends DriverService {
    */
   public static final String EDGE_DRIVER_EXE_PROPERTY = "webdriver.edge.driver";
 
+  /**
+   * System property that toggles the formatting of the timestamps of the logs
+   */
+  public static final String EDGE_DRIVER_READABLE_TIMESTAMP = "webdriver.edge.readableTimestamp";
+
   /**
    * System property that defines the default location where MSEdgeDriver output is logged.
    */
@@ -124,6 +129,7 @@ public static class Builder extends DriverService.Builder<
     EdgeDriverService, Builder> {
 
     private boolean disableBuildCheck = Boolean.getBoolean(EDGE_DRIVER_DISABLE_BUILD_CHECK);
+    private boolean readableTimestamp = Boolean.getBoolean(EDGE_DRIVER_READABLE_TIMESTAMP);
     private boolean appendLog = Boolean.getBoolean(EDGE_DRIVER_APPEND_LOG_PROPERTY);
     private boolean verbose = Boolean.getBoolean(EDGE_DRIVER_VERBOSE_LOG_PROPERTY);
     private String logLevel = System.getProperty(EDGE_DRIVER_LOG_LEVEL_PROPERTY);
@@ -222,6 +228,17 @@ public Builder withAllowedListIps(String allowedListIps) {
       return this;
     }
 
+    /**
+     * Configures the format of the logging for the driver server.
+     *
+     * @param readableTimestamp Whether the timestamp of the log is readable.
+     * @return A self reference.
+     */
+    public Builder withReadableTimestamp(Boolean readableTimestamp) {
+      this.readableTimestamp = readableTimestamp;
+      return this;
+    }
+
     @Override
     protected File findDefaultExecutable() {
       return findExecutable(
@@ -252,6 +269,10 @@ protected List<String> createArgs() {
       args.add(String.format("--port=%d", getPort()));
       if (getLogFile() != null) {
         args.add(String.format("--log-path=%s", getLogFile().getAbsolutePath()));
+        // This flag only works when logged to file
+        if (readableTimestamp) {
+          args.add("--readable-timestamp");
+        }
       }
       if (appendLog) {
         args.add("--append-log");