Merge branch 'trunk' into feat/configurable-timeout-for-devtools-commands

Author: dennisoelkers

.bazelignore

@@ -1,5 +1,27 @@
 buck-out
+dotnet/test/firefox/bin
+dotnet/test/firefox/obj
+dotnet/test/edge/bin
+dotnet/test/edge/obj
+dotnet/test/common/bin
+dotnet/test/common/obj
+dotnet/test/support/bin
+dotnet/test/support/obj
+dotnet/test/safari/bin
+dotnet/test/safari/obj
+dotnet/test/chrome/bin
+dotnet/test/chrome/obj
+dotnet/test/ie/bin
+dotnet/test/ie/obj
+dotnet/test/remote/bin
+dotnet/test/remote/obj
+dotnet/src/support/bin
+dotnet/src/support/obj
+dotnet/src/webdriver/bin
+dotnet/src/webdriver/obj
+java/build/production
 java/client/build
 java/server/build
+javascript/grid-ui/node_modules
+javascript/node/selenium-webdriver/node_modules
 node_modules
-java/build/production

.bazelrc

@@ -1,47 +1,122 @@
-try-import .bazelrc.local
+try-import %workspace%/.bazelrc.local
+try-import %workspace%/.bazelrc.windows.local
+
+# Enable bzlmod but without lockfile for a moment.
+# Lockfile is a problem to check in at the moment
+# because of constant Git conflicts and platform-specific
+# pieces.
+# https://github.com/bazelbuild/bazel/issues/20369
+# https://github.com/bazelbuild/bazel/issues/21491
+
+common --enable_bzlmod --lockfile_mode=off
+
+# Ensure Windows support is accurate.
+
+startup --windows_enable_symlinks
+build --enable_runfiles
 
 build --flag_alias=pin_browsers=//common:pin_browsers
 build --flag_alias=headless=//common:headless
 
 # Set the default java toolchain
-build --java_runtime_version=remotejdk_11
-build --tool_java_language_version=11
 
-# We target java 8 by default
-build --javacopt="--release 8"
+build --java_language_version=17
+build --java_runtime_version=remotejdk_17
+build --tool_java_language_version=17
+build --tool_java_runtime_version=remotejdk_17
+
+# We target java 11 by default
+
+build --javacopt="--release 11"
 
 # Require java dependencies to be used and first-order
 build --experimental_strict_java_deps=strict
 build --explicit_java_test_deps
 
+# Avoid ErrorProne getting annoyed about "impossible null checks"
+build --javacopt="-Xep:ImpossibleNullComparison:OFF"
+
+# Allow spaces in runfile paths
+build --nobuild_runfile_links
+
+# More JS magic
+build --experimental_allow_unresolved_symlinks
+# Avoid a warning about directory tracking being unsound
+startup --host_jvm_args=-DBAZEL_TRACK_SOURCE_DIRECTORIES=1
+
+# Required for faster TS builds
+build --@aspect_rules_ts//ts:skipLibCheck=always
+fetch --@aspect_rules_ts//ts:skipLibCheck=always
+query --@aspect_rules_ts//ts:skipLibCheck=always
+
+build --@aspect_rules_ts//ts:default_to_tsc_transpiler
+fetch --@aspect_rules_ts//ts:default_to_tsc_transpiler
+query --@aspect_rules_ts//ts:default_to_tsc_transpiler
+
 # Ensure builds are unpolluted by the user env
+
 build --incompatible_strict_action_env
 
-# Except for the PATH environment variable
-build --action_env=PATH
+# Required to get `protobuf` compiling, which is required for `rules_closure`
+build --incompatible_enable_cc_toolchain_resolution
+build --cxxopt=-std=c++14
+build --host_cxxopt=-std=c++14
 
 # For build stamping
-build --workspace_status_command=scripts/build-info.py
+
+build --enable_platform_specific_config
+build:linux --workspace_status_command=scripts/build-info.sh
+build:macos --workspace_status_command=scripts/build-info.sh
+build:windows --workspace_status_command="powershell.exe scripts/build-info.ps1"
 
 # Make sure we get something helpful when tests fail
+
 build --verbose_failures
 build --test_output=errors
 
-# Tests need to be able to open sockets on localhost
-build --noexperimental_sandbox_default_allow_network
-
 # pass environment variables to the test environment
-build --test_env=CI
-build --test_env=DASHBOARD_URL
-build --test_env=DISPLAY
-build --test_env=FIREFOX_NIGHTLY_BINARY
-build --test_env=GITHUB_ACTIONS
-build --test_env=LOCALAPPDATA
-build --test_env=MOZ_HEADLESS
-build --test_env=PATH  # Remove once browser pinning works
-build --test_env=SELENIUM_BROWSER
-build --test_env=TRAVIS
+
+test --test_env=CI
+test --test_env=DASHBOARD_URL
+test --test_env=DISPLAY
+test --test_env=FIREFOX_NIGHTLY_BINARY
+test --test_env=GITHUB_ACTIONS
+test --test_env=MOZ_HEADLESS
+test --test_env=SELENIUM_BROWSER
+test --test_env=TRAVIS
+test --test_env=PYTHON_VERSION
+test --test_env=SE_AVOID_STATS=true
+
+# Remove once rules_ruby support proper $LOAD_PATH expansion.
+
+test --test_env=RUBYOPT="-Irb/lib -w"
+
+# Speed up JRuby startup.
+# https://github.com/jruby/jruby/wiki/Improving-startup-time
+
+build --action_env=JRUBY_OPTS="--dev"
+test --test_env=JRUBY_OPTS="--dev"
+
+# Expose necessary variables for Selenium-Manager.
+
+test:windows --test_env=PATH
+test:windows --test_env=LOCALAPPDATA
+test:windows --test_env=PROGRAMFILES="C:\\Program Files"
+test:windows --test_env=PROGRAMFILES(X86)="C:\\Program Files (x86)"
 
 test --test_timeout=1800
 
 test:node_debug --test_output=streamed --test_strategy=exclusive --test_timeout=9999 --nocache_test_results
+test:ruby_debug --test_output=streamed --test_env=RUBY_DEBUG_FORK_MODE=parent --run_under="@bundle//bin:rdbg --nonstop --open --command"
+
+
+build:release --stamp
+build:release --compilation_mode=opt
+
+# As regular `release` but all the build work happens on the RBE
+build:remote_release --config=release
+build:remote_release --config=remote
+build:remote_release --remote_download_toplevel
+
+# RBE
+import %workspace%/.bazelrc.remote

.bazelrc.remote

@@ -0,0 +1,68 @@
+# The RBE to use
+build:remote --bes_results_url=https://gypsum.cluster.engflow.com/invocation
+build:remote --bes_backend=grpcs://gypsum.cluster.engflow.com
+build:remote --remote_executor=grpcs://gypsum.cluster.engflow.com
+build:remote --remote_cache=grpcs://gypsum.cluster.engflow.com
+
+# The number of cores available
+build:remote -j 50
+
+build:remote --define=EXECUTOR=remote
+build:remote --experimental_inmemory_dotd_files
+build:remote --experimental_inmemory_jdeps_files
+build:remote --remote_timeout=3600
+build:remote --spawn_strategy=remote,local
+#build:remote --nolegacy_important_outputs
+build:remote --incompatible_strict_action_env=true
+
+build:remote --crosstool_top=//common/remote-build/cc:toolchain
+build:remote --extra_execution_platforms=//common/remote-build:platform
+build:remote --extra_toolchains=//common/remote-build:cc-toolchain
+build:remote --host_platform=//common/remote-build:platform
+build:remote --platforms=//common/remote-build:platform
+build:remote --cxxopt=-std=c++14
+
+# The Docker images are running Linux
+build:remote --cpu=k8
+build:remote --host_cpu=k8
+
+build:remote --disk_cache=
+
+build:remote --incompatible_enable_cc_toolchain_resolution
+build:remote --action_env=BAZEL_DO_NOT_DETECT_CPP_TOOLCHAIN=1
+test:remote --test_env=DISPLAY=:99.0
+test:remote --test_tag_filters=-skip-remote,-remote
+
+# Env vars we can hard code
+build:remote --action_env=HOME=/home/dev
+build:remote --action_env=PATH=/bin:/usr/bin:/usr/local/bin
+test:remote --test_env=PATH=/bin:/usr/bin:/usr/local/bin
+test:remote --test_env=HOME=/home/dev
+
+# Make sure we sniff credentials properly
+build:remote --credential_helper=gypsum.cluster.engflow.com=%workspace%/scripts/credential-helper.sh
+
+# Use pinned browsers when running remotely
+build:remote --//common:pin_browsers
+
+# The remote build machines are pretty small, and 50 threads may leave them
+# thrashing, but our dev machines are a lot larger. Scale the workload so we
+# make reasonable usage of everything, everywhere, all at once.
+build:remote --local_resources=cpu='HOST_CPUS*10'
+build:remote --local_resources=memory='HOST_RAM*4.0'
+
+# A small hint that we're running our tests remotely
+test:remote --test_env=REMOTE_BUILD=1
+
+# Wait for up to 5 minutes for a test to pass
+test:remote --test_timeout=600
+
+# Extend the remote config for CI
+build:remote-ci --config=remote
+build:remote-ci --curses=no --color=yes --show_timestamps --show_progress_rate_limit=5
+build:remote-ci --bes_upload_mode=wait_for_upload_complete
+build:remote-ci --remote_download_minimal
+
+# Configuration changes suggested by EngFlow
+build:remote --grpc_keepalive_time=30s
+build:remote --nolegacy_important_outputs

.bazelversion

@@ -1 +1 @@
-4.2.1
+7.4.1

.devcontainer/devcontainer.json

@@ -0,0 +1,9 @@
+// https://containers.dev/implementors/json_reference/
+
+{
+  "name": "selenium-devcontainer",
+  "build": {
+    "dockerfile": "../scripts/dev-image/Dockerfile"
+  },
+  "runArgs": ["--name", "selenium_devcontainer"]
+}

.editorconfig

@@ -53,3 +53,7 @@ indent_style = space
 indent_size = 2
 end_of_line = crlf
 charset = utf-8
+
+[{*.bazel,WORKSPACE}]
+indent_style = space
+indent_size = 4

.github/.bazelrc.local

@@ -48,8 +48,9 @@ body:
     attributes:
       label: Relevant log output
       description: |
-        Please copy and paste any relevant log output. This will be automatically formatted, so
-        no need for backticks.
+        Please copy and paste any relevant log output.
+        Ideally, turn on more detailed logging: https://www.selenium.dev/documentation/webdriver/troubleshooting/logging/
+        This will be automatically formatted, so no need for backticks.
       render: shell
     validations:
       required: true