Skip to content

Commit 81e72f9

Browse files
modified code files
1 parent c6d198b commit 81e72f9

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

rb/lib/selenium/webdriver/remote/bridge.rb

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -385,9 +385,10 @@ def add_cookie(cookie)
385385
end
386386

387387
def delete_cookie(name)
388-
raise ArgumentError, 'Cookie name cannot be null or empty' unless name || !name.empty?
388+
raise ArgumentError, 'Cookie name cannot be null or empty' if name.nil? || name.strip.empty?
389389
execute :delete_cookie, name: name
390390
end
391+
391392

392393
def cookie(name)
393394
execute :get_cookie, name: name

rb/spec/integration/selenium/webdriver/manager_spec.rb

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -242,10 +242,11 @@ module WebDriver
242242
expect(driver.manage.all_cookies.find { |c| c[:name] == 'foo' }).to be_nil
243243
end
244244

245-
it 'throws error when cookie name is empty string' do
245+
it 'throws an error when cookie name is an empty string' do
246246
expect { driver.manage.delete_cookie('') }
247-
.to raise_exception(ArgumentError)
247+
.to raise_error(ArgumentError, /Cookie name cannot be null or empty/)
248248
end
249+
249250

250251
it 'deletes all' do
251252
driver.manage.add_cookie name: 'foo', value: 'bar'

0 commit comments

Comments
 (0)