Skip to content

Commit 8298121

Browse files
committed
Correctly detect we're using Marionette in tests
This seems a little more robust.
1 parent 515a1cb commit 8298121

File tree

1 file changed

+7
-3
lines changed

1 file changed

+7
-3
lines changed

java/client/test/org/openqa/selenium/testing/JUnit4TestBase.java

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -305,10 +305,14 @@ private static boolean matches(Browser browser, Driver[] drivers) {
305305
break;
306306

307307
case MARIONETTE:
308-
if (browser == Browser.ff && Boolean.getBoolean("webdriver.firefox.marionette")) {
309-
return true;
308+
if (browser != Browser.ff) {
309+
return false;
310310
}
311-
break;
311+
if (System.getProperty("webdriver.firefox.marionette") == null ||
312+
Boolean.getBoolean("webdriver.firefox.marionette")) {
313+
return true;
314+
}
315+
break;
312316

313317
case PHANTOMJS:
314318
if (browser == Browser.phantomjs) {

0 commit comments

Comments
 (0)