Addressing PR comments

Author: diemol

dotnet/src/webdriver/DriverService.cs

@@ -154,12 +154,6 @@ public int ProcessId
     /// </summary>
     public string? DriverServicePath { get; set; }
 
-    /// <summary>
-    /// Collects the driver log output and writes it to the console. Defaults to <see langword="true"/>.
-    /// Internal variable to avoid using the stream when logs are sent to a file.
-    /// </summary>
-    protected bool WriteDriverLogToConsole { get; set; } = true;
-
     /// <summary>
     /// Gets the command-line arguments for the driver service.
     /// </summary>
@@ -255,8 +249,8 @@ public void Start()
         this.driverServiceProcess.StartInfo.RedirectStandardOutput = true;
         this.driverServiceProcess.StartInfo.RedirectStandardError = true;
 
-        this.driverServiceProcess.OutputDataReceived += (s, e) => this.OnDriverProcessDataReceived(s, e, isError: false);
-        this.driverServiceProcess.ErrorDataReceived += (s, e) => this.OnDriverProcessDataReceived(s, e, isError: true);
+        this.driverServiceProcess.OutputDataReceived += this.OnDriverProcessDataReceived;
+        this.driverServiceProcess.ErrorDataReceived += this.OnDriverProcessDataReceived;
 
         DriverProcessStartingEventArgs eventArgs = new DriverProcessStartingEventArgs(this.driverServiceProcess.StartInfo);
         this.OnDriverProcessStarting(eventArgs);
@@ -332,18 +326,14 @@ protected virtual void OnDriverProcessStarted(DriverProcessStartedEventArgs even
     /// <param name="sender">The sender of the event.</param>
     /// <param name="args">The data received event arguments.</param>
     /// <param name="isError">A value indicating whether the data received is from the error stream.</param>
-    protected virtual void OnDriverProcessDataReceived(object sender, DataReceivedEventArgs args, bool isError)
+    protected virtual void OnDriverProcessDataReceived(object sender, DataReceivedEventArgs args)
     {
         if (string.IsNullOrEmpty(args.Data))
             return;
 
-        if (this.WriteDriverLogToConsole && !isError && _logger.IsEnabled(LogEventLevel.Info))
-        {
-            _logger.Info(args.Data);
-        }
-        if (this.WriteDriverLogToConsole && isError && _logger.IsEnabled(LogEventLevel.Error))
+        if (_logger.IsEnabled(LogEventLevel.Trace))
         {
-            _logger.Error(args.Data);
+            _logger.Trace(args.Data);
         }
     }
 

dotnet/src/webdriver/Firefox/FirefoxDriverService.cs

@@ -23,7 +23,6 @@
 using System.Globalization;
 using System.IO;
 using System.Text;
-using OpenQA.Selenium.Internal.Logging;
 
 namespace OpenQA.Selenium.Firefox;
 
@@ -33,7 +32,6 @@ namespace OpenQA.Selenium.Firefox;
 public sealed class FirefoxDriverService : DriverService
 {
     private const string DefaultFirefoxDriverServiceFileName = "geckodriver";
-    private static readonly ILogger _logger = Log.GetLogger(typeof(FirefoxDriverService));
 
     /// <summary>
     /// Process management fields for the log writer.
@@ -235,7 +233,6 @@ protected override void OnDriverProcessStarting(DriverProcessStartingEventArgs e
     {
         if (!string.IsNullOrEmpty(this.LogPath))
         {
-            this.WriteDriverLogToConsole = false;
             string? directory = Path.GetDirectoryName(this.LogPath);
             if (!string.IsNullOrEmpty(directory) && !Directory.Exists(directory))
             {
@@ -254,7 +251,7 @@ protected override void OnDriverProcessStarting(DriverProcessStartingEventArgs e
     /// <param name="sender">The sender of the event.</param>
     /// <param name="args">The data received event arguments.</param>
     /// <param name="isError">A value indicating whether the data received is from the error stream.</param>
-    protected override void OnDriverProcessDataReceived(object sender, DataReceivedEventArgs args, bool isError)
+    protected override void OnDriverProcessDataReceived(object sender, DataReceivedEventArgs args)
     {
         if (string.IsNullOrEmpty(args.Data))
             return;
@@ -264,12 +261,11 @@ protected override void OnDriverProcessDataReceived(object sender, DataReceivedE
             if (logWriter != null)
             {
                 logWriter.WriteLine(args.Data);
-                logWriter.Flush();
             }
         }
         else
         {
-            base.OnDriverProcessDataReceived(sender, args, isError);
+            base.OnDriverProcessDataReceived(sender, args);
         }
     }
 

dotnet/test/firefox/FirefoxDriverServiceTest.cs

@@ -79,7 +79,7 @@ public void ShouldRedirectGeckoDriverLogsToFile()
     [Test]
     public void ShouldRedirectGeckoDriverLogsToConsole()
     {
-        Log.SetLevel(LogEventLevel.Info).Handlers.Add(testLogHandler);
+        Log.SetLevel(LogEventLevel.Trace).Handlers.Add(testLogHandler);
         FirefoxOptions options = new FirefoxOptions();
         options.LogLevel = FirefoxDriverLogLevel.Info;