Skip to content

Commit 8c20eb7

Browse files
committed
From trunk
1 parent e3a623f commit 8c20eb7

File tree

4 files changed

+18
-4
lines changed

4 files changed

+18
-4
lines changed

dotnet/src/webdriver/BiDi/BiDi.cs

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@ public sealed class BiDi : IAsyncDisposable
3636
private Script.ScriptModule? _scriptModule;
3737
private Log.LogModule? _logModule;
3838
private Storage.StorageModule? _storageModule;
39+
private WebExtension.WebExtensionModule? _webExtensionModule;
3940

4041
private readonly object _moduleLock = new();
4142

@@ -150,6 +151,19 @@ public Storage.StorageModule Storage
150151
}
151152
}
152153

154+
public WebExtension.WebExtensionModule WebExtension
155+
{
156+
get
157+
{
158+
if (_webExtensionModule is not null) return _webExtensionModule;
159+
lock (_moduleLock)
160+
{
161+
_webExtensionModule ??= new WebExtension.WebExtensionModule(_broker);
162+
}
163+
return _webExtensionModule;
164+
}
165+
}
166+
153167
public Task<Session.StatusResult> StatusAsync()
154168
{
155169
return SessionModule.StatusAsync();

dotnet/src/webdriver/BiDi/WebExtension/InstallCommand.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,6 @@ public sealed record ExtensionBase64Encoded(string Value) : ExtensionData;
3939

4040
public sealed record ExtensionPath(string Path) : ExtensionData;
4141

42-
public sealed record InstallOptions : CommandOptions;
42+
public sealed class InstallOptions : CommandOptions;
4343

4444
public sealed record InstallResult(Extension Extension) : EmptyResult;

dotnet/src/webdriver/BiDi/WebExtension/UninstallCommand.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,4 +26,4 @@ internal sealed class UninstallCommand(UninstallCommandParameters @params)
2626

2727
internal sealed record UninstallCommandParameters(Extension Extension) : CommandParameters;
2828

29-
public sealed record UninstallOptions : CommandOptions;
29+
public sealed class UninstallOptions : CommandOptions;

dotnet/src/webdriver/BiDi/WebExtension/WebExtensionModule.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,10 +31,10 @@ public async Task<InstallResult> InstallAsync(ExtensionData extensionData, Insta
3131
return await Broker.ExecuteCommandAsync<InstallCommand, InstallResult>(new InstallCommand(@params), options).ConfigureAwait(false);
3232
}
3333

34-
internal async Task UninstallAsync(Extension extension, UninstallOptions? options = null)
34+
public async Task<EmptyResult> UninstallAsync(Extension extension, UninstallOptions? options = null)
3535
{
3636
var @params = new UninstallCommandParameters(extension);
3737

38-
await Broker.ExecuteCommandAsync(new UninstallCommand(@params), options).ConfigureAwait(false);
38+
return await Broker.ExecuteCommandAsync<UninstallCommand, EmptyResult>(new UninstallCommand(@params), options).ConfigureAwait(false);
3939
}
4040
}

0 commit comments

Comments
 (0)