Skip to content

Commit 8c9faf5

Browse files
committed
[java] Enabling some Chrome tests as the test runner says...
is marked as not yet implemented with CHROME but already works!
1 parent 6e90781 commit 8c9faf5

File tree

1 file changed

+10
-19
lines changed

1 file changed

+10
-19
lines changed

java/client/test/org/openqa/selenium/ElementDomAttributeTest.java

Lines changed: 10 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -17,25 +17,25 @@
1717

1818
package org.openqa.selenium;
1919

20+
import org.junit.Test;
21+
import org.openqa.selenium.environment.webserver.Page;
22+
import org.openqa.selenium.testing.Ignore;
23+
import org.openqa.selenium.testing.JUnit4TestBase;
24+
import org.openqa.selenium.testing.NotYetImplemented;
25+
26+
import java.util.List;
27+
2028
import static java.util.Arrays.asList;
2129
import static org.assertj.core.api.Assertions.assertThat;
2230
import static org.assertj.core.api.Assertions.assertThatExceptionOfType;
2331
import static org.openqa.selenium.testing.drivers.Browser.CHROME;
2432
import static org.openqa.selenium.testing.drivers.Browser.EDGE;
25-
import static org.openqa.selenium.testing.drivers.Browser.LEGACY_FIREFOX_XPI;
33+
import static org.openqa.selenium.testing.drivers.Browser.FIREFOX;
2634
import static org.openqa.selenium.testing.drivers.Browser.HTMLUNIT;
2735
import static org.openqa.selenium.testing.drivers.Browser.IE;
28-
import static org.openqa.selenium.testing.drivers.Browser.FIREFOX;
36+
import static org.openqa.selenium.testing.drivers.Browser.LEGACY_FIREFOX_XPI;
2937
import static org.openqa.selenium.testing.drivers.Browser.SAFARI;
3038

31-
import org.junit.Test;
32-
import org.openqa.selenium.environment.webserver.Page;
33-
import org.openqa.selenium.testing.Ignore;
34-
import org.openqa.selenium.testing.JUnit4TestBase;
35-
import org.openqa.selenium.testing.NotYetImplemented;
36-
37-
import java.util.List;
38-
3939
public class ElementDomAttributeTest extends JUnit4TestBase {
4040

4141
@Test
@@ -55,7 +55,6 @@ public void testShouldReturnNullWhenGettingSrcAttributeOfInvalidImgTag() {
5555
}
5656

5757
@Test
58-
@NotYetImplemented(value = CHROME, reason = "It returns a property")
5958
@NotYetImplemented(EDGE)
6059
public void testShouldReturnTheActualValueWhenGettingSrcAttributeOfAValidImgTag() {
6160
driver.get(pages.simpleTestPage);
@@ -65,7 +64,6 @@ public void testShouldReturnTheActualValueWhenGettingSrcAttributeOfAValidImgTag(
6564
}
6665

6766
@Test
68-
@NotYetImplemented(value = CHROME, reason = "It returns a property")
6967
@NotYetImplemented(EDGE)
7068
public void testShouldReturnTheActualValueWhenGettingHrefAttributeOfAValidAnchorTag() {
7169
driver.get(pages.simpleTestPage);
@@ -94,7 +92,6 @@ public void testShouldReturnTheValueOfTheDisabledAttributeAsNullIfNotSet() {
9492
}
9593

9694
@Test
97-
@NotYetImplemented(value = CHROME, reason = "It returns a property")
9895
@NotYetImplemented(EDGE)
9996
public void testShouldNotReturnTheValueOfTheIndexAttributeIfItIsMissing() {
10097
driver.get(pages.formPage);
@@ -183,7 +180,6 @@ public void testShouldReturnValueOfClassAttributeOfAnElement() {
183180
}
184181

185182
@Test
186-
@NotYetImplemented(value = CHROME, reason = "It returns a property")
187183
@NotYetImplemented(EDGE)
188184
public void testShouldNotReturnTheContentsOfATextAreaAsItsValue() {
189185
driver.get(pages.formPage);
@@ -192,7 +188,6 @@ public void testShouldNotReturnTheContentsOfATextAreaAsItsValue() {
192188
}
193189

194190
@Test
195-
@NotYetImplemented(value = CHROME, reason = "It returns a property")
196191
@NotYetImplemented(EDGE)
197192
public void testShouldNotReturnInnerHtmlProperty() {
198193
driver.get(pages.simpleTestPage);
@@ -216,7 +211,6 @@ public void testShouldTreatReadonlyAsAValue() {
216211
}
217212

218213
@Test
219-
@NotYetImplemented(value = CHROME, reason = "It returns a property")
220214
@NotYetImplemented(EDGE)
221215
public void testShouldNotReturnTextContentProperty() {
222216
driver.get(pages.simpleTestPage);
@@ -280,7 +274,6 @@ public void testgetDomAttributeDoesNotReturnAnObjectForSvgProperties() {
280274
}
281275

282276
@Test
283-
@NotYetImplemented(value = CHROME, reason = "It returns a property")
284277
@NotYetImplemented(EDGE)
285278
public void testCanRetrieveTheCurrentValueOfATextFormFieldWithPresetText() {
286279
driver.get(pages.formPage);
@@ -291,7 +284,6 @@ public void testCanRetrieveTheCurrentValueOfATextFormFieldWithPresetText() {
291284
}
292285

293286
@Test
294-
@NotYetImplemented(value = CHROME, reason = "It returns a property")
295287
@NotYetImplemented(EDGE)
296288
public void testShouldNotReturnTextOfATextArea() {
297289
driver.get(pages.formPage);
@@ -368,7 +360,6 @@ public void shouldTreatContenteditableAsEnumeratedButNotBoolean() {
368360

369361
@Test
370362
@NotYetImplemented(IE)
371-
@NotYetImplemented(CHROME)
372363
@NotYetImplemented(EDGE)
373364
@Ignore(LEGACY_FIREFOX_XPI)
374365
@NotYetImplemented(HTMLUNIT)

0 commit comments

Comments
 (0)