Creating temp dir for files uploaded to remote server.

Author: barancev

java/server/src/org/openqa/selenium/remote/server/InMemorySession.java

@@ -31,6 +31,7 @@
 import org.openqa.selenium.Capabilities;
 import org.openqa.selenium.HasCapabilities;
 import org.openqa.selenium.ImmutableCapabilities;
+import org.openqa.selenium.SessionNotCreatedException;
 import org.openqa.selenium.WebDriver;
 import org.openqa.selenium.io.TemporaryFilesystem;
 import org.openqa.selenium.remote.Dialect;
@@ -44,7 +45,6 @@
 import java.io.InputStream;
 import java.io.InputStreamReader;
 import java.io.Reader;
-import java.io.UncheckedIOException;
 import java.lang.reflect.Type;
 import java.nio.file.Files;
 import java.nio.file.Path;
@@ -84,6 +84,7 @@ private InMemorySession(WebDriver driver, Capabilities capabilities, Dialect dow
     this.downstream = Preconditions.checkNotNull(downstream);
 
     File tempRoot = new File(StandardSystemProperty.JAVA_IO_TMPDIR.value(), id.toString());
+    Preconditions.checkState(tempRoot.mkdirs());
     this.filesystem = TemporaryFilesystem.getTmpFsBasedOn(tempRoot);
 
     this.handler = new JsonHttpCommandHandler(
@@ -165,8 +166,8 @@ public ActiveSession apply(NewSessionPayload payload) {
                              Dialect.OSS :
                              payload.getDownstreamDialects().iterator().next();
         return new InMemorySession(driver, caps, downstream);
-      } catch (IOException e) {
-        throw new UncheckedIOException(e);
+      } catch (IOException|IllegalStateException e) {
+        throw new SessionNotCreatedException("Cannot establish new session", e);
       }
     }
 

java/server/src/org/openqa/selenium/remote/server/ServicedSession.java

@@ -20,6 +20,7 @@
 
 import static java.util.concurrent.TimeUnit.SECONDS;
 
+import com.google.common.base.Preconditions;
 import com.google.common.base.StandardSystemProperty;
 
 import org.openqa.selenium.SessionNotCreatedException;
@@ -69,7 +70,7 @@ public ServicedSession(
       Dialect upstream,
       SessionCodec codec,
       SessionId id,
-      Map<String, Object> capabilities) {
+      Map<String, Object> capabilities) throws IOException {
     this.service = service;
     this.downstream = downstream;
     this.upstream = upstream;
@@ -78,6 +79,7 @@ public ServicedSession(
     this.capabilities = capabilities;
 
     File tempRoot = new File(StandardSystemProperty.JAVA_IO_TMPDIR.value(), id.toString());
+    Preconditions.checkState(tempRoot.mkdirs());
     this.filesystem = TemporaryFilesystem.getTmpFsBasedOn(tempRoot);
   }
 
@@ -196,7 +198,7 @@ public ActiveSession apply(NewSessionPayload payload) {
             codec,
             new SessionId(response.getSessionId()),
             (Map<String, Object>) response.getValue());
-      } catch (IOException e) {
+      } catch (IOException|IllegalStateException|NullPointerException e) {
         throw new SessionNotCreatedException("Cannot establish new session", e);
       }
     }