Simplify cookies and add extra unit tests

Author: aguspe

rb/lib/selenium/webdriver/bidi/network/cookies.rb

@@ -21,34 +21,16 @@ module Selenium
   module WebDriver
     class BiDi
       class Cookies < Hash
-        KNOWN_KEYS = %i[name value domain path expiry http_only secure same_site size max_age].freeze
-
         def initialize(cookies = {})
           super()
           merge!(cookies)
         end
 
         def as_json
-          cookie_hash = {
-            name: self[:name].to_s,
-            value: {
-              type: 'string',
-              value: self[:value].to_s
-            },
-            domain: self[:domain],
-            path: self[:path],
-            size: self[:size],
-            httpOnly: self[:http_only],
-            secure: self[:secure],
-            sameSite: self[:same_site],
-            expiry: self[:expiry],
-            maxAge: self[:max_age]
-          }
-
-          extra_fields = except(KNOWN_KEYS)
-          cookie_hash.merge!(extra_fields) { |_k, old_val, _new_val| old_val }
+          self[:name] = self[:name].to_s
+          self[:value] = {type: 'string', value: self[:value].to_s}
 
-          [cookie_hash.compact]
+          [compact]
         end
       end
     end # BiDi

rb/spec/integration/selenium/webdriver/network_spec.rb

@@ -155,9 +155,9 @@ module WebDriver
                               domain: 'example.com',
                               path: '/path',
                               size: 1234,
-                              http_only: true,
+                              httpOnly: true,
                               secure: true,
-                              same_site: 'Strict',
+                              sameSite: 'Strict',
                               expiry: 1234
                             })
             request.body = ({test: 'example'})
@@ -247,11 +247,11 @@ module WebDriver
             response.cookies({
                                name: 'foo',
                                domain: 'localhost',
-                               http_only: true,
+                               httpOnly: true,
                                expiry: '1_000_000',
-                               max_age: 1_000,
+                               maxAge: 1_000,
                                path: '/',
-                               same_site: 'none',
+                               sameSite: 'none',
                                secure: false
                              })
             response.continue

rb/spec/unit/selenium/webdriver/bidi/cookies_spec.rb

@@ -44,9 +44,9 @@ class BiDi
                 domain: 'example.com',
                 path: '/path',
                 size: 1234,
-                http_only: true,
+                httpOnly: true,
                 secure: true,
-                same_site: 'Strict',
+                sameSite: 'Strict',
                 expiry: 1234
               }
             )
@@ -73,11 +73,11 @@ class BiDi
                                           name: 'test',
                                           value: 'bar',
                                           domain: 'localhost',
-                                          http_only: true,
+                                          httpOnly: true,
                                           expiry: '1_000_000',
-                                          max_age: 1_000,
+                                          maxAge: 1_000,
                                           path: '/',
-                                          same_site: 'lax',
+                                          sameSite: 'lax',
                                           secure: false
                                         })