Skip to content

Commit 8f46785

Browse files
committed
Hold json context per module
1 parent 4a9fa75 commit 8f46785

File tree

12 files changed

+157
-136
lines changed

12 files changed

+157
-136
lines changed

dotnet/src/webdriver/BiDi/BiDi.cs

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ internal Session.SessionModule SessionModule
5555
if (_sessionModule is not null) return _sessionModule;
5656
lock (_moduleLock)
5757
{
58-
_sessionModule ??= Module.Create<Session.SessionModule>(_broker);
58+
_sessionModule ??= Module.Create<Session.SessionModule>(this, _broker);
5959
}
6060
return _sessionModule;
6161
}
@@ -68,7 +68,7 @@ public BrowsingContext.BrowsingContextModule BrowsingContext
6868
if (_browsingContextModule is not null) return _browsingContextModule;
6969
lock (_moduleLock)
7070
{
71-
_browsingContextModule ??= Module.Create<BrowsingContext.BrowsingContextModule>(_broker);
71+
_browsingContextModule ??= Module.Create<BrowsingContext.BrowsingContextModule>(this, _broker);
7272
}
7373
return _browsingContextModule;
7474
}
@@ -81,7 +81,7 @@ public Browser.BrowserModule Browser
8181
if (_browserModule is not null) return _browserModule;
8282
lock (_moduleLock)
8383
{
84-
_browserModule ??= Module.Create<Browser.BrowserModule>(_broker);
84+
_browserModule ??= Module.Create<Browser.BrowserModule>(this, _broker);
8585
}
8686
return _browserModule;
8787
}
@@ -94,7 +94,7 @@ public Network.NetworkModule Network
9494
if (_networkModule is not null) return _networkModule;
9595
lock (_moduleLock)
9696
{
97-
_networkModule ??= Module.Create<Network.NetworkModule>(_broker);
97+
_networkModule ??= Module.Create<Network.NetworkModule>(this, _broker);
9898
}
9999
return _networkModule;
100100
}
@@ -107,7 +107,7 @@ internal Input.InputModule InputModule
107107
if (_inputModule is not null) return _inputModule;
108108
lock (_moduleLock)
109109
{
110-
_inputModule ??= Module.Create<Input.InputModule>(_broker);
110+
_inputModule ??= Module.Create<Input.InputModule>(this, _broker);
111111
}
112112
return _inputModule;
113113
}
@@ -120,7 +120,7 @@ public Script.ScriptModule Script
120120
if (_scriptModule is not null) return _scriptModule;
121121
lock (_moduleLock)
122122
{
123-
_scriptModule ??= Module.Create<Script.ScriptModule>(_broker);
123+
_scriptModule ??= Module.Create<Script.ScriptModule>(this, _broker);
124124
}
125125
return _scriptModule;
126126
}
@@ -133,7 +133,7 @@ public Log.LogModule Log
133133
if (_logModule is not null) return _logModule;
134134
lock (_moduleLock)
135135
{
136-
_logModule ??= Module.Create<Log.LogModule>(_broker);
136+
_logModule ??= Module.Create<Log.LogModule>(this, _broker);
137137
}
138138
return _logModule;
139139
}
@@ -146,7 +146,7 @@ public Storage.StorageModule Storage
146146
if (_storageModule is not null) return _storageModule;
147147
lock (_moduleLock)
148148
{
149-
_storageModule ??= Module.Create<Storage.StorageModule>(_broker);
149+
_storageModule ??= Module.Create<Storage.StorageModule>(this, _broker);
150150
}
151151
return _storageModule;
152152
}
@@ -159,7 +159,7 @@ public WebExtension.WebExtensionModule WebExtension
159159
if (_webExtensionModule is not null) return _webExtensionModule;
160160
lock (_moduleLock)
161161
{
162-
_webExtensionModule ??= Module.Create<WebExtension.WebExtensionModule>(_broker);
162+
_webExtensionModule ??= Module.Create<WebExtension.WebExtensionModule>(this, _broker);
163163
}
164164
return _webExtensionModule;
165165
}
@@ -172,7 +172,7 @@ public Emulation.EmulationModule Emulation
172172
if (_emulationModule is not null) return _emulationModule;
173173
lock (_moduleLock)
174174
{
175-
_emulationModule ??= Module.Create<Emulation.EmulationModule>(_broker);
175+
_emulationModule ??= Module.Create<Emulation.EmulationModule>(this, _broker);
176176
}
177177
return _emulationModule;
178178
}

dotnet/src/webdriver/BiDi/Browser/BrowserModule.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ public async Task<EmptyResult> SetDownloadBehaviorDeniedAsync(SetDownloadBehavio
7777
return await Broker.ExecuteCommandAsync<SetDownloadBehaviorCommand, EmptyResult>(new SetDownloadBehaviorCommand(@params), options, JsonContext).ConfigureAwait(false);
7878
}
7979

80-
protected internal override JsonSerializerContext ConfigureJson(JsonSerializerOptions options)
80+
protected internal override JsonSerializerContext Initialize(JsonSerializerOptions options)
8181
{
8282
return new BrowserModuleJsonSerializerContext(options);
8383
}

0 commit comments

Comments
 (0)