Skip to content

Commit 8ff195d

Browse files
committed
use a custom fedcm_webserver fixture to use the ExtendedHandler
1 parent bd2b3f6 commit 8ff195d

File tree

2 files changed

+14
-3
lines changed

2 files changed

+14
-3
lines changed

py/conftest.py

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121
import subprocess
2222
import time
2323
from test.selenium.webdriver.common.network import get_lan_ip
24+
from test.selenium.webdriver.common.webserver import ExtendedHandler
2425
from test.selenium.webdriver.common.webserver import SimpleWebServer
2526
from urllib.request import urlopen
2627

@@ -329,6 +330,16 @@ def webserver(request):
329330
webserver.stop()
330331

331332

333+
@pytest.fixture(scope="session")
334+
def fedcm_webserver(request):
335+
"""Webserver fixture specifically for FedCM tests using ExtendedHandler."""
336+
host = get_lan_ip() if request.config.getoption("use_lan_ip") else None
337+
webserver = SimpleWebServer(host=host, handler_class=ExtendedHandler)
338+
webserver.start()
339+
yield webserver
340+
webserver.stop()
341+
342+
332343
@pytest.fixture
333344
def edge_service():
334345
from selenium.webdriver.edge.service import Service as EdgeService

py/test/selenium/webdriver/chrome/fedcm_tests.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,8 @@
2222

2323
class TestFedCM:
2424
@pytest.fixture(autouse=True)
25-
def setup(self, driver, webserver):
26-
driver.get(webserver.where_is("fedcm/fedcm.html", localhost=True))
25+
def setup(self, driver, fedcm_webserver):
26+
driver.get(fedcm_webserver.where_is("fedcm/fedcm.html", localhost=True))
2727
self.dialog = driver.fedcm_dialog
2828

2929
def test_no_dialog_present(self, driver):
@@ -40,7 +40,7 @@ def test_no_dialog_present(self, driver):
4040
with pytest.raises(NoAlertPresentException):
4141
self.dialog.cancel()
4242

43-
def test_dialog_present(self, driver, webserver):
43+
def test_dialog_present(self, driver):
4444

4545
driver.execute_script("triggerFedCm();")
4646
dialog = driver.wait_for_fedcm_dialog()

0 commit comments

Comments
 (0)