pass init_args_for_pool_manager in constructor

Author: navin772

py/selenium/webdriver/remote/remote_connection.py

@@ -241,9 +241,9 @@ def _separate_http_proxy_auth(self):
         proxy_without_auth = protocol + no_protocol[len(auth) + 1 :]
         return proxy_without_auth, auth
 
-    def _get_connection_manager(self, **pool_manager_kwargs):
+    def _get_connection_manager(self):
         pool_manager_init_args = {"timeout": self.get_timeout()}
-        pool_manager_init_args.update(pool_manager_kwargs.get("init_args_for_pool_manager", {}))
+        pool_manager_init_args.update(self._init_args_for_pool_manager.get("init_args_for_pool_manager", {}))
 
         if self._ignore_certificates:
             pool_manager_init_args["cert_reqs"] = "CERT_NONE"
@@ -270,10 +270,12 @@ def __init__(
         keep_alive: bool = False,
         ignore_proxy: bool = False,
         ignore_certificates: bool = False,
+        init_args_for_pool_manager: dict = None,
     ):
         self.keep_alive = keep_alive
         self._url = remote_server_addr
         self._ignore_certificates = ignore_certificates
+        self._init_args_for_pool_manager = init_args_for_pool_manager or {}
 
         # Env var NO_PROXY will override this part of the code
         _no_proxy = os.environ.get("no_proxy", os.environ.get("NO_PROXY"))

py/test/unit/selenium/webdriver/remote/remote_connection_tests.py

@@ -304,9 +304,9 @@ def test_get_connection_manager_ignores_certificates(monkeypatch):
 
 
 def test_get_connection_manager_with_custom_args():
-    custom_args = {"retries": 3, "block": True}
-    remote_connection = RemoteConnection("http://remote", keep_alive=False)
-    conn = remote_connection._get_connection_manager(init_args_for_pool_manager=custom_args)
+    custom_args = {"init_args_for_pool_manager": {"retries": 3, "block": True}}
+    remote_connection = RemoteConnection("http://remote", keep_alive=False, init_args_for_pool_manager=custom_args)
+    conn = remote_connection._get_connection_manager()
 
     assert isinstance(conn, urllib3.PoolManager)
     assert conn.connection_pool_kw["retries"] == 3