Merge branch 'trunk' into feat-14291/jspecify-nullable-annotation

Author: diemol

CONTRIBUTING.md

@@ -62,11 +62,11 @@ on Github.
 
 This document will guide you through the contribution process.
 
-### Step 1: Fork
+### Step 1: Fork & Clone
 
 Fork the project [on Github](https://github.com/seleniumhq/selenium)
-and check out your copy locally. Use `--depth 1` for a quick check out.
-The repository is ~2GB and checking the whole history takes a while.
+and clone the repository locally. Use `--depth 1` for a quick clone.
+The repository is over 2GB and cloning the whole history takes a while.
 
 ```shell
 % git clone [email protected]:username/selenium.git --depth 1
@@ -76,7 +76,7 @@ The repository is ~2GB and checking the whole history takes a while.
 
 #### Dependencies
 
-We bundle dependencies in the _third-party/_ directory that is not
+We bundle dependencies in the _third-party/_ directory that are not
 part of the proper project. Any changes to files in this directory or
 its subdirectories should be sent upstream to the respective projects.
 Please don't send your patch to us as we cannot accept it.

Rakefile

@@ -963,9 +963,9 @@ namespace :java do
     ENV['MAVEN_USER'] ||= ENV.fetch('SEL_M2_USER', nil)
     ENV['MAVEN_PASSWORD'] ||= ENV.fetch('SEL_M2_PASS', nil)
     read_m2_user_pass unless ENV['MAVEN_PASSWORD'] && ENV['MAVEN_USER']
-
-    repo = nightly ? 'content/repositories/snapshots' : 'service/local/staging/deploy/maven2'
-    ENV['MAVEN_REPO'] = "https://oss.sonatype.org/#{repo}"
+    repo_domain = 'central.sonatype.com'
+    repo = nightly ? "#{repo_domain}/repository/maven-snapshots" : "ossrh-staging-api.#{repo_domain}/service/local/"
+    ENV['MAVEN_REPO'] = "https://#{repo}"
     ENV['GPG_SIGN'] = (!nightly).to_s
 
     if nightly

common/repositories.bzl

@@ -165,8 +165,8 @@ js_library(
 
     http_archive(
         name = "linux_edgedriver",
-        url = "https://msedgedriver.azureedge.net/137.0.3296.83/edgedriver_linux64.zip",
-        sha256 = "141cd4cd42b7642dec1f215e0b1a0c1dae05f573218cb8ef18b876efa14f152a",
+        url = "https://msedgedriver.azureedge.net/137.0.3296.93/edgedriver_linux64.zip",
+        sha256 = "417bdfafbe8358e2b040b86b0e255344e0d200bd7087a9d85171abc9fc0c29c3",
         build_file_content = """
 load("@aspect_rules_js//js:defs.bzl", "js_library")
 package(default_visibility = ["//visibility:public"])
@@ -182,8 +182,8 @@ js_library(
 
     http_archive(
         name = "mac_edgedriver",
-        url = "https://msedgedriver.azureedge.net/137.0.3296.83/edgedriver_mac64.zip",
-        sha256 = "e361cfea041e649944a60a41ec40076be35fda8608e9011fad638ec0491a1f79",
+        url = "https://msedgedriver.azureedge.net/137.0.3296.93/edgedriver_mac64.zip",
+        sha256 = "d55e0f377ba45c1d754625b88f16493bded924b41bd624210241493b77e4fdb9",
         build_file_content = """
 load("@aspect_rules_js//js:defs.bzl", "js_library")
 package(default_visibility = ["//visibility:public"])

dotnet/src/webdriver/BiDi/Browser/ClientWindow.cs

@@ -19,7 +19,7 @@
 
 namespace OpenQA.Selenium.BiDi.Browser;
 
-public record ClientWindow
+public sealed record ClientWindow
 {
     internal ClientWindow(string id)
     {

dotnet/src/webdriver/BiDi/Browser/ClientWindowInfo.cs

@@ -19,7 +19,7 @@
 
 namespace OpenQA.Selenium.BiDi.Browser;
 
-public record ClientWindowInfo(bool Active, ClientWindow ClientWindow, ClientWindowState State, int Height, int Width, int X, int Y);
+public sealed record ClientWindowInfo(bool Active, ClientWindow ClientWindow, ClientWindowState State, int Height, int Width, int X, int Y);
 
 public enum ClientWindowState
 {

dotnet/src/webdriver/BiDi/Browser/CloseCommand.cs

@@ -21,7 +21,7 @@
 
 namespace OpenQA.Selenium.BiDi.Browser;
 
-internal class CloseCommand()
+internal sealed class CloseCommand()
     : Command<CommandParameters, EmptyResult>(CommandParameters.Empty, "browser.close");
 
-public record CloseOptions : CommandOptions;
+public sealed class CloseOptions : CommandOptions;

dotnet/src/webdriver/BiDi/Browser/CreateUserContextCommand.cs

@@ -21,12 +21,12 @@
 
 namespace OpenQA.Selenium.BiDi.Browser;
 
-internal class CreateUserContextCommand(CreateUserContextCommandParameters @params)
+internal sealed class CreateUserContextCommand(CreateUserContextCommandParameters @params)
     : Command<CreateUserContextCommandParameters, UserContextInfo>(@params, "browser.createUserContext");
 
-internal record CreateUserContextCommandParameters(bool? AcceptInsecureCerts, Session.ProxyConfiguration? Proxy) : CommandParameters;
+internal sealed record CreateUserContextCommandParameters(bool? AcceptInsecureCerts, Session.ProxyConfiguration? Proxy) : CommandParameters;
 
-public record CreateUserContextOptions : CommandOptions
+public sealed class CreateUserContextOptions : CommandOptions
 {
     public bool? AcceptInsecureCerts { get; set; }
 

dotnet/src/webdriver/BiDi/Browser/GetClientWindowsCommand.cs

@@ -23,12 +23,12 @@
 
 namespace OpenQA.Selenium.BiDi.Browser;
 
-internal class GetClientWindowsCommand()
+internal sealed class GetClientWindowsCommand()
     : Command<CommandParameters, GetClientWindowsResult>(CommandParameters.Empty, "browser.getClientWindows");
 
-public record GetClientWindowsOptions : CommandOptions;
+public sealed class GetClientWindowsOptions : CommandOptions;
 
-public record GetClientWindowsResult : EmptyResult, IReadOnlyList<ClientWindowInfo>
+public sealed record GetClientWindowsResult : EmptyResult, IReadOnlyList<ClientWindowInfo>
 {
     private readonly IReadOnlyList<ClientWindowInfo> _clientWindows;
 

dotnet/src/webdriver/BiDi/Browser/GetUserContextsCommand.cs

@@ -23,12 +23,12 @@
 
 namespace OpenQA.Selenium.BiDi.Browser;
 
-internal class GetUserContextsCommand()
+internal sealed class GetUserContextsCommand()
     : Command<CommandParameters, GetUserContextsResult>(CommandParameters.Empty, "browser.getUserContexts");
 
-public record GetUserContextsOptions : CommandOptions;
+public class GetUserContextsOptions : CommandOptions;
 
-public record GetUserContextsResult : EmptyResult, IReadOnlyList<UserContextInfo>
+public sealed record GetUserContextsResult : EmptyResult, IReadOnlyList<UserContextInfo>
 {
     private readonly IReadOnlyList<UserContextInfo> _userContexts;
 

dotnet/src/webdriver/BiDi/Browser/RemoveUserContextCommand.cs

@@ -21,9 +21,9 @@
 
 namespace OpenQA.Selenium.BiDi.Browser;
 
-internal class RemoveUserContextCommand(RemoveUserContextCommandParameters @params)
+internal sealed class RemoveUserContextCommand(RemoveUserContextCommandParameters @params)
     : Command<RemoveUserContextCommandParameters, EmptyResult>(@params, "browser.removeUserContext");
 
-internal record RemoveUserContextCommandParameters(UserContext UserContext) : CommandParameters;
+internal sealed record RemoveUserContextCommandParameters(UserContext UserContext) : CommandParameters;
 
-public record RemoveUserContextOptions : CommandOptions;
+public sealed class RemoveUserContextOptions : CommandOptions;