Merge branch 'trunk' into bidi-AOT

Author: RenderMichael

common/mirror/selenium

@@ -3,13 +3,13 @@
     "tag_name": "nightly",
     "assets": [
       {
-        "browser_download_url": "https://github.com/SeleniumHQ/selenium/releases/download/nightly/selenium-java-4.30.0-SNAPSHOT.zip"
+        "browser_download_url": "https://github.com/SeleniumHQ/selenium/releases/download/nightly/selenium-java-4.30.0.zip"
       },
       {
-        "browser_download_url": "https://github.com/SeleniumHQ/selenium/releases/download/nightly/selenium-server-4.30.0-SNAPSHOT.jar"
+        "browser_download_url": "https://github.com/SeleniumHQ/selenium/releases/download/nightly/selenium-server-4.30.0.jar"
       },
       {
-        "browser_download_url": "https://github.com/SeleniumHQ/selenium/releases/download/nightly/selenium-server-4.30.0-SNAPSHOT.zip"
+        "browser_download_url": "https://github.com/SeleniumHQ/selenium/releases/download/nightly/selenium-server-4.30.0.zip"
       }
     ]
   },

java/src/org/openqa/selenium/remote/RemoteWebDriver.java

@@ -869,6 +869,9 @@ public void addCookie(Cookie cookie) {
 
     @Override
     public void deleteCookieNamed(String name) {
+      if (name == null || name.isBlank()) {
+        throw new IllegalArgumentException("Cookie name cannot be empty");
+      }
       execute(DriverCommand.DELETE_COOKIE(name));
     }
 
@@ -927,6 +930,9 @@ public Set<Cookie> getCookies() {
 
     @Override
     public Cookie getCookieNamed(String name) {
+      if (name == null || name.isBlank()) {
+        throw new IllegalArgumentException("Cookie name cannot be empty");
+      }
       Set<Cookie> allCookies = getCookies();
       for (Cookie cookie : allCookies) {
         if (cookie.getName().equals(name)) {

java/test/org/openqa/selenium/CookieImplementationTest.java

@@ -18,6 +18,7 @@
 package org.openqa.selenium;
 
 import static org.assertj.core.api.Assertions.assertThat;
+import static org.junit.jupiter.api.Assertions.assertThrows;
 import static org.junit.jupiter.api.Assumptions.assumeTrue;
 import static org.openqa.selenium.testing.drivers.Browser.ALL;
 import static org.openqa.selenium.testing.drivers.Browser.CHROME;
@@ -503,6 +504,18 @@ public void testDeleteNotExistedCookie() {
     driver.manage().deleteCookieNamed(key);
   }
 
+  @Test
+  public void testDeleteEmptyNamedCookie() {
+    assertThrows(IllegalArgumentException.class, () -> driver.manage().deleteCookieNamed(""));
+    assertThrows(IllegalArgumentException.class, () -> driver.manage().deleteCookieNamed(" "));
+  }
+
+  @Test
+  public void testGetEmptyNamedCookie() {
+    assertThrows(IllegalArgumentException.class, () -> driver.manage().getCookieNamed(""));
+    assertThrows(IllegalArgumentException.class, () -> driver.manage().getCookieNamed(" "));
+  }
+
   @Test
   @Ignore(value = ALL, reason = "Non W3C conformant")
   public void testShouldDeleteOneOfTheCookiesWithTheSameName() {

py/docs/source/index.rst

@@ -14,7 +14,7 @@ The `selenium` package is used to automate web browser interaction from Python.
 +-----------------+--------------------------------------------------------------------------------------+
 | **GitHub**:     | https://github.com/SeleniumHQ/Selenium                                               |
 +-----------------+--------------------------------------------------------------------------------------+
-| **PyPI**:       | https://pypi.org/project/selenium                                                   |
+| **PyPI**:       | https://pypi.org/project/selenium                                                    |
 +-----------------+--------------------------------------------------------------------------------------+
 | **API Docs**:   | https://selenium.dev/selenium/docs/api/py/api.html                                   |
 +-----------------+--------------------------------------------------------------------------------------+

py/selenium/webdriver/common/actions/action_builder.py

@@ -52,7 +52,7 @@ def get_device_with(self, name: str) -> Optional[Union["WheelInput", "PointerInp
         """Get the device with the given name.
 
         Parameters:
-        ----------
+        -----------
         name : str
             The name of the device to get.
 
@@ -86,7 +86,7 @@ def add_key_input(self, name: str) -> KeyInput:
         """Add a new key input device to the action builder.
 
         Parameters:
-        ----------
+        -----------
         name : str
             The name of the key input device.
 
@@ -107,7 +107,7 @@ def add_pointer_input(self, kind: str, name: str) -> PointerInput:
         """Add a new pointer input device to the action builder.
 
         Parameters:
-        ----------
+        -----------
         kind : str
             The kind of pointer input device.
                 - "mouse"
@@ -134,7 +134,7 @@ def add_wheel_input(self, name: str) -> WheelInput:
         """Add a new wheel input device to the action builder.
 
         Parameters:
-        ----------
+        -----------
         name : str
             The name of the wheel input device.
 
@@ -186,7 +186,7 @@ def _add_input(self, new_input: Union[KeyInput, PointerInput, WheelInput]) -> No
         """Add a new input device to the action builder.
 
         Parameters:
-        ----------
+        -----------
         new_input : Union[KeyInput, PointerInput, WheelInput]
             The new input device to add.
         """

py/selenium/webdriver/common/by.py

@@ -63,7 +63,7 @@ class By:
     >>> element = driver.find_element(By.TAG_NAME, 'div')
 
     CLASS_NAME:
-    ----------
+    -----------
     Select the element by its class name.
 
     >>> element = driver.find_element(By.CLASS_NAME, 'myElement')