Merge branch 'trunk' into add-default-cookie-type

Author: navin772

dotnet/src/webdriver/Chromium/ChromiumDriverService.cs

@@ -95,6 +95,11 @@ protected ChromiumDriverService(string? executablePath, string? executableFileNa
     /// </summary>
     public string? AllowedIPAddresses { get; set; }
 
+    /// <summary>
+    /// Adds readable timestamps to log
+    /// </summary>
+    public bool ReadableTimestamp { get; set; }
+
     /// <summary>
     /// Gets the command-line arguments for the driver service.
     /// </summary>
@@ -128,6 +133,11 @@ protected override string CommandLineArguments
                 argsBuilder.Append(" --append-log");
             }
 
+            if (this.ReadableTimestamp)
+            {
+                argsBuilder.Append(" --readable-timestamp");
+            }
+
             if (!string.IsNullOrEmpty(this.LogPath))
             {
                 argsBuilder.AppendFormat(CultureInfo.InvariantCulture, " --log-path=\"{0}\"", this.LogPath);

dotnet/src/webdriver/Firefox/FirefoxDriverService.cs

@@ -103,6 +103,16 @@ protected override DriverOptions GetDefaultDriverOptions()
     /// </remarks>
     public string? LogPath { get; set; }
 
+    /// <summary>
+    /// Disable truncation of long log lines in GeckoDriver.
+    /// </summary>
+    public bool LogNoTruncate { get; set; }
+
+    /// <summary>
+    /// Directory in which GeckoDriver creates profiles.
+    /// </summary>
+    public string? ProfileRoot { get; set; }
+
     /// <summary>
     /// Gets or sets the level at which log output is displayed.
     /// </summary>
@@ -189,6 +199,21 @@ protected override string CommandLineArguments
                 argsBuilder.Append(" --jsdebugger");
             }
 
+            if (this.LogNoTruncate)
+            {
+                argsBuilder.Append(" --log-no-truncate");
+            }
+
+            if (!string.IsNullOrEmpty(this.ProfileRoot))
+            {
+                if (!Directory.Exists(this.ProfileRoot))
+                {
+                    throw new ArgumentException($"Profile root directory does not exist: {this.ProfileRoot}", nameof(ProfileRoot));
+                }
+
+                argsBuilder.AppendFormat(CultureInfo.InvariantCulture, " --profile-root \"{0}\"", this.ProfileRoot);
+            }
+
             return argsBuilder.ToString().Trim();
         }
     }

py/docs/source/index.rst

@@ -47,24 +47,32 @@ Several browsers are supported, as well as the Remote protocol:
 Installing
 ==========
 
-If you have `pip <https://pip.pypa.io/>`_ on your system, you can simply install or upgrade the Python bindings::
+Install or upgrade the Python bindings with `pip <https://pip.pypa.io/>`.
+
+Latest official release::
 
     pip install -U selenium
 
-You may want to consider using a `virtual environment <https://packaging.python.org/en/latest/guides/installing-using-pip-and-virtual-environments>`_
-to create isolated Python environments.
+Nightly development release::
+
+    pip install -U --index-url https://test.pypi.org/simple/ --extra-index-url https://pypi.org/simple/ selenium
+
+Note: you should consider using a
+`virtual environment <https://packaging.python.org/en/latest/guides/installing-using-pip-and-virtual-environments>`_
+to create an isolated Python environment for installation.
 
 Drivers
 =======
 
 Selenium requires a driver to interface with the chosen browser (chromedriver, edgedriver, geckodriver, etc).
 
-In older versions of Selenium, it was necessary to install and manage these drivers yourself. You had to make sure the driver
-executable was available on your system `PATH`, or specified explicitly in code. Modern versions of Selenium handle browser and
-driver installation for you with `Selenium Manager <https://www.selenium.dev/documentation/selenium_manager>`_. You generally
-don't have to worry about driver installation or configuration now that it's done for you when you instantiate a WebDriver.
-Selenium Manager works with most supported platforms and browsers. If it doesn't meet your needs, you can still install and
-specify browsers and drivers yourself.
+In older versions of Selenium, it was necessary to install and manage these drivers yourself. You had to make sure the
+driver executable was available on your system `PATH`, or specified explicitly in code. Modern versions of Selenium
+handle browser and driver installation for you with
+`Selenium Manager <https://www.selenium.dev/documentation/selenium_manager>`_. You generally don't have to worry about
+driver installation or configuration now that it's done for you when you instantiate a WebDriver. Selenium Manager works
+with most supported platforms and browsers. If it doesn't meet your needs, you can still install and specify browsers
+and drivers yourself.
 
 Links to some of the more popular browser drivers:
 
@@ -123,8 +131,8 @@ Example 1:
 Example 2:
 ==========
 
-Selenium WebDriver is often used as a basis for testing web applications. Here is a simple example using Python's standard
-`unittest <http://docs.python.org/3/library/unittest.html>`_ library:
+Selenium WebDriver is often used as a basis for testing web applications. Here is a simple example using Python's
+standard `unittest <http://docs.python.org/3/library/unittest.html>`_ library:
 
 .. code-block:: python
 
@@ -150,8 +158,8 @@ Selenium Grid (optional)
 
 For local Selenium scripts, the Java server is not needed.
 
-To use Selenium remotely, you need to also run the Selenium grid.
-For information on running Selenium Grid: https://www.selenium.dev/documentation/grid/getting_started/
+To use Selenium remotely, you need to also run a Selenium Grid. For information on running Selenium Grid:
+https://www.selenium.dev/documentation/grid/getting_started/
 
 To use Remote WebDriver see: https://www.selenium.dev/documentation/webdriver/drivers/remote_webdriver/?tab=python
 
@@ -167,15 +175,14 @@ View source code online:
 Contributing
 =============
 
- - Fork the selenium repo and clone it locally
+ - Fork the selenium repo
+ - Clone your fork locally
  - Create a branch for your work
-     - Run: `git checkout -b my-cool-branch-name`
+     - `git checkout -b my-cool-branch-name`
  - Create a virtual environment and install tox
-     - Run: `python -m venv venv && source venv/bin/activate && pip install tox`
+     - `python -m venv venv && source venv/bin/activate && pip install tox`
  - Make your changes
- - Run: `tox -e linting`
+ - Run the linter/formatter
+     - `tox -e linting`
  - If tox exits `0`, commit and push. Otherwise, fix the newly introduced style violations
-     - `flake8` requires manual fixes
-     - `black` will rewrite the violations automatically, however the files are unstaged and should be staged again
-     - `isort` will rewrite the violations automatically, however the files are unstaged and should be staged again
  - Submit a Pull Request