Skip to content

Commit 961db5e

Browse files
authored
[py] DeprecationWarning raised in default webdriver init (#14690)
Signed-off-by: Viet Nguyen Duc <[email protected]>
1 parent b9b384a commit 961db5e

File tree

5 files changed

+9
-10
lines changed

5 files changed

+9
-10
lines changed

py/selenium/webdriver/chromium/remote_connection.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,9 +30,8 @@ def __init__(
3030
ignore_proxy: Optional[bool] = False,
3131
client_config: Optional[ClientConfig] = None,
3232
) -> None:
33+
client_config = client_config or ClientConfig(remote_server_addr=remote_server_addr, keep_alive=keep_alive)
3334
super().__init__(
34-
remote_server_addr=remote_server_addr,
35-
keep_alive=keep_alive,
3635
ignore_proxy=ignore_proxy,
3736
client_config=client_config,
3837
)

py/selenium/webdriver/firefox/remote_connection.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,9 +32,8 @@ def __init__(
3232
ignore_proxy: Optional[bool] = False,
3333
client_config: Optional[ClientConfig] = None,
3434
) -> None:
35+
client_config = client_config or ClientConfig(remote_server_addr=remote_server_addr, keep_alive=keep_alive)
3536
super().__init__(
36-
remote_server_addr=remote_server_addr,
37-
keep_alive=keep_alive,
3837
ignore_proxy=ignore_proxy,
3938
client_config=client_config,
4039
)

py/selenium/webdriver/ie/webdriver.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616
# under the License.
1717

1818
from selenium.webdriver.common.driver_finder import DriverFinder
19+
from selenium.webdriver.remote.client_config import ClientConfig
1920
from selenium.webdriver.remote.remote_connection import RemoteConnection
2021
from selenium.webdriver.remote.webdriver import WebDriver as RemoteWebDriver
2122

@@ -49,10 +50,10 @@ def __init__(
4950
self.service.path = self.service.env_path() or DriverFinder(self.service, options).get_driver_path()
5051
self.service.start()
5152

53+
client_config = ClientConfig(remote_server_addr=self.service.service_url, keep_alive=keep_alive)
5254
executor = RemoteConnection(
53-
remote_server_addr=self.service.service_url,
54-
keep_alive=keep_alive,
5555
ignore_proxy=options._ignore_local_proxy,
56+
client_config=client_config,
5657
)
5758

5859
try:

py/selenium/webdriver/safari/remote_connection.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,9 +32,8 @@ def __init__(
3232
ignore_proxy: Optional[bool] = False,
3333
client_config: Optional[ClientConfig] = None,
3434
) -> None:
35+
client_config = client_config or ClientConfig(remote_server_addr=remote_server_addr, keep_alive=keep_alive)
3536
super().__init__(
36-
remote_server_addr=remote_server_addr,
37-
keep_alive=keep_alive,
3837
ignore_proxy=ignore_proxy,
3938
client_config=client_config,
4039
)

py/selenium/webdriver/safari/webdriver.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616
# under the License.
1717

1818
from selenium.common.exceptions import WebDriverException
19+
from selenium.webdriver.remote.client_config import ClientConfig
1920
from selenium.webdriver.remote.webdriver import WebDriver as RemoteWebDriver
2021

2122
from ..common.driver_finder import DriverFinder
@@ -50,10 +51,10 @@ def __init__(
5051
if not self.service.reuse_service:
5152
self.service.start()
5253

54+
client_config = ClientConfig(remote_server_addr=self.service.service_url, keep_alive=keep_alive)
5355
executor = SafariRemoteConnection(
54-
remote_server_addr=self.service.service_url,
55-
keep_alive=keep_alive,
5656
ignore_proxy=options._ignore_local_proxy,
57+
client_config=client_config,
5758
)
5859

5960
try:

0 commit comments

Comments
 (0)