Move the integration tests to unit tests

Author: aguspe

rb/spec/integration/selenium/webdriver/chrome/service_spec.rb

@@ -37,23 +37,6 @@ module Chrome
         it 'can be started outside driver' do
           expect(service_manager.uri).to be_a(URI)
         end
-
-        context 'with a path env variable' do
-          before { ENV['SE_CHROMEDRIVER'] = DriverFinder.new(Options.new, described_class.new).driver_path }
-
-          after { ENV.delete('SE_CHROMEDRIVER') }
-
-          it 'uses the path from the environment' do
-            expect(service.executable_path).to match(/chromedriver/)
-          end
-
-          it 'updates the path after setting the environment variable' do
-            ENV['SE_CHROMEDRIVER'] = '/foo/bar'
-            service.executable_path = DriverFinder.new(Options.new, described_class.new).driver_path
-
-            expect(service.executable_path).to match(/chromedriver/)
-          end
-        end
       end
     end # Chrome
   end # WebDriver

rb/spec/integration/selenium/webdriver/edge/service_spec.rb

@@ -37,23 +37,6 @@ module Edge
         it 'can be started outside driver' do
           expect(service_manager.uri).to be_a(URI)
         end
-
-        context 'with a path env variable' do
-          before { ENV['SE_EDGEDRIVER'] = DriverFinder.new(Options.new, described_class.new).driver_path }
-
-          after { ENV.delete('SE_EDGEDRIVER') }
-
-          it 'uses the path from the environment' do
-            expect(service.executable_path).to match(/edgedriver/)
-          end
-
-          it 'updates the path after setting the environment variable' do
-            ENV['SE_EDGEDRIVER'] = '/foo/bar'
-            service.executable_path = DriverFinder.new(Options.new, described_class.new).driver_path
-
-            expect(service.executable_path).to match(/edgedriver/)
-          end
-        end
       end
     end # Edge
   end # WebDriver

rb/spec/integration/selenium/webdriver/firefox/service_spec.rb

@@ -37,23 +37,6 @@ module Firefox
         it 'can be started outside driver' do
           expect(service_manager.uri).to be_a(URI)
         end
-
-        context 'with a path env variable' do
-          before { ENV['SE_GECKODRIVER'] = DriverFinder.new(Options.new, described_class.new).driver_path }
-
-          after { ENV.delete('SE_GECKODRIVER') }
-
-          it 'uses the path from the environment' do
-            expect(service.executable_path).to match(/geckodriver/)
-          end
-
-          it 'updates the path after setting the environment variable' do
-            ENV['SE_GECKODRIVER'] = '/foo/bar'
-            service.executable_path = DriverFinder.new(Options.new, described_class.new).driver_path
-
-            expect(service.executable_path).to match(/geckodriver/)
-          end
-        end
       end
     end # Firefox
   end # WebDriver

rb/spec/integration/selenium/webdriver/ie/service_spec.rb

@@ -37,23 +37,6 @@ module IE
         it 'can be started outside driver' do
           expect(service_manager.uri).to be_a(URI)
         end
-
-        context 'with a path env variable' do
-          before { ENV['SE_IEDRIVER'] = DriverFinder.new(Options.new, described_class.new).driver_path }
-
-          after { ENV.delete('SE_IEDRIVER') }
-
-          it 'uses the path from the environment' do
-            expect(service.executable_path).to match(/iedriver/)
-          end
-
-          it 'updates the path after setting the environment variable' do
-            ENV['SE_IEDRIVER'] = '/foo/bar'
-            service.executable_path = DriverFinder.new(Options.new, described_class.new).driver_path
-
-            expect(service.executable_path).to match(/iedriver/)
-          end
-        end
       end
     end # IE
   end # WebDriver

rb/spec/integration/selenium/webdriver/safari/service_spec.rb

@@ -37,23 +37,6 @@ module Safari
         it 'can be started outside driver' do
           expect(service_manager.uri).to be_a(URI)
         end
-
-        context 'with a path env variable' do
-          before { ENV['SE_SAFARIDRIVER'] = DriverFinder.new(Options.new, described_class.new).driver_path }
-
-          after { ENV.delete('SE_SAFARIDRIVER') }
-
-          it 'uses the path from the environment' do
-            expect(service.executable_path).to match(/safaridriver/)
-          end
-
-          it 'updates the path after setting the environment variable' do
-            ENV['SE_SAFARIDRIVER'] = '/foo/bar'
-            service.executable_path = DriverFinder.new(Options.new, described_class.new).driver_path
-
-            expect(service.executable_path).to match(/safaridriver/)
-          end
-        end
       end
     end # Safari
   end # WebDriver

rb/spec/unit/selenium/webdriver/chrome/service_spec.rb

@@ -119,6 +119,28 @@ module Chrome
             driver.new(service: service)
             expect(described_class).not_to have_received(:new)
           end
+
+          context 'with a path env variable' do
+            let(:service) { described_class.new }
+            let(:service_path) { "/path/to/#{Service::EXECUTABLE}" }
+
+            before do
+              ENV['SE_CHROMEDRIVER'] = service_path
+            end
+
+            after { ENV.delete('SE_CHROMEDRIVER') }
+
+            it 'uses the path from the environment' do
+              expect(service.executable_path).to match(/chromedriver/)
+            end
+
+            it 'updates the path after setting the environment variable' do
+              ENV['SE_CHROMEDRIVER'] = '/foo/bar'
+              service.executable_path = service_path
+
+              expect(service.executable_path).to match(/chromedriver/)
+            end
+          end
         end
       end
     end # Chrome

rb/spec/unit/selenium/webdriver/edge/service_spec.rb

@@ -129,6 +129,28 @@ module Edge
             expect(service.log).to be_nil
             expect(service.args).to eq ['--log-path=/path/to/log.txt']
           end
+
+          context 'with a path env variable' do
+            let(:service) { described_class.new }
+            let(:service_path) { "/path/to/#{Service::EXECUTABLE}" }
+
+            before do
+              ENV['SE_EDGEDRIVER'] = service_path
+            end
+
+            after { ENV.delete('SE_EDGEDRIVER') }
+
+            it 'uses the path from the environment' do
+              expect(service.executable_path).to match(/edgedriver/)
+            end
+
+            it 'updates the path after setting the environment variable' do
+              ENV['SE_EDGEDRIVER'] = '/foo/bar'
+              service.executable_path = service_path
+
+              expect(service.executable_path).to match(/edgedriver/)
+            end
+          end
         end
       end
     end # Edge

rb/spec/unit/selenium/webdriver/firefox/service_spec.rb

@@ -117,6 +117,28 @@ module Firefox
 
             expect(described_class).not_to have_received(:new)
           end
+
+          context 'with a path env variable' do
+            let(:service) { described_class.new }
+            let(:service_path) { "/path/to/#{Service::EXECUTABLE}" }
+
+            before do
+              ENV['SE_GECKODRIVER'] = service_path
+            end
+
+            after { ENV.delete('SE_GECKODRIVER') }
+
+            it 'uses the path from the environment' do
+              expect(service.executable_path).to match(/geckodriver/)
+            end
+
+            it 'updates the path after setting the environment variable' do
+              ENV['SE_GECKODRIVER'] = '/foo/bar'
+              service.executable_path = service_path
+
+              expect(service.executable_path).to match(/geckodriver/)
+            end
+          end
         end
       end
     end # Firefox

rb/spec/unit/selenium/webdriver/ie/service_spec.rb

@@ -119,6 +119,28 @@ module IE
 
             expect(described_class).not_to have_received(:new)
           end
+
+          context 'with a path env variable' do
+            let(:service) { described_class.new }
+            let(:service_path) { "/path/to/#{Service::EXECUTABLE}" }
+
+            before do
+              ENV['SE_IEDRIVER'] = service_path
+            end
+
+            after { ENV.delete('SE_IEDRIVER') }
+
+            it 'uses the path from the environment' do
+              expect(service.executable_path).to match(/IEDriver/)
+            end
+
+            it 'updates the path after setting the environment variable' do
+              ENV['SE_IEDRIVER'] = '/foo/bar'
+              service.executable_path = service_path
+
+              expect(service.executable_path).to match(/IEDriver/)
+            end
+          end
         end
       end
     end # IE

rb/spec/unit/selenium/webdriver/safari/service_spec.rb

@@ -114,6 +114,28 @@ module Safari
 
             expect(described_class).not_to have_received(:new)
           end
+
+          context 'with a path env variable' do
+            let(:service) { described_class.new }
+            let(:service_path) { "/path/to/#{Service::EXECUTABLE}" }
+
+            before do
+              ENV['SE_SAFARIDRIVER'] = service_path
+            end
+
+            after { ENV.delete('SE_SAFARIDRIVER') }
+
+            it 'uses the path from the environment' do
+              expect(service.executable_path).to match(/safaridriver/)
+            end
+
+            it 'updates the path after setting the environment variable' do
+              ENV['SE_SAFARIDRIVER'] = '/foo/bar'
+              service.executable_path = service_path
+
+              expect(service.executable_path).to match(/safaridriver/)
+            end
+          end
         end
       end
     end # Safari