[js] Restore withCapabilities() to ensure backward compatibility

Author: pujagani

javascript/node/selenium-webdriver/index.js

@@ -318,7 +318,7 @@ class Builder {
   }
 
   /**
-   * @deprecated Since Selenium 4.0 withCapabilities is deprecated, use set*Options instead where * is the browser(eg setChromeOptions)
+   * Recommended way is to use set*Options where * is the browser(eg setChromeOptions)
    *
    * Sets the desired capabilities when requesting a new session. This will
    * overwrite any previously set capabilities.

javascript/node/selenium-webdriver/test/builder_test.js

@@ -69,3 +69,30 @@ test.suite(function (env) {
     })
   }
 })
+
+describe('Builder', function () {
+  describe('catches incorrect use of browser options class', function () {
+    function test(key, options) {
+      it(key, async function () {
+        let builder = new Builder().withCapabilities(
+          new Capabilities()
+            .set('browserName', 'fake-browser-should-not-try-to-start')
+            .set(key, new options())
+        )
+        try {
+          let driver = await builder.build()
+          await driver.quit()
+          return Promise.reject(Error('should have failed'))
+        } catch (ex) {
+          if (!(ex instanceof error.InvalidArgumentError)) {
+            throw ex
+          }
+        }
+      })
+    }
+
+    test('chromeOptions', chrome.Options)
+    test('moz:firefoxOptions', firefox.Options)
+    test('safari.options', safari.Options)
+  })
+})