Merge branch 'trunk' into py_cdp_fix

Author: navin772

dotnet/src/webdriver/Chromium/ChromiumDriverService.cs

@@ -160,10 +160,7 @@ protected override string CommandLineArguments
 
             if (this.LogLevel != ChromiumDriverLogLevel.Default)
             {
-                if (Enum.IsDefined(typeof(ChromiumDriverLogLevel), this.LogLevel))
-                {
-                    argsBuilder.Append(string.Format(CultureInfo.InvariantCulture, " --log-level={0}", this.LogLevel.ToString().ToUpperInvariant()));
-                }
+                argsBuilder.Append(string.Format(CultureInfo.InvariantCulture, " --log-level={0}", this.LogLevel.ToString().ToUpperInvariant()));
             }
 
 

dotnet/src/webdriver/Firefox/FirefoxDriverService.cs

@@ -104,9 +104,13 @@ protected override DriverOptions GetDefaultDriverOptions()
     public string? LogPath { get; set; }
 
     /// <summary>
-    /// Disable truncation of long log lines in GeckoDriver.
+    /// Gets or sets a value indicating whether to disable truncation of long log lines in GeckoDriver.
     /// </summary>
-    public bool LogNoTruncate { get; set; }
+    /// <remarks>
+    /// A <see langword="null"/> value indicates no log truncation setting to specify.
+    /// Set to <see langword="true"/> to disable truncation, or <see langword="false"/> to enable truncation.
+    /// </remarks>
+    public bool? LogTruncate { get; set; }
 
     /// <summary>
     /// Directory in which GeckoDriver creates profiles.
@@ -199,7 +203,7 @@ protected override string CommandLineArguments
                 argsBuilder.Append(" --jsdebugger");
             }
 
-            if (this.LogNoTruncate)
+            if (this.LogTruncate is true)
             {
                 argsBuilder.Append(" --log-no-truncate");
             }

javascript/selenium-webdriver/test/bidi/network_test.js

@@ -69,6 +69,7 @@ suite(
         await driver.navigate().refresh()
 
         assert.equal(beforeRequestEvent.request.method, 'GET')
+        await driver.wait(() => beforeRequestEvent.request.cookies.length > 0, 2000)
         assert.equal(beforeRequestEvent.request.cookies[0].name, 'north')
         assert.equal(beforeRequestEvent.request.cookies[0].value.value, 'biryani')
         const url = beforeRequestEvent.request.url
@@ -80,6 +81,7 @@ suite(
         })
         await driver.navigate().refresh()
 
+        await driver.wait(() => beforeRequestEvent.request.cookies.length > 1, 2000)
         assert.equal(beforeRequestEvent.request.cookies[1].name, 'south')
         assert.equal(beforeRequestEvent.request.cookies[1].value.value, 'dosa')
       })