Addressed review comments: Added prefixed constants to PageSize and updated tests to validate predefined sizes.

Author: yvsvarma

java/src/org/openqa/selenium/print/PageSize.java

@@ -25,15 +25,14 @@ public class PageSize {
   private final double width;
 
     // Reference for predefined page size constants: https://www.agooddaytoprint.com/page/paper-size-chart-faq
-    public static final PageSize A4 = new PageSize(29.7, 21.0); // A4 size in cm
-    public static final PageSize LEGAL = new PageSize(35.56, 21.59); // Legal size in cm
-    public static final PageSize TABLOID = new PageSize(43.18, 27.94); // Tabloid size in cm
-    public static final PageSize LETTER = new PageSize(27.94, 21.59); // Letter size in cm
+    public static final PageSize ISO_A4 = new PageSize(29.7, 21.0); // ISO_A4 size in cm
+    public static final PageSize US_LEGAL = new PageSize(35.56, 21.59); // US_LEGAL size in cm
+    public static final PageSize ANSI_TABLOID = new PageSize(43.18, 27.94); // ANSI_TABLOID size in cm
+    public static final PageSize US_LETTER = new PageSize(27.94, 21.59); // US_LETTER size in cm
 
   public PageSize() {
-    // Initialize with defaults. A4 paper size defaults in cms.
-    this.height = 27.94;
-    this.width = 21.59;
+    // Initialize with defaults. ISO_A4 paper size defaults in cms.
+    this(ISO_A4.getHeight(), ISO_A4.getWidth());
  }
 
   public PageSize(double height, double width) {
@@ -49,6 +48,13 @@ public double getWidth() {
     return width;
   }
 
+  public static PageSize setPageSize(PageSize pageSize) {
+    if (pageSize == null) {
+      throw new IllegalArgumentException("Page size cannot be null");
+    }
+    return new PageSize(pageSize.getHeight(), pageSize.getWidth());
+  }
+
   public Map<String, Object> toMap() {
     final Map<String, Object> options = new HashMap<>(7);
     options.put("height", getHeight());
@@ -60,6 +66,6 @@ public Map<String, Object> toMap() {
     @Override
     public String toString() {
     return "PageSize[width=" + this.getWidth() + ", height=" + this.getHeight() + "]";
- }
+  }
 
 }

java/test/org/openqa/selenium/print/PageSizeTest.java

@@ -25,44 +25,38 @@
 @Tag("UnitTests")
 class PageSizeTest {
 
-  // Defaults assertion
-  private static final double HEIGHT = 27.94;
-  private static final double WIDTH = 21.59;
-
-  @Test
-  void setsDefaultHeightWidth() {
+    @Test
+    void setsDefaultHeightWidth() {
     PageSize pageSize = new PageSize();
-
-    assertThat(pageSize.getHeight()).isEqualTo(HEIGHT);
-    assertThat(pageSize.getWidth()).isEqualTo(WIDTH);
+    assertThat(pageSize.getHeight()).isEqualTo(29.7);
+    assertThat(pageSize.getWidth()).isEqualTo(21.0);
   }
 
-  @Test
+    @Test
     void verifiesPageSizeA4() {
-    PageSize pageSize = PageSize.A4;
-    assertThat(pageSize.getHeight()).isEqualTo(HEIGHT);
-    assertThat(pageSize.getWidth()).isEqualTo(WIDTH);
+    PageSize pageSize = PageSize.setPageSize(PageSize.ISO_A4);
+    assertThat(pageSize.getHeight()).isEqualTo(29.7);
+    assertThat(pageSize.getWidth()).isEqualTo(21.0);
   }
 
-  @Test
+    @Test
     void verifiesPageSizeLegal() {
-    PageSize pageSize = PageSize.LEGAL;
-    assertThat(pageSize.getHeight()).isEqualTo(HEIGHT);
-    assertThat(pageSize.getWidth()).isEqualTo(WIDTH);
+    PageSize pageSize = PageSize.setPageSize(PageSize.US_LEGAL);
+    assertThat(pageSize.getHeight()).isEqualTo(35.56);
+    assertThat(pageSize.getWidth()).isEqualTo(21.59);
   }
 
-  @Test
+    @Test
     void verifiesPageSizeLetter() {
-    PageSize pageSize = PageSize.LETTER;
-    assertThat(pageSize.getHeight()).isEqualTo(HEIGHT);
-    assertThat(pageSize.getWidth()).isEqualTo(WIDTH);
+    PageSize pageSize = PageSize.setPageSize(PageSize.US_LETTER);
+    assertThat(pageSize.getHeight()).isEqualTo(27.94);
+    assertThat(pageSize.getWidth()).isEqualTo(21.59);
   }
 
     @Test
     void verifiesPageSizeTabloid() {
-    PageSize pageSize = PageSize.TABLOID;
-    assertThat(pageSize.getHeight()).isEqualTo(HEIGHT);
-    assertThat(pageSize.getWidth()).isEqualTo(WIDTH);
+    PageSize pageSize = PageSize.setPageSize(PageSize.ANSI_TABLOID);
+    assertThat(pageSize.getHeight()).isEqualTo(43.18);
+    assertThat(pageSize.getWidth()).isEqualTo(27.94);
   }
-
 }