[bazel] Generate spotbugs tests for test code

Author: shs96c

java/defs.bzl

@@ -2,11 +2,10 @@ load(
     "@rules_java//java:defs.bzl",
     _java_binary = "java_binary",
     _java_import = "java_import",
-    _java_test = "java_test",
 )
 load("@rules_jvm_external//:defs.bzl", _artifact = "artifact", _javadoc = "javadoc")
 load("//java/private:dist_zip.bzl", _java_dist_zip = "java_dist_zip")
-load("//java/private:library.bzl", _java_export = "java_export", _java_library = "java_library")
+load("//java/private:library.bzl", _java_export = "java_export", _java_library = "java_library", _java_test = "java_test")
 load("//java/private:module.bzl", _java_module = "java_module")
 load("//java/private:selenium_test.bzl", _selenium_test = "selenium_test")
 load("//java/private:spotbugs_config.bzl", _spotbugs_config = "spotbugs_config")

java/private/library.bzl

@@ -8,7 +8,7 @@ load(
 load(":export.bzl", _java_export = "java_export")
 load(":spotbugs.bzl", "spotbugs_test")
 
-def _add_lint_tests(name, **kwargs):
+def add_lint_tests(name, **kwargs):
     srcs = kwargs.get("srcs", [])
 
     if len(srcs) == 0:
@@ -31,9 +31,13 @@ def _add_lint_tests(name, **kwargs):
         )
 
 def java_export(name, **kwargs):
-    _add_lint_tests(name, **kwargs)
+    add_lint_tests(name, **kwargs)
     _java_export(name = name, **kwargs)
 
 def java_library(name, **kwargs):
-    _add_lint_tests(name, **kwargs)
+    add_lint_tests(name, **kwargs)
     _java_library(name = name, **kwargs)
+
+def java_test(name, **kwargs):
+    add_lint_tests(name, **kwargs)
+    _java_test(name = name, **kwargs)

java/private/selenium_test.bzl

@@ -11,6 +11,7 @@ load(
     "edge_jvm_flags",
     "firefox_jvm_flags",
 )
+load("//java/private:library.bzl", "add_lint_tests")
 
 DEFAULT_BROWSER = "firefox"
 
@@ -106,3 +107,4 @@ def selenium_test(name, test_class, size = "medium", browsers = BROWSERS.keys()
 
     # Handy way to run everything
     native.test_suite(name = "%s-all-browsers" % name, tests = [":%s-%s" % (name, default_browser)], tags = tags + ["manual"])
+    add_lint_tests(name, **kwargs)

java/private/suite.bzl

@@ -1,4 +1,4 @@
-load(":library.bzl", "java_library")
+load(":library.bzl", "java_library", "java_test")
 load(":selenium_test.bzl", "BROWSERS", "DEFAULT_BROWSER", "selenium_test")
 load(":package.bzl", "package_name")
 
@@ -85,7 +85,7 @@ def _create_java_test_target(
         test_class,
         tags = [],
         **kwargs):
-    native.java_test(
+    java_test(
         name = name,
         tags = tags,
         test_class = test_class,