[rust] Replace WMIC commands (to be deprecated) by PowerShell in Windows

Author: bonigarcia

rust/src/config.rs

@@ -21,7 +21,7 @@ use crate::{
     default_cache_folder, format_one_arg, path_to_string, Command, REQUEST_TIMEOUT_SEC,
     UNAME_COMMAND,
 };
-use crate::{ARCH_AMD64, ARCH_ARM64, ARCH_X86, TTL_SEC, WMIC_COMMAND_OS};
+use crate::{ARCH_AMD64, ARCH_ARM64, ARCH_X86, PS_GET_OS_COMMAND, TTL_SEC};
 use anyhow::anyhow;
 use anyhow::Error;
 use std::cell::RefCell;
@@ -69,11 +69,11 @@ impl ManagerConfig {
 
         let self_os = OS;
         let self_arch = if WINDOWS.is(self_os) {
-            let wmic_command = Command::new_single(WMIC_COMMAND_OS.to_string());
-            let wmic_output = run_shell_command_by_os(self_os, wmic_command).unwrap_or_default();
-            if wmic_output.contains("32") {
+            let get_os_command = Command::new_single(PS_GET_OS_COMMAND.to_string());
+            let ps_output = run_shell_command_by_os(self_os, get_os_command).unwrap_or_default();
+            if ps_output.contains("32") {
                 ARCH_X86.to_string()
-            } else if wmic_output.contains("ARM") {
+            } else if ps_output.contains("ARM") {
                 ARCH_ARM64.to_string()
             } else {
                 ARCH_AMD64.to_string()

rust/src/files.rs

@@ -19,7 +19,7 @@ use crate::config::OS;
 use crate::config::OS::WINDOWS;
 use crate::{
     format_one_arg, format_three_args, run_shell_command_by_os, Command, Logger, CP_VOLUME_COMMAND,
-    HDIUTIL_ATTACH_COMMAND, HDIUTIL_DETACH_COMMAND, MACOS, MSIEXEC_INSTALL_COMMAND,
+    HDIUTIL_ATTACH_COMMAND, HDIUTIL_DETACH_COMMAND, MACOS, PS_MSIEXEC_INSTALL_COMMAND,
 };
 use anyhow::anyhow;
 use anyhow::Error;
@@ -309,7 +309,7 @@ pub fn install_msi(msi_file: &str, log: &Logger, os: &str) -> Result<(), Error>
         msi_file_name.to_str().unwrap_or_default()
     ));
 
-    let command = Command::new_single(format_one_arg(MSIEXEC_INSTALL_COMMAND, msi_file));
+    let command = Command::new_single(format_one_arg(PS_MSIEXEC_INSTALL_COMMAND, msi_file));
     log.trace(format!("Running command: {}", command.display()));
     run_shell_command_by_os(os, command)?;
 

rust/src/lib.rs

@@ -75,8 +75,10 @@ pub const DEV: &str = "dev";
 pub const CANARY: &str = "canary";
 pub const NIGHTLY: &str = "nightly";
 pub const ESR: &str = "esr";
-pub const WMIC_COMMAND: &str = "wmic datafile where name='{}' get Version /value";
-pub const WMIC_COMMAND_OS: &str = "wmic os get osarchitecture";
+pub const PS_GET_VERSION_COMMAND: &str = r#"(Get-Item "{}").VersionInfo.ProductVersion"#;
+pub const PS_GET_OS_COMMAND: &str = "(Get-WmiObject Win32_OperatingSystem).OSArchitecture";
+pub const PS_MSIEXEC_INSTALL_COMMAND: &str =
+    r#"Start-Process -FilePath msiexec -ArgumentList "/i {} /qn ALLOWDOWNGRADE=1" -Wait"#;
 pub const REG_VERSION_ARG: &str = "version";
 pub const REG_CURRENT_VERSION_ARG: &str = "CurrentVersion";
 pub const REG_PV_ARG: &str = "pv";
@@ -85,7 +87,6 @@ pub const PLIST_COMMAND: &str =
 pub const HDIUTIL_ATTACH_COMMAND: &str = "hdiutil attach {}";
 pub const HDIUTIL_DETACH_COMMAND: &str = "hdiutil detach /Volumes/{}";
 pub const CP_VOLUME_COMMAND: &str = "cp -R /Volumes/{}/{}.app {}";
-pub const MSIEXEC_INSTALL_COMMAND: &str = "start /wait msiexec /i {} /qn ALLOWDOWNGRADE=1";
 pub const WINDOWS_CHECK_ADMIN_COMMAND: &str = "net session";
 pub const DASH_VERSION: &str = "{}{}{} -v";
 pub const DASH_DASH_VERSION: &str = "{}{}{} --version";
@@ -1139,9 +1140,11 @@ pub trait SeleniumManager {
         let mut commands = Vec::new();
         if WINDOWS.is(self.get_os()) {
             if !escaped_browser_path.is_empty() {
-                let wmic_command =
-                    Command::new_single(format_one_arg(WMIC_COMMAND, &escaped_browser_path));
-                commands.push(wmic_command);
+                let get_version_command = Command::new_single(format_one_arg(
+                    PS_GET_VERSION_COMMAND,
+                    &escaped_browser_path,
+                ));
+                commands.push(get_version_command);
             }
             if !self.is_browser_version_unstable() {
                 let reg_command =

rust/src/shell.rs

@@ -77,7 +77,7 @@ pub fn run_shell_command_with_log(
 
 pub fn run_shell_command_by_os(os: &str, command: Command) -> Result<String, Error> {
     let (shell, flag) = if WINDOWS.is(os) {
-        ("cmd", "/c")
+        ("powershell", "-c")
     } else {
         ("sh", "-c")
     };