[java] Deprecating FirefoxBinary

It is not needed anymore, as users can
provide the browser binary path with
a `Path` or a `String`.

Author: diemol

java/src/org/openqa/selenium/firefox/FirefoxBinary.java

@@ -38,6 +38,12 @@
 import org.openqa.selenium.WebDriverException;
 import org.openqa.selenium.os.ExecutableFinder;
 
+/**
+ * A wrapper around Firefox's binary. This allows us to locate the binary in a portable way.
+ *
+ * @deprecated Use {@link FirefoxOptions#setBinary(Path)} or {@link
+ *     FirefoxOptions#setBinary(String)} instead.
+ */
 public class FirefoxBinary {
 
   /** Enumerates Firefox channels, according to https://wiki.mozilla.org/RapidRelease */
@@ -178,7 +184,7 @@ static Executable locateFirefoxBinaryFromSystemProperty() {
       if (!binaryName.endsWith(".app")) {
         binaryName += ".app";
       }
-      binaryName += "/Contents/MacOS/firefox-bin";
+      binaryName += "/Contents/MacOS/firefox";
     }
 
     binary = new File(binaryName);
@@ -210,7 +216,7 @@ private static Stream<Executable> locateFirefoxBinariesFromPlatform() {
 
     } else if (current.is(MAC)) {
       // system
-      File binary = new File("/Applications/Firefox.app/Contents/MacOS/firefox-bin");
+      File binary = new File("/Applications/Firefox.app/Contents/MacOS/firefox");
       if (binary.exists()) {
         executables.add(new Executable(binary));
       }
@@ -222,7 +228,7 @@ private static Stream<Executable> locateFirefoxBinariesFromPlatform() {
       }
 
     } else if (current.is(UNIX)) {
-      String systemFirefoxBin = new ExecutableFinder().find("firefox-bin");
+      String systemFirefoxBin = new ExecutableFinder().find("firefox");
       if (systemFirefoxBin != null) {
         executables.add(new Executable(new File(systemFirefoxBin)));
       }