Improve typing

Author: aguspe

rb/lib/selenium/webdriver/bidi/network/intercepted_request.rb

@@ -29,7 +29,6 @@ class InterceptedRequest < InterceptedItem
 
         def initialize(network, request)
           super
-          # We now rely on the modules above to initialize @headers and @cookies as Hashes
           @method = nil
           @url = nil
           @body = nil

rb/sig/lib/selenium/webdriver/bidi/network/cookies.rbs

@@ -2,9 +2,9 @@ module Selenium
   module WebDriver
     class BiDi
       class Cookies
-        def initialize: (untyped cookies) -> void
+        def initialize: (Hash[Symbol, String] cookies) -> void
 
-        def serialize: () -> untyped
+        def serialize: () -> Hash[Symbol, String]
       end
     end
   end

rb/sig/lib/selenium/webdriver/bidi/network/credentials.rbs

@@ -2,17 +2,17 @@ module Selenium
   module WebDriver
     class BiDi
       class Credentials
-        @username: untyped
+        @username: String
 
-        @password: untyped
+        @password: String
 
-        attr_accessor username: untyped
+        attr_accessor username: String
 
-        attr_accessor password: untyped
+        attr_accessor password: String
 
-        def initialize: (?username: untyped?, ?password: untyped?) -> void
+        def initialize: (?username: String?, ?password: String?) -> void
 
-        def serialize: () -> (nil | { type: "password", username: untyped, password: untyped })
+        def serialize: () -> Hash[Symbol, String]?
       end
     end
   end

rb/sig/lib/selenium/webdriver/bidi/network/headers.rbs

@@ -4,7 +4,7 @@ module Selenium
       class Headers
         def initialize: () -> void
 
-        def serialize: () -> untyped
+        def serialize: () -> Array[Hash[Symbol, String]]
       end
     end
   end

rb/sig/lib/selenium/webdriver/bidi/network/intercepted_auth.rbs

@@ -2,11 +2,11 @@ module Selenium
   module WebDriver
     class BiDi
       class InterceptedAuth < InterceptedItem
-        def authenticate: (untyped username, untyped password) -> untyped
+        def authenticate: (String username, String password) -> Hash[nil, nil]
 
-        def skip: () -> untyped
+        def skip: () -> Hash[nil, nil]
 
-        def cancel: () -> untyped
+        def cancel: () -> Hash[nil, nil]
       end
     end
   end

rb/sig/lib/selenium/webdriver/bidi/network/intercepted_item.rbs

@@ -2,19 +2,19 @@ module Selenium
   module WebDriver
     class BiDi
       class InterceptedItem
-        @network: untyped
+        @network: Network
 
         @request: untyped
 
-        @id: untyped
+        @id: Integer
 
-        attr_reader network: untyped
+        attr_reader network: Network
 
         attr_reader request: untyped
 
-        def initialize: (untyped network, untyped request) -> void
+        def initialize: (Network network, Hash[untyped, untyped] request) -> void
 
-        def id: () -> untyped
+        def id: () -> Integer
       end
     end
   end

rb/sig/lib/selenium/webdriver/bidi/network/intercepted_request.rbs

@@ -2,34 +2,33 @@ module Selenium
   module WebDriver
     class BiDi
       class InterceptedRequest < InterceptedItem
-        # We now rely on the modules above to initialize @headers and @cookies as Hashes
-        @method: untyped
+        @method: String
 
-        @url: untyped
+        @url: String
 
-        @body: untyped
+        @body: Hash[untyped, untyped]
 
-        @headers: untyped
+        @headers: Hash[untyped, untyped]
 
-        @cookies: untyped
+        @cookies: Hash[untyped, untyped]
 
-        attr_accessor method: untyped
+        attr_accessor method: String
 
-        attr_accessor url: untyped
+        attr_accessor url: String
 
-        attr_reader body: untyped
+        attr_reader body: Hash[untyped, untyped]
 
-        def initialize: (untyped network, untyped request) -> void
+        def initialize: (Network network, Hash[untyped, untyped] request) -> void
 
-        def continue: () -> untyped
+        def continue: () -> Hash[nil, nil]
 
-        def fail: () -> untyped
+        def fail: () -> Hash[nil, nil]
 
-        def body=: (untyped value) -> untyped
+        def body=: (Hash[untyped, untyped] value) -> Hash[untyped, untyped]
 
-        def headers: () -> untyped
+        def headers: () -> Hash[untyped, untyped]
 
-        def cookies: () -> untyped
+        def cookies: () -> Hash[untyped, untyped]
       end
     end
   end

rb/sig/lib/selenium/webdriver/bidi/network/set_cookie_headers.rbs

@@ -2,9 +2,9 @@ module Selenium
   module WebDriver
     class BiDi
       class SetCookieHeaders
-        def initialize: (untyped set_cookie_headers) -> void
+        def initialize: (Hash[Symbol, untyped] set_cookie_headers) -> void
 
-        def serialize: () -> (Array[untyped] | untyped)
+        def serialize: () -> Array[Hash[Symbol, untyped]]
       end
     end
   end

rb/sig/lib/selenium/webdriver/common/network.rbs

@@ -25,7 +25,7 @@ module Selenium
 
       private
 
-      def add_handler: (Symbol event_type, String phase, BiDi::InterceptedItem intercept_type, Array[String] filter, ?pattern_type: Symbol?) { (untyped) -> untyped } -> untyped
+      def add_handler: (Symbol event_type, String phase, BiDi::InterceptedRequest | BiDi::InterceptedAuth | BiDi::InterceptedResponse intercept_type, Array[String] filter, ?pattern_type: Symbol?) { (untyped) -> untyped } -> untyped
     end
   end
 end