Updating .NET bindings to better handle W3C error responses

Author: jimevans

dotnet/src/webdriver/Remote/RemoteWebDriver.cs

@@ -1385,6 +1385,7 @@ private static void UnpackAndThrowOnError(Response errorResponse)
 
                         case WebDriverResult.InvalidElementState:
                         case WebDriverResult.ElementNotSelectable:
+                        case WebDriverResult.ElementNotInteractable:
                             throw new InvalidElementStateException(errorMessage);
 
                         case WebDriverResult.UnhandledError:

dotnet/src/webdriver/Remote/WebDriverError.cs

@@ -205,7 +205,7 @@ private static void InitializeResultMap()
             resultMap = new Dictionary<string, WebDriverResult>();
             resultMap[ElementNotSelectable] = WebDriverResult.ElementNotSelectable;
             resultMap[ElementNotVisible] = WebDriverResult.ElementNotDisplayed;
-            resultMap[ElementNotInteractable] = WebDriverResult.ElementNotDisplayed;
+            resultMap[ElementNotInteractable] = WebDriverResult.ElementNotInteractable;
             resultMap[InsecureCertificate] = WebDriverResult.InsecureCertificate;
             resultMap[InvalidArgument] = WebDriverResult.InvalidArgument;
             resultMap[InvalidCookieDomain] = WebDriverResult.InvalidCookieDomain;
@@ -215,18 +215,18 @@ private static void InitializeResultMap()
             resultMap[InvalidSelector] = WebDriverResult.InvalidSelector;
             resultMap[InvalidSessionId] = WebDriverResult.NoSuchDriver;
             resultMap[JavaScriptError] = WebDriverResult.UnexpectedJavaScriptError;
-            resultMap[MoveTargetOutOfBounds] = WebDriverResult.InvalidElementCoordinates;
+            resultMap[MoveTargetOutOfBounds] = WebDriverResult.MoveTargetOutOfBounds;
             resultMap[NoSuchAlert] = WebDriverResult.NoAlertPresent;
             resultMap[NoSuchCookie] = WebDriverResult.NoSuchCookie;
             resultMap[NoSuchElement] = WebDriverResult.NoSuchElement;
             resultMap[NoSuchFrame] = WebDriverResult.NoSuchFrame;
             resultMap[NoSuchWindow] = WebDriverResult.NoSuchWindow;
             resultMap[ScriptTimeout] = WebDriverResult.AsyncScriptTimeout;
-            resultMap[SessionNotCreated] = WebDriverResult.NoSuchDriver;
+            resultMap[SessionNotCreated] = WebDriverResult.SessionNotCreated;
             resultMap[StaleElementReference] = WebDriverResult.ObsoleteElement;
             resultMap[Timeout] = WebDriverResult.Timeout;
             resultMap[UnableToSetCookie] = WebDriverResult.UnableToSetCookie;
-            resultMap[UnableToCaptureScreen] = WebDriverResult.UnhandledError;
+            resultMap[UnableToCaptureScreen] = WebDriverResult.UnableToCaptureScreen;
             resultMap[UnexpectedAlertOpen] = WebDriverResult.UnexpectedAlertOpen;
             resultMap[UnknownCommand] = WebDriverResult.UnknownCommand;
             resultMap[UnknownError] = WebDriverResult.UnhandledError;

dotnet/src/webdriver/WebDriverResult.cs

@@ -178,19 +178,49 @@ public enum WebDriverResult
         /// </summary>
         InvalidSelector = 32,
 
+        /// <summary>
+        /// A session was not created by the driver
+        /// </summary>
+        SessionNotCreated = 33,
+
+        /// <summary>
+        /// The requested move was outside the active view port
+        /// </summary>
+        MoveTargetOutOfBounds = 34,
+
+        /// <summary>
+        /// The XPath selector was invalid.
+        /// </summary>
+        InvalidXPathSelector = 51,
+
         /// <summary>
         /// An insecure SSl certificate was specified.
         /// </summary>
-        InsecureCertificate = 33,
+        InsecureCertificate = 59,
 
         /// <summary>
-        /// No cookie was found matching the name requested.
+        /// The element was not interactable
         /// </summary>
-        NoSuchCookie = 34,
+        ElementNotInteractable = 60,
 
         /// <summary>
         /// An invalid argument was passed to the command.
         /// </summary>
-        InvalidArgument = 1000
+        InvalidArgument = 61,
+
+        /// <summary>
+        /// No cookie was found matching the name requested.
+        /// </summary>
+        NoSuchCookie = 62,
+
+        /// <summary>
+        /// The driver was unable to capture the screen.
+        /// </summary>
+        UnableToCaptureScreen = 63,
+
+        /// <summary>
+        /// The click on the element was intercepted by a different element.
+        /// </summary>
+        ElementClickIntercepted = 64
     }
 }