Merge branch 'trunk' into case-insensitive-hrader-name

Author: diemol

.github/workflows/stage-release.yml

@@ -6,6 +6,7 @@ on:
 
 env:
   GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+  BRANCH_NAME: ${{ github.event.pull_request.head.ref }}
 
 jobs:
   github-release:
@@ -20,7 +21,6 @@ jobs:
       - name: Extract version from branch name
         id: extract_version
         run: |
-          BRANCH_NAME="${{ github.event.pull_request.head.ref }}"
           VERSION=$(echo $BRANCH_NAME | grep -oE '[0-9]+\.[0-9]+\.[0-9]+')
           echo "VERSION=$VERSION" >> $GITHUB_ENV
       - name: Prep git

.skipped-tests

@@ -19,6 +19,7 @@
 -//javascript/atoms:test-chrome
 -//javascript/atoms:test-edge
 -//javascript/atoms:test-firefox-beta
+-//javascript/chrome-driver/...
 -//javascript/node/selenium-webdriver:test-bidi-network-test.js-chrome
 -//javascript/node/selenium-webdriver:test-builder-test.js-chrome
 -//javascript/node/selenium-webdriver:test-builder-test.js-firefox
@@ -54,3 +55,4 @@
 -//rb/spec/integration/selenium/webdriver:element-chrome
 -//rb/spec/integration/selenium/webdriver:element-chrome-bidi
 -//rb/spec/integration/selenium/webdriver:element-chrome-remote
+-//rust/tests/...

MODULE.bazel

@@ -210,6 +210,7 @@ maven.install(
         "org.bouncycastle:bcpkix-jdk18on:1.78.1",
         "org.eclipse.mylyn.github:org.eclipse.egit.github.core:2.1.5",
         "org.hsqldb:hsqldb:2.7.3",
+        "org.jspecify:jspecify:1.0.0",
         "org.junit.jupiter:junit-jupiter-api:5.10.3",
         "org.junit.jupiter:junit-jupiter-engine:5.10.3",
         "org.junit.jupiter:junit-jupiter-params:5.10.3",

common/mirror/selenium

@@ -25,11 +25,20 @@
       {
         "browser_download_url": "https://github.com/SeleniumHQ/selenium/releases/download/selenium-4.23.0/selenium-java-4.23.0.zip"
       },
+      {
+        "browser_download_url": "https://github.com/SeleniumHQ/selenium/releases/download/selenium-4.23.0/selenium-java-4.23.1.zip"
+      },
       {
         "browser_download_url": "https://github.com/SeleniumHQ/selenium/releases/download/selenium-4.23.0/selenium-server-4.23.0.jar"
       },
       {
         "browser_download_url": "https://github.com/SeleniumHQ/selenium/releases/download/selenium-4.23.0/selenium-server-4.23.0.zip"
+      },
+      {
+        "browser_download_url": "https://github.com/SeleniumHQ/selenium/releases/download/selenium-4.23.0/selenium-server-4.23.1.jar"
+      },
+      {
+        "browser_download_url": "https://github.com/SeleniumHQ/selenium/releases/download/selenium-4.23.0/selenium-server-4.23.1.zip"
       }
     ]
   },

common/src/web/javascriptPage.html

@@ -279,6 +279,10 @@ <h1>Type Stuff</h1>
   </div>
 </div>
 
+<form id="aParentFormId">
+  <input type="text" name="tagName">
+</form>
+
 </body>
 </html>
 

java/maven_install.json

@@ -1,7 +1,7 @@
 {
   "__AUTOGENERATED_FILE_DO_NOT_MODIFY_THIS_FILE_MANUALLY": "THERE_IS_NO_DATA_ONLY_ZUUL",
-  "__INPUT_ARTIFACTS_HASH": 966816920,
-  "__RESOLVED_ARTIFACTS_HASH": -1502533934,
+  "__INPUT_ARTIFACTS_HASH": -1798640815,
+  "__RESOLVED_ARTIFACTS_HASH": 890286156,
   "conflict_resolution": {
     "com.google.code.gson:gson:2.8.9": "com.google.code.gson:gson:2.11.0",
     "com.google.errorprone:error_prone_annotations:2.3.2": "com.google.errorprone:error_prone_annotations:2.27.0",
@@ -654,6 +654,13 @@
       },
       "version": "6.2.2"
     },
+    "org.jspecify:jspecify": {
+      "shasums": {
+        "jar": "1fad6e6be7557781e4d33729d49ae1cdc8fdda6fe477bb0cc68ce351eafdfbab",
+        "sources": "adf0898191d55937fb3192ba971826f4f294292c4a960740f3c27310e7b70296"
+      },
+      "version": "1.0.0"
+    },
     "org.junit.jupiter:junit-jupiter-api": {
       "shasums": {
         "jar": "6efe6e01ca1ff79b7bf4c6f1eed0b29292e166c27eaf7b00ac981a14d4de61aa",
@@ -2620,6 +2627,9 @@
       "jodd.typeconverter.impl",
       "jodd.util"
     ],
+    "org.jspecify:jspecify": [
+      "org.jspecify.annotations"
+    ],
     "org.junit.jupiter:junit-jupiter-api": [
       "org.junit.jupiter.api",
       "org.junit.jupiter.api.condition",
@@ -3134,6 +3144,8 @@
       "org.htmlunit:htmlunit-core-js:jar:sources",
       "org.jodd:jodd-util",
       "org.jodd:jodd-util:jar:sources",
+      "org.jspecify:jspecify",
+      "org.jspecify:jspecify:jar:sources",
       "org.junit.jupiter:junit-jupiter-api",
       "org.junit.jupiter:junit-jupiter-api:jar:sources",
       "org.junit.jupiter:junit-jupiter-engine",

java/src/org/openqa/selenium/BUILD.bazel

@@ -1,4 +1,4 @@
-load("//java:defs.bzl", "java_dist_zip", "java_export", "java_import", "javadoc")
+load("//java:defs.bzl", "artifact", "java_dist_zip", "java_export", "java_import", "javadoc")
 load("//java:version.bzl", "SE_VERSION")
 load("//java/src/org/openqa/selenium/devtools:versions.bzl", "CDP_DEPS")
 
@@ -32,8 +32,8 @@ java_export(
     pom_template = ":template-pom",
     visibility = ["//visibility:public"],
     deps = [
-        # Nothing from third party
         ":manifest",
+        artifact("org.jspecify:jspecify"),
     ],
 )
 

java/src/org/openqa/selenium/JavascriptExecutor.java

@@ -20,6 +20,8 @@
 import java.util.Collections;
 import java.util.Set;
 import java.util.stream.Collectors;
+import org.jspecify.annotations.NullMarked;
+import org.jspecify.annotations.Nullable;
 import org.openqa.selenium.internal.Require;
 
 /**
@@ -30,6 +32,7 @@
  * request or when trying to access another frame. Most times when troubleshooting failure it's best
  * to view the browser's console after executing the WebDriver request.
  */
+@NullMarked
 public interface JavascriptExecutor {
   /**
    * Executes JavaScript in the context of the currently selected frame or window. The script
@@ -63,7 +66,7 @@ public interface JavascriptExecutor {
    * @param args The arguments to the script. May be empty
    * @return One of Boolean, Long, Double, String, List, Map or WebElement. Or null.
    */
-  Object executeScript(String script, Object... args);
+  @Nullable Object executeScript(String script, @Nullable Object... args);
 
   /**
    * Execute an asynchronous piece of JavaScript in the context of the currently selected frame or
@@ -139,7 +142,7 @@ public interface JavascriptExecutor {
    * @return One of Boolean, Long, String, List, Map, WebElement, or null.
    * @see WebDriver.Timeouts#scriptTimeout(java.time.Duration)
    */
-  Object executeAsyncScript(String script, Object... args);
+  @Nullable Object executeAsyncScript(String script, @Nullable Object... args);
 
   /**
    * Commonly used scripts may be "pinned" to the WebDriver session, allowing them to be called
@@ -186,7 +189,7 @@ default Set<ScriptKey> getPinnedScripts() {
    *
    * @see #executeScript(String, Object...)
    */
-  default Object executeScript(ScriptKey key, Object... args) {
+  default @Nullable Object executeScript(ScriptKey key, @Nullable Object... args) {
     Require.stateCondition(
         key instanceof UnpinnedScriptKey, "Script key should have been generated by this driver");
 

java/src/org/openqa/selenium/OutputType.java

@@ -22,13 +22,15 @@
 import java.nio.file.Files;
 import java.nio.file.Path;
 import java.util.Base64;
+import org.jspecify.annotations.NullMarked;
 
 /**
  * Defines the output type for a screenshot.
  *
  * @see TakesScreenshot
  * @param <T> Type for the screenshot output.
  */
+@NullMarked
 public interface OutputType<T> {
   /** Obtain the screenshot as base64 data. */
   OutputType<String> BASE64 =

java/src/org/openqa/selenium/SearchContext.java

@@ -18,7 +18,9 @@
 package org.openqa.selenium;
 
 import java.util.List;
+import org.jspecify.annotations.NullMarked;
 
+@NullMarked
 public interface SearchContext {
   /**
    * Find all elements within the current context using the given mechanism.