Remove dispose service param from chromium ctor

Author: nvborisenko

dotnet/src/webdriver/Chrome/ChromeDriver.cs

@@ -125,7 +125,7 @@ public ChromeDriver(string chromeDriverDirectory, ChromeOptions options)
         /// <param name="options">The <see cref="ChromeOptions"/> to be used with the Chrome driver.</param>
         /// <param name="commandTimeout">The maximum amount of time to wait for each command.</param>
         public ChromeDriver(string chromeDriverDirectory, ChromeOptions options, TimeSpan commandTimeout)
-            : this(ChromeDriverService.CreateDefaultService(chromeDriverDirectory), options, commandTimeout, disposeService: true)
+            : this(ChromeDriverService.CreateDefaultService(chromeDriverDirectory), options, commandTimeout)
         {
         }
 
@@ -136,12 +136,7 @@ public ChromeDriver(string chromeDriverDirectory, ChromeOptions options, TimeSpa
         /// <param name="service">The <see cref="ChromeDriverService"/> to use.</param>
         /// <param name="options">The <see cref="ChromeOptions"/> used to initialize the driver.</param>
         public ChromeDriver(ChromeDriverService service, ChromeOptions options)
-            : this(service, options, RemoteWebDriver.DefaultCommandTimeout, disposeService: true)
-        {
-        }
-
-        public ChromeDriver(ChromeDriverService service, ChromeOptions options, bool disposeService)
-            : this(service, options, RemoteWebDriver.DefaultCommandTimeout, disposeService)
+            : this(service, options, RemoteWebDriver.DefaultCommandTimeout)
         {
         }
 
@@ -152,13 +147,7 @@ public ChromeDriver(ChromeDriverService service, ChromeOptions options, bool dis
         /// <param name="options">The <see cref="ChromeOptions"/> to be used with the Chrome driver.</param>
         /// <param name="commandTimeout">The maximum amount of time to wait for each command.</param>
         public ChromeDriver(ChromeDriverService service, ChromeOptions options, TimeSpan commandTimeout)
-            : base(service, options, commandTimeout, disposeService: true)
-        {
-            this.AddCustomChromeCommands();
-        }
-
-        public ChromeDriver(ChromeDriverService service, ChromeOptions options, TimeSpan commandTimeout, bool disposeService)
-            : base(service, options, commandTimeout, disposeService)
+            : base(service, options, commandTimeout)
         {
             this.AddCustomChromeCommands();
         }

dotnet/src/webdriver/Chromium/ChromiumDriver.cs

@@ -107,7 +107,6 @@ public class ChromiumDriver : WebDriver, ISupportsLogs, IDevTools
         public static readonly string SetPermissionCommand = "setPermission";
 
         private readonly ChromiumDriverService driverService;
-        private readonly bool disposeDriverService;
         private readonly string optionsCapabilityName;
         private DevToolsSession devToolsSession;
 
@@ -128,11 +127,10 @@ public class ChromiumDriver : WebDriver, ISupportsLogs, IDevTools
         /// <param name="service">The <see cref="ChromiumDriverService"/> to use.</param>
         /// <param name="options">The <see cref="ChromiumOptions"/> to be used with the ChromiumDriver.</param>
         /// <param name="commandTimeout">The maximum amount of time to wait for each command.</param>
-        protected ChromiumDriver(ChromiumDriverService service, ChromiumOptions options, TimeSpan commandTimeout, bool disposeService)
+        protected ChromiumDriver(ChromiumDriverService service, ChromiumOptions options, TimeSpan commandTimeout)
             : base(StartDriverServiceCommandExecutor(service, options, commandTimeout), ConvertOptionsToCapabilities(options))
         {
             this.driverService = service;
-            this.disposeDriverService = disposeService;
             this.optionsCapabilityName = options.CapabilityName;
         }
 
@@ -471,11 +469,6 @@ protected override void Dispose(bool disposing)
             }
 
             base.Dispose(disposing);
-
-            if (this.disposeDriverService)
-            {
-                this.driverService?.Dispose();
-            }
         }
 
         private static ICapabilities ConvertOptionsToCapabilities(ChromiumOptions options)

dotnet/src/webdriver/Edge/EdgeDriver.cs

@@ -117,7 +117,7 @@ public EdgeDriver(EdgeDriverService service, EdgeOptions options)
         /// <param name="options">The <see cref="EdgeOptions"/> to be used with the Edge driver.</param>
         /// <param name="commandTimeout">The maximum amount of time to wait for each command.</param>
         public EdgeDriver(EdgeDriverService service, EdgeOptions options, TimeSpan commandTimeout)
-            : base(service, options, commandTimeout, disposeService: false)
+            : base(service, options, commandTimeout)
         {
             this.AddCustomEdgeCommands();
         }