[rust] Remove optional ffmpeg version in cli parameter

Author: bonigarcia

rust/src/ffmpeg.rs

@@ -91,13 +91,8 @@ pub fn download_ffmpeg(
     Ok(())
 }
 
-pub fn get_ffmpeg_version(ffmpeg_version: Option<String>) -> String {
-    let ffmpeg_version = ffmpeg_version.unwrap_or(FFMPEG_DEFAULT_VERSION.to_string());
-    if ffmpeg_version.is_empty() {
-        FFMPEG_DEFAULT_VERSION.to_string()
-    } else {
-        ffmpeg_version
-    }
+pub fn get_ffmpeg_version() -> String {
+    FFMPEG_DEFAULT_VERSION.to_string()
 }
 
 pub fn get_ffmpeg_path_in_cache(

rust/src/lib.rs

@@ -902,15 +902,15 @@ pub trait SeleniumManager {
         Ok(())
     }
 
-    fn record_desktop(&self, ffmpeg_version: Option<String>, record: bool) -> Result<(), Error> {
+    fn record_desktop(&self, ffmpeg: bool, record: bool) -> Result<(), Error> {
         let mut ffmpeg_path: Option<PathBuf> = None;
-        if ffmpeg_version.is_some() {
-            ffmpeg_path = Some(self.get_or_download_ffmpeg(ffmpeg_version.clone())?);
+        if ffmpeg {
+            ffmpeg_path = Some(self.get_or_download_ffmpeg()?);
         }
         if record {
             let cache_path = self.get_cache_path()?.unwrap_or_default();
             record_desktop_with_ffmpeg(
-                ffmpeg_path.unwrap_or(self.get_or_download_ffmpeg(ffmpeg_version.clone())?),
+                ffmpeg_path.unwrap_or(self.get_or_download_ffmpeg()?),
                 self.get_os(),
                 self.get_logger(),
                 cache_path,
@@ -1598,8 +1598,8 @@ pub trait SeleniumManager {
         self.get_config_mut().fallback_driver_from_cache = fallback_driver_from_cache;
     }
 
-    fn get_or_download_ffmpeg(&self, version: Option<String>) -> Result<PathBuf, Error> {
-        let ffmpeg_version = get_ffmpeg_version(version);
+    fn get_or_download_ffmpeg(&self) -> Result<PathBuf, Error> {
+        let ffmpeg_version = get_ffmpeg_version();
         let cache_path = self.get_cache_path()?.unwrap_or_default();
         let ffmpeg_path_in_cache =
             get_ffmpeg_path_in_cache(&ffmpeg_version, self.get_os(), cache_path.clone())?;

rust/src/main.rs

@@ -156,9 +156,9 @@ struct Cli {
     #[clap(long)]
     skip_browser_in_path: bool,
 
-    /// Manage FFMPEG static build. If version is not provided, release 7.1 is downloaded
-    #[clap(long, value_parser, num_args = 0..=1, default_missing_value = "", value_name = "FFMPEG_VERSION")]
-    ffmpeg: Option<String>,
+    /// Manage FFMPEG static build
+    #[clap(long)]
+    ffmpeg: bool,
 
     /// Record desktop (using FFMPEG)
     #[clap(long)]
@@ -172,11 +172,11 @@ fn main() {
 
     let debug = cli.debug || BooleanKey("debug", false).get_value();
     let trace = cli.trace || BooleanKey("trace", false).get_value();
+    let ffmpeg = cli.ffmpeg || BooleanKey("ffmpeg", false).get_value();
     let record = cli.record || BooleanKey("record", false).get_value();
     let log_level = StringKey(vec!["log-level"], &cli.log_level.unwrap_or_default()).get_value();
     let log = Logger::create(&cli.output, debug, trace, &log_level);
     let grid = cli.grid;
-    let ffmpeg = cli.ffmpeg;
     let mut browser_name: String = cli.browser.unwrap_or_default();
     let mut driver_name: String = cli.driver.unwrap_or_default();
     if browser_name.is_empty() {