Skip to content

Commit b88be09

Browse files
committed
[py] Fix chromedriver/msedgedriver service tests
1 parent 66d780b commit b88be09

File tree

2 files changed

+20
-8
lines changed

2 files changed

+20
-8
lines changed

py/test/selenium/webdriver/chrome/chrome_service_tests.py

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,9 @@ def test_log_output_as_filename(clean_driver, clean_options, driver_executable)
6969
assert "--log-path=chromedriver.log" in service.service_args
7070
driver = clean_driver(options=clean_options, service=service)
7171
with open(log_file) as fp:
72-
assert "Starting ChromeDriver" in fp.readline()
72+
out = fp.read()
73+
assert "Starting" in out
74+
assert "started successfully" in out
7375
finally:
7476
driver.quit()
7577
os.remove(log_file)
@@ -84,7 +86,9 @@ def test_log_output_as_file(clean_driver, clean_options, driver_executable) -> N
8486
driver = clean_driver(options=clean_options, service=service)
8587
time.sleep(1)
8688
with open(log_name) as fp:
87-
assert "Starting ChromeDriver" in fp.readline()
89+
out = fp.read()
90+
assert "Starting" in out
91+
assert "started successfully" in out
8892
finally:
8993
driver.quit()
9094
log_file.close()
@@ -97,14 +101,16 @@ def test_log_output_as_stdout(clean_driver, clean_options, capfd, driver_executa
97101
driver = clean_driver(options=clean_options, service=service)
98102

99103
out, err = capfd.readouterr()
100-
assert "Starting ChromeDriver" in out
104+
assert "Starting" in out
105+
assert "started successfully" in out
101106
driver.quit()
102107

103108

104109
@pytest.mark.no_driver_after_test
105110
def test_log_output_null_default(driver, capfd) -> None:
106111
out, err = capfd.readouterr()
107-
assert "Starting ChromeDriver" not in out
112+
assert "Starting" in out
113+
assert "started successfully" in out
108114
driver.quit()
109115

110116

py/test/selenium/webdriver/edge/edge_service_tests.py

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,9 @@ def test_log_output_as_filename(clean_driver, clean_options, driver_executable)
6969
assert "--log-path=msedgedriver.log" in service.service_args
7070
driver = clean_driver(options=clean_options, service=service)
7171
with open(log_file) as fp:
72-
assert "Starting Microsoft Edge WebDriver" in fp.readline()
72+
out = fp.read()
73+
assert "Starting" in out
74+
assert "started successfully" in out
7375
finally:
7476
driver.quit()
7577
os.remove(log_file)
@@ -84,7 +86,9 @@ def test_log_output_as_file(clean_driver, clean_options, driver_executable) -> N
8486
driver = clean_driver(options=clean_options, service=service)
8587
time.sleep(1)
8688
with open(log_name) as fp:
87-
assert "Starting msedgedriver" in fp.readline()
89+
out = fp.read()
90+
assert "Starting" in out
91+
assert "started successfully" in out
8892
finally:
8993
driver.quit()
9094
log_file.close()
@@ -97,14 +101,16 @@ def test_log_output_as_stdout(clean_driver, clean_options, capfd, driver_executa
97101
driver = clean_driver(options=clean_options, service=service)
98102

99103
out, err = capfd.readouterr()
100-
assert "Starting msedgedriver" in out
104+
assert "Starting" in out
105+
assert "started successfully" in out
101106
driver.quit()
102107

103108

104109
@pytest.mark.no_driver_after_test
105110
def test_log_output_null_default(driver, capfd) -> None:
106111
out, err = capfd.readouterr()
107-
assert "Starting Microsoft Edge WebDriver" not in out
112+
assert "Starting" in out
113+
assert "started successfully" in out
108114
driver.quit()
109115

110116

0 commit comments

Comments
 (0)