[build] verify release targets are correct during build

Author: titusfortner

Rakefile

@@ -92,8 +92,7 @@ task '//java/test/org/openqa/selenium/environment/webserver:webserver:uber' => [
   '//java/test/org/openqa/selenium/environment:webserver'
 ]
 
-# Java targets required for release. These should all be java_export targets.
-# Generated from: bazel query 'kind(maven_publish, set(//java/... //third_party/...))' | sort
+# use #java_release_targets to access this list
 JAVA_RELEASE_TARGETS = %w[
   //java/src/org/openqa/selenium/chrome:chrome.publish
   //java/src/org/openqa/selenium/chromium:chromium.publish
@@ -120,6 +119,34 @@ JAVA_RELEASE_TARGETS = %w[
   //java/src/org/openqa/selenium:core.publish
 ].freeze
 
+def java_release_targets
+  @targets_verified ||= verify_java_release_targets
+
+  JAVA_RELEASE_TARGETS
+end
+
+def verify_java_release_targets
+  query = 'kind(maven_publish, set(//java/... //third_party/...))'
+  current_targets = []
+
+  Bazel.execute('query', [], query) do |output|
+    current_targets = output.lines.map(&:strip).reject(&:empty?)
+  end
+
+  missing_targets = current_targets - JAVA_RELEASE_TARGETS
+  extra_targets = JAVA_RELEASE_TARGETS - current_targets
+
+  return if missing_targets.empty? && extra_targets.empty?
+
+  error_message = 'Java release targets are out of sync with Bazel query results.'
+
+  error_message += "\nMissing targets: #{missing_targets.join(', ')}" unless missing_targets.empty?
+
+  error_message += "\nObsolete targets: #{extra_targets.join(', ')}" unless extra_targets.empty?
+
+  raise error_message
+end
+
 # Notice that because we're using rake, anything you can do in a normal rake
 # build can also be done here. For example, here we set the default task
 task default: [:grid]
@@ -364,7 +391,7 @@ end
 
 desc 'Install jars to local m2 directory'
 task :'maven-install' do
-  JAVA_RELEASE_TARGETS.each do |p|
+  java_release_targets.each do |p|
     Bazel.execute('run',
                   ['--stamp',
                    '--define',
@@ -826,7 +853,7 @@ namespace :java do
   desc 'Build Java Client Jars'
   task :build do |_task, arguments|
     args = arguments.to_a.compact
-    JAVA_RELEASE_TARGETS.each { |target| Bazel.execute('build', args, target) }
+    java_release_targets.each { |target| Bazel.execute('build', args, target) }
   end
 
   desc 'Build Grid Server'
@@ -873,7 +900,7 @@ namespace :java do
     Rake::Task['java:package'].invoke('--config=release')
     Rake::Task['java:build'].invoke('--config=release')
     # Because we want to `run` things, we can't use the `release` config
-    JAVA_RELEASE_TARGETS.each { |target| Bazel.execute('run', ['--config=release'], target) }
+    java_release_targets.each { |target| Bazel.execute('run', ['--config=release'], target) }
   end
 
   desc 'Install jars to local m2 directory'
@@ -894,14 +921,14 @@ namespace :java do
 
     file_path = 'MODULE.bazel'
     content = File.read(file_path)
-      output = nil
-      Bazel.execute('run', [], '@maven//:outdated') do |out|
-        output = out
-      end
+    output = nil
+    Bazel.execute('run', [], '@maven//:outdated') do |out|
+      output = out
+    end
 
     versions = output.scan(/(\S+) \[\S+ -> (\S+)\]/).to_h
     versions.each do |artifact, version|
-      content.sub!(/#{Regexp.escape(artifact)}:([\d\.\-]+(?:[-.]?[A-Za-z0-9]+)*)/, "#{artifact}:#{version}")
+      content.sub!(/#{Regexp.escape(artifact)}:([\d.-]+(?:[-.]?[A-Za-z0-9]+)*)/, "#{artifact}:#{version}")
     end
     File.write(file_path, content)