Updated auth test - was trying to find page that onlt exists in rb bindings, removed change from websocket_connection.py

Author: shbenzer

py/selenium/webdriver/common/bidi/network.py

@@ -300,4 +300,4 @@ def continue_request(self, **kwargs):
         if self.url is not None:
             params["url"] = self.url
 
-        self.network.conn.execute(self.command_builder("network.continueWithRequest", params))
+        self.network.conn.execute(self.command_builder("network.continueWithRequest", params))

py/selenium/webdriver/remote/websocket_connection.py

@@ -70,7 +70,7 @@ def execute(self, command):
             return self._deserialize_result(result, command)
 
     def add_callback(self, event, callback):
-        event_name = event.event_class if hasattr(event, "event_class") else event
+        event_name = event.event_class
         if event_name not in self.callbacks:
             self.callbacks[event_name] = []
 

py/test/selenium/webdriver/common/bidi_network_tests.py

@@ -38,12 +38,13 @@ def test_remove_intercept(driver):
     driver.network.remove_intercept(result["intercept"])
     assert driver.network.intercepts == [], "Intercept not removed"
 
+
 @pytest.mark.xfail_safari
 def test_add_and_remove_request_handler(driver, pages):
 
     requests = []
 
-    def callback(request):
+    def callback(request: Request):
         requests.append(request)
 
     callback_id = driver.network.add_request_handler("before_request", callback)
@@ -53,6 +54,7 @@ def callback(request):
     assert not requests, "Requests intercepted"
     assert driver.find_element(By.NAME, "login").is_displayed(), "Request not continued"
 
+
 @pytest.mark.xfail_safari
 def test_continue_request(driver, pages):
 
@@ -66,9 +68,9 @@ def callback(request: Request):
 
 
 @pytest.mark.xfail_safari
-def test_continue_with_auth(driver, pages):
+def test_continue_with_auth(driver):
 
-    callback_id = driver.network.add_auth_handler("test", "test")
+    callback_id = driver.network.add_auth_handler("user", "passwd")
     assert callback_id is not None, "Request handler not added"
-    pages.load("basicAuth")
-    assert driver.find_element(By.TAG_NAME, "h1").text == "authorized", "Authorization failed"
+    driver.get("https://httpbin.org/basic-auth/user/passwd")
+    assert "authenticated" in driver.page_source, "Authorization failed"