[rb] use property instead of attribute to test values

Author: titusfortner

rb/spec/integration/selenium/webdriver/action_builder_spec.rb

@@ -44,8 +44,8 @@ module WebDriver
           input = driver.find_element(css: '#working')
 
           driver.action.send_keys(input, 'abcd').perform
-          wait.until { input.attribute(:value).length == 4 }
-          expect(input.attribute(:value)).to eq('abcd')
+          wait.until { input.property(:value).length == 4 }
+          expect(input.property(:value)).to eq('abcd')
         end
 
         it 'sends keys with multiple arguments' do
@@ -55,8 +55,8 @@ module WebDriver
           input.click
 
           driver.action.send_keys('abcd', 'dcba').perform
-          wait.until { input.attribute(:value).length == 8 }
-          expect(input.attribute(:value)).to eq('abcddcba')
+          wait.until { input.property(:value).length == 8 }
+          expect(input.property(:value)).to eq('abcddcba')
         end
 
         it 'sends non-ASCII keys' do
@@ -66,8 +66,8 @@ module WebDriver
           input.click
 
           driver.action.send_keys('abcd', :left, 'a').perform
-          wait.until { input.attribute(:value).length == 5 }
-          expect(input.attribute(:value)).to eq('abcad')
+          wait.until { input.property(:value).length == 5 }
+          expect(input.property(:value)).to eq('abcad')
         end
       end
 
@@ -81,9 +81,9 @@ module WebDriver
           event_input.click
 
           driver.action.key_down(:shift).send_keys('ab').key_up(:shift).perform
-          wait.until { event_input.attribute(:value).length == 2 }
+          wait.until { event_input.property(:value).length == 2 }
 
-          expect(event_input.attribute(:value)).to eq('AB')
+          expect(event_input.property(:value)).to eq('AB')
           expected = keylogger.text.strip
           expect(expected).to match(/^(focus )?keydown keydown keypress keyup keydown keypress keyup keyup$/)
         end
@@ -131,10 +131,10 @@ module WebDriver
           event_input = driver.find_element(id: 'clickField')
 
           driver.action.click_and_hold(event_input).perform
-          expect(event_input.attribute(:value)).to eq('Hello')
+          expect(event_input.property(:value)).to eq('Hello')
 
           driver.action.release_actions
-          expect(event_input.attribute(:value)).to eq('Clicked')
+          expect(event_input.property(:value)).to eq('Clicked')
         end
       end
 
@@ -143,24 +143,27 @@ module WebDriver
           driver.navigate.to url_for('javascriptPage.html')
           element = driver.find_element(id: 'clickField')
           driver.action.click(element).perform
-          expect(element.attribute(:value)).to eq('Clicked')
+          expect(element.property(:value)).to eq('Clicked')
         end
 
         it 'executes with equivalent pointer methods' do
           driver.navigate.to url_for('javascriptPage.html')
           element = driver.find_element(id: 'clickField')
           driver.action.move_to(element).pointer_down(:left).pointer_up(:left).perform
-          expect(element.attribute(:value)).to eq('Clicked')
+          expect(element.property(:value)).to eq('Clicked')
         end
       end
 
       describe '#double_click' do
+        # https://issues.chromium.org/issues/400087471
+        before { reset_driver! if GlobalTestEnv.rbe? && GlobalTestEnv.browser == :chrome }
+
         it 'presses pointer twice', except: {browser: %i[safari safari_preview]} do
           driver.navigate.to url_for('javascriptPage.html')
           element = driver.find_element(id: 'doubleClickField')
 
           driver.action.double_click(element).perform
-          expect(element.attribute(:value)).to eq('DoubleClicked')
+          expect(element.property(:value)).to eq('DoubleClicked')
         end
 
         it 'executes with equivalent pointer methods', except: {browser: %i[safari safari_preview]} do
@@ -171,7 +174,7 @@ module WebDriver
                 .pointer_down(:left).pointer_up(:left)
                 .pointer_down(:left).pointer_up(:left)
                 .perform
-          expect(element.attribute(:value)).to eq('DoubleClicked')
+          expect(element.property(:value)).to eq('DoubleClicked')
         end
       end
 
@@ -181,15 +184,15 @@ module WebDriver
           element = driver.find_element(id: 'doubleClickField')
 
           driver.action.context_click(element).perform
-          expect(element.attribute(:value)).to eq('ContextClicked')
+          expect(element.property(:value)).to eq('ContextClicked')
         end
 
         it 'executes with equivalent pointer methods' do
           driver.navigate.to url_for('javascriptPage.html')
           element = driver.find_element(id: 'doubleClickField')
 
           driver.action.move_to(element).pointer_down(:right).pointer_up(:right).perform
-          expect(element.attribute(:value)).to eq('ContextClicked')
+          expect(element.property(:value)).to eq('ContextClicked')
         end
       end
 
@@ -199,7 +202,7 @@ module WebDriver
           element = driver.find_element(id: 'clickField')
           driver.action.move_to(element).click.perform
 
-          expect(element.attribute(:value)).to eq('Clicked')
+          expect(element.property(:value)).to eq('Clicked')
         end
 
         it 'moves to element with offset' do
@@ -212,7 +215,7 @@ module WebDriver
           y_offset = (destination_rect.y - origin_rect.y).ceil
 
           driver.action.move_to(origin, x_offset, y_offset).click.perform
-          expect(destination.attribute(:value)).to eq('Clicked')
+          expect(destination.property(:value)).to eq('Clicked')
         end
       end
 
@@ -256,7 +259,7 @@ module WebDriver
           rect = element.rect
           driver.action.move_to_location(rect.x.ceil, rect.y.ceil).click.perform
 
-          expect(element.attribute(:value)).to eq('Clicked')
+          expect(element.property(:value)).to eq('Clicked')
         end
       end
 

rb/spec/integration/selenium/webdriver/driver_spec.rb

@@ -60,8 +60,7 @@ module WebDriver
 
       it 'refreshes the page' do
         driver.navigate.to url_for('javascriptPage.html')
-        sleep 1 # javascript takes too long to load
-        driver.find_element(id: 'updatediv').click
+        short_wait { driver.find_element(id: 'updatediv') }.click
         expect(driver.find_element(id: 'dynamo').text).to eq('Fish and chips!')
         driver.navigate.refresh
         wait_for_element(id: 'dynamo')