Merge branch 'trunk' into replace-string-equals

Author: VietND96

MODULE.bazel

@@ -200,7 +200,6 @@ maven.install(
         "io.opentelemetry:opentelemetry-sdk-extension-autoconfigure-spi",
         "io.opentelemetry:opentelemetry-sdk-testing",
         "io.opentelemetry:opentelemetry-sdk-trace",
-        "io.opentelemetry.semconv:opentelemetry-semconv:1.28.0-alpha",
         "it.ozimov:embedded-redis:0.7.3",
         "net.bytebuddy:byte-buddy:1.15.11",
         "org.htmlunit:htmlunit-core-js:4.7.0",

WORKSPACE

@@ -6,6 +6,7 @@ load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")
 
 http_archive(
     name = "io_bazel_rules_closure",
+    integrity = "sha256-lJjlc2jvuCuYXbHtQmp2fL8boDmP167WMvw5CGVOGx4=",
     strip_prefix = "rules_closure-0.12.0",
     url = "https://github.com/bazelbuild/rules_closure/archive/refs/tags/0.12.0.tar.gz",
 )

common/repositories.bzl

@@ -50,8 +50,8 @@ js_library(
 
     http_archive(
         name = "linux_beta_firefox",
-        url = "https://ftp.mozilla.org/pub/firefox/releases/137.0b1/linux-x86_64/en-US/firefox-137.0b1.tar.xz",
-        sha256 = "98848e14e857a3562c4a2cf6fbbf7966e4f256cf6e127df0b367ac23c6638676",
+        url = "https://ftp.mozilla.org/pub/firefox/releases/137.0b2/linux-x86_64/en-US/firefox-137.0b2.tar.xz",
+        sha256 = "cfacafd480c40e6e9756cd4e5128e82c690bc53aca9d9dbf7bcfc6f2cf437fd6",
         build_file_content = """
 load("@aspect_rules_js//js:defs.bzl", "js_library")
 package(default_visibility = ["//visibility:public"])
@@ -72,8 +72,8 @@ js_library(
 
     dmg_archive(
         name = "mac_beta_firefox",
-        url = "https://ftp.mozilla.org/pub/firefox/releases/137.0b1/mac/en-US/Firefox%20137.0b1.dmg",
-        sha256 = "b6ff3f376bc25e8890ed34278fe5c0719349839a45c5ac340118ff983f3741a5",
+        url = "https://ftp.mozilla.org/pub/firefox/releases/137.0b2/mac/en-US/Firefox%20137.0b2.dmg",
+        sha256 = "2038c5a761974ee521943986f82fee551de32d2e8839c1102c4bca70c5953bbb",
         build_file_content = """
 load("@aspect_rules_js//js:defs.bzl", "js_library")
 package(default_visibility = ["//visibility:public"])
@@ -123,10 +123,10 @@ js_library(
 
     pkg_archive(
         name = "mac_edge",
-        url = "https://msedge.sf.dl.delivery.mp.microsoft.com/filestreamingservice/files/b52c4eaa-a0a4-4e86-9643-ef8f23ab8ec9/MicrosoftEdge-133.0.3065.92.pkg",
-        sha256 = "bfa719621205421945eca8891c7ef1901af753994f4522c3eb9354d6c18c23ed",
+        url = "https://msedge.sf.dl.delivery.mp.microsoft.com/filestreamingservice/files/bd7a7bb2-a585-4892-8cb1-74c91c53c943/MicrosoftEdge-134.0.3124.51.pkg",
+        sha256 = "5aa1d2fd4e35a177e98cddaee8b3edeedf6e765aef5a09d3872de96d5760778c",
         move = {
-            "MicrosoftEdge-133.0.3065.92.pkg/Payload/Microsoft Edge.app": "Edge.app",
+            "MicrosoftEdge-134.0.3124.51.pkg/Payload/Microsoft Edge.app": "Edge.app",
         },
         build_file_content = """
 load("@aspect_rules_js//js:defs.bzl", "js_library")
@@ -143,8 +143,8 @@ js_library(
 
     deb_archive(
         name = "linux_edge",
-        url = "https://packages.microsoft.com/repos/edge/pool/main/m/microsoft-edge-stable/microsoft-edge-stable_133.0.3065.92-1_amd64.deb",
-        sha256 = "3d8fd372bae2aa8b99791790a778700d81e33fbffe93e5bc40e18c08befdf62f",
+        url = "https://packages.microsoft.com/repos/edge/pool/main/m/microsoft-edge-stable/microsoft-edge-stable_134.0.3124.51-1_amd64.deb",
+        sha256 = "8bb0ba438b820599c8c9dd8b03e2b0b39fd6c4765aa33fd4c6037d02d642b6ea",
         build_file_content = """
 load("@aspect_rules_js//js:defs.bzl", "js_library")
 package(default_visibility = ["//visibility:public"])

dotnet/private/executable_assembly.bzl

@@ -75,6 +75,7 @@ def create_executable_assembly(ctx, extra_srcs, extra_deps):
             internals_visible_to = None,
             internals_visible_to_cs = None,
             langversion = ctx.attr.langversion,
+            nullable = ctx.attr.nullable,
             resources = ctx.files.resources,
             srcs = ctx.files.srcs + extra_srcs,
             out = ctx.attr.out,
@@ -143,6 +144,9 @@ csharp_executable = rule(
         "langversion": attr.string(
             doc = "The version string for the C# language.",
         ),
+        "nullable": attr.string(
+            doc = "Enable nullable context, or nullable warnings.",
+        ),
         "resources": attr.label_list(
             doc = "A list of files to embed in the DLL as resources.",
             allow_files = True,

dotnet/src/webdriver/Alert.cs

@@ -20,8 +20,6 @@
 using System;
 using System.Collections.Generic;
 
-#nullable enable
-
 namespace OpenQA.Selenium
 {
     /// <summary>

dotnet/src/webdriver/BUILD.bazel

@@ -37,6 +37,7 @@ csharp_library(
         "WebDriver.Common.Tests",
     ],
     langversion = "12.0",
+    nullable = "enable",
     resources = [
         "//javascript/atoms/fragments:find-elements.js",
         "//javascript/atoms/fragments:is-displayed.js",
@@ -76,6 +77,7 @@ csharp_library(
         "WebDriver.Common.Tests",
     ],
     langversion = "12.0",
+    nullable = "enable",
     resources = [
         "//javascript/atoms/fragments:find-elements.js",
         "//javascript/atoms/fragments:is-displayed.js",
@@ -103,6 +105,7 @@ csharp_library(
     out = "WebDriver.StrongNamed",
     keyfile = "//dotnet:WebDriver.snk",
     langversion = "12.0",
+    nullable = "enable",
     resources = [
         "//javascript/atoms/fragments:find-elements.js",
         "//javascript/atoms/fragments:is-displayed.js",
@@ -140,6 +143,7 @@ csharp_library(
     ],
     keyfile = "//dotnet:WebDriver.snk",
     langversion = "12.0",
+    nullable = "enable",
     resources = [
         "//javascript/atoms/fragments:find-elements.js",
         "//javascript/atoms/fragments:is-displayed.js",

dotnet/src/webdriver/BiDi/BiDi.cs

@@ -22,8 +22,6 @@
 using OpenQA.Selenium.BiDi.Communication;
 using OpenQA.Selenium.BiDi.Communication.Transport;
 
-#nullable enable
-
 namespace OpenQA.Selenium.BiDi;
 
 public class BiDi : IAsyncDisposable

dotnet/src/webdriver/BiDi/BiDiException.cs

@@ -19,8 +19,6 @@
 
 using System;
 
-#nullable enable
-
 namespace OpenQA.Selenium.BiDi;
 
 public class BiDiException : Exception

dotnet/src/webdriver/BiDi/Communication/Broker.cs

@@ -30,8 +30,6 @@
 using System.Threading;
 using System.Threading.Tasks;
 
-#nullable enable
-
 namespace OpenQA.Selenium.BiDi.Communication;
 
 public class Broker : IAsyncDisposable

dotnet/src/webdriver/BiDi/Communication/Command.cs

@@ -17,7 +17,7 @@
 // under the License.
 // </copyright>
 
-#nullable enable
+using System.Text.Json.Serialization;
 
 namespace OpenQA.Selenium.BiDi.Communication;
 
@@ -28,14 +28,17 @@ protected Command(string method)
         Method = method;
     }
 
+    [JsonPropertyOrder(1)]
     public string Method { get; }
 
+    [JsonPropertyOrder(0)]
     public int Id { get; internal set; }
 }
 
 internal abstract class Command<TCommandParameters>(TCommandParameters @params, string method) : Command(method)
     where TCommandParameters : CommandParameters
 {
+    [JsonPropertyOrder(2)]
     public TCommandParameters Params { get; } = @params;
 }