Skip to content

Commit c166199

Browse files
committed
[java] use --enable-chrome-logs to redirect browser I/O streams
1 parent ca3b7cf commit c166199

File tree

2 files changed

+10
-6
lines changed

2 files changed

+10
-6
lines changed

java/src/org/openqa/selenium/chrome/ChromeDriverService.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -292,7 +292,6 @@ protected void loadSystemProperties() {
292292
protected List<String> createArgs() {
293293
List<String> args = new ArrayList<>();
294294
args.add(String.format(Locale.ROOT, "--port=%d", getPort()));
295-
296295
// Readable timestamp and append logs only work if log path is specified in args
297296
// Cannot use logOutput because goog:loggingPrefs requires --log-path get sent
298297
if (getLogFile() != null) {
@@ -316,6 +315,8 @@ protected List<String> createArgs() {
316315
if (Boolean.TRUE.equals(disableBuildCheck)) {
317316
args.add("--disable-build-check");
318317
}
318+
// Suppress or redirect browser I/O Streams
319+
args.add("--enable-chrome-logs");
319320

320321
return unmodifiableList(args);
321322
}

java/test/org/openqa/selenium/chrome/ChromeDriverServiceTest.java

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -61,19 +61,21 @@ void testScoring() {
6161
void logLevelLastWins() {
6262
ChromeDriverService.Builder builderMock = spy(ChromeDriverService.Builder.class);
6363

64-
List<String> silentLast = Arrays.asList("--port=1", "--log-level=OFF");
64+
List<String> silentLast = Arrays.asList("--port=1", "--log-level=OFF", "--enable-chrome-logs");
6565
builderMock.withLogLevel(ChromiumDriverLogLevel.ALL).usingPort(1).withSilent(true).build();
6666
verify(builderMock).createDriverService(any(), anyInt(), any(), eq(silentLast), any());
6767

68-
List<String> silentFirst = Arrays.asList("--port=1", "--log-level=DEBUG");
68+
List<String> silentFirst =
69+
Arrays.asList("--port=1", "--log-level=DEBUG", "--enable-chrome-logs");
6970
builderMock.withSilent(true).withLogLevel(ChromiumDriverLogLevel.DEBUG).usingPort(1).build();
7071
verify(builderMock).createDriverService(any(), anyInt(), any(), eq(silentFirst), any());
7172

72-
List<String> verboseLast = Arrays.asList("--port=1", "--log-level=ALL");
73+
List<String> verboseLast = Arrays.asList("--port=1", "--log-level=ALL", "--enable-chrome-logs");
7374
builderMock.withLogLevel(ChromiumDriverLogLevel.OFF).usingPort(1).withVerbose(true).build();
7475
verify(builderMock).createDriverService(any(), anyInt(), any(), eq(verboseLast), any());
7576

76-
List<String> verboseFirst = Arrays.asList("--port=1", "--log-level=INFO");
77+
List<String> verboseFirst =
78+
Arrays.asList("--port=1", "--log-level=INFO", "--enable-chrome-logs");
7779
builderMock.withVerbose(true).withLogLevel(ChromiumDriverLogLevel.INFO).usingPort(1).build();
7880
verify(builderMock).createDriverService(any(), anyInt(), any(), eq(verboseFirst), any());
7981
}
@@ -83,7 +85,8 @@ void logLevelLastWins() {
8385
void ignoreFalseLogging() {
8486
ChromeDriverService.Builder builderMock = spy(ChromeDriverService.Builder.class);
8587

86-
List<String> falseSilent = Arrays.asList("--port=1", "--log-level=DEBUG");
88+
List<String> falseSilent =
89+
Arrays.asList("--port=1", "--log-level=DEBUG", "--enable-chrome-logs");
8790
builderMock.withLogLevel(ChromiumDriverLogLevel.DEBUG).usingPort(1).withSilent(false).build();
8891
verify(builderMock).createDriverService(any(), anyInt(), any(), eq(falseSilent), any());
8992
}

0 commit comments

Comments
 (0)