support safari

Author: titusfortner

.github/workflows/ci-dotnet.yml

@@ -56,11 +56,15 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        browser: [chrome, firefox, edge]
-        os: [windows]
+        browser: [chrome, firefox]
         protocol: [classic, bidi]
+        os: [windows]
+        include:
+          - browser: safari
+            os: macos
+            protocol: classic
     with:
-      name: Browser Tests - ${{ matrix.browser }} (${{ matrix.protocol }}), ${{ matrix.os }}
+      name: Browser Tests - ${{ matrix.browser }} ${{ matrix.protocol }}, ${{ matrix.os }}
       os: ${{ matrix.os }}
       browser: ${{ matrix.browser }}
       rerun-with-debug: true
@@ -70,7 +74,7 @@ jobs:
         --build_tests_only
         --flaky_test_attempts 3
         --local_test_jobs 1
-        "--test_tag_filters=${{ matrix.browser }},${{ matrix.protocol == 'bidi' && 'bidi' || '-bidi' }}"
+        --test_tag_filters="${{ matrix.browser }},${{ matrix.protocol == 'bidi' && 'bidi' || '-bidi' }}"
         --test_size_filters=large
         --pin_browsers=false
         --test_env=SE_FORCE_BROWSER_DOWNLOAD=true

dotnet/test/common/BUILD.bazel

@@ -77,7 +77,7 @@ dotnet_nunit_test_suite(
         # The first browser in this list is assumed to be the one that should
         # be used by default.
         "firefox",
-        # "safari",  # Skipping safari for now
+        "safari",
         "ie",
         "edge",
         "chrome",