Skip to content

Commit c3fd4e2

Browse files
committed
Removing guards and switching to macOS
[skip ci]
1 parent cd5586c commit c3fd4e2

File tree

4 files changed

+4
-8
lines changed

4 files changed

+4
-8
lines changed

.github/workflows/ci-ruby.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ jobs:
9696
matrix:
9797
include:
9898
- browser: edge
99-
os: windows
99+
os: macos
100100
with:
101101
name: Remote Tests (${{ matrix.browser }}, ${{ matrix.os }})
102102
browser: ${{ matrix.browser }}

rb/spec/integration/selenium/webdriver/firefox/driver_spec.rb

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -44,9 +44,7 @@ module Firefox
4444
page: {width: 30})).to include(magic_number)
4545
end
4646

47-
it 'prints full page', except: [{platform: :windows,
48-
reason: 'Some issues with resolution?'},
49-
{platform: :macosx,
47+
it 'prints full page', except: [{platform: :macosx,
5048
reason: 'showing half resolution of what expected'}] do
5149
viewport_width = driver.execute_script('return window.innerWidth;')
5250
viewport_height = driver.execute_script('return window.innerHeight;')

rb/spec/integration/selenium/webdriver/takes_screenshot_spec.rb

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -93,9 +93,7 @@ def save_screenshot_and_assert(source, path)
9393
expect(height).to be <= viewport_height
9494
end
9595

96-
it 'takes full page screenshot', except: [{platform: :windows,
97-
reason: 'Some issues with resolution?'},
98-
{platform: :macosx,
96+
it 'takes full page screenshot', except: [{platform: :macosx,
9997
reason: 'showing half resolution of what expected'}],
10098
exclusive: {browser: :firefox} do
10199
viewport_width = driver.execute_script('return window.innerWidth;')

rb/spec/integration/selenium/webdriver/window_spec.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ module WebDriver
103103
end
104104

105105
it 'can maximize the current window', except: {browser: :firefox, platform: :macosx} do
106-
window.size = old_size = Dimension.new(700, 700)
106+
window.size = old_size = Dimension.new(650, 650)
107107

108108
window.maximize
109109
wait.until { window.size != old_size }

0 commit comments

Comments
 (0)