Skip to content

Commit c433f10

Browse files
committed
[build] update nightly versions by default when doing a nightly release
1 parent 93f95ff commit c433f10

File tree

2 files changed

+25
-19
lines changed

2 files changed

+25
-19
lines changed

.github/workflows/nightly.yml

Lines changed: 7 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -35,10 +35,9 @@ jobs:
3535
with:
3636
name: Nightly Ruby Release
3737
cache-key: rb-nightly-${{ matrix.gem }}
38-
run: |
39-
export GEM_HOST_API_KEY="Bearer $GITHUB_TOKEN"
40-
bazel run //rb:${{ matrix.gem }}-bump-nightly-version ${{ inputs.version }}
41-
bazel run //rb:${{ matrix.gem }}-release-nightly
38+
env:
39+
GEM_HOST_API_KEY: "Bearer $GITHUB_TOKEN"
40+
run: ./go rb:release['nightly', '--config=release']
4241
on-ruby-failure:
4342
name: On Ruby Failure
4443
runs-on: ubuntu-latest
@@ -64,9 +63,7 @@ jobs:
6463
with:
6564
name: Nightly Python Release
6665
cache-key: python-nightly
67-
run: |
68-
./go "py:version[nightly]"
69-
./go py:release[nightly]
66+
run: ./go py:release['nightly', '--config=release']
7067
secrets: inherit
7168
on-python-failure:
7269
name: On Python Failure
@@ -93,8 +90,7 @@ jobs:
9390
with:
9491
name: Nightly Java Release
9592
cache-key: java-nightly
96-
run: |
97-
./go publish-maven-snapshot
93+
run: ./go publish-maven-snapshot
9894
secrets: inherit
9995
on-java-failure:
10096
name: On Java Failure
@@ -122,9 +118,7 @@ jobs:
122118
name: Nightly DotNet Release
123119
cache-key: dotnet-nightly
124120
dotnet-version: '6.x'
125-
run: |
126-
./go "dotnet:version[nightly]"
127-
./go dotnet:release
121+
run: ./go dotnet:release['nightly', '--config=release']
128122
secrets: inherit
129123
on-dotnet-failure:
130124
name: On .NET Failure
@@ -185,8 +179,7 @@ jobs:
185179
echo "//npm.pkg.github.com/:_authToken=${NODE_AUTH_TOKEN}" >> ~/.npmrc
186180
echo "@seleniumhq:registry=https://npm.pkg.github.com" >> ~/.npmrc
187181
echo "always-auth=true" >> ~/.npmrc
188-
./go "node:version[nightly]"
189-
./go node:release
182+
./go node:release['nightly', '--config=release']
190183
secrets: inherit
191184
on-javascript-failure:
192185
name: On JavaScript Failure

Rakefile

Lines changed: 18 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -488,8 +488,12 @@ namespace :node do
488488
end
489489

490490
desc 'Release Node npm package'
491-
task :release do
492-
Bazel.execute('run', ['--stamp'], '//javascript/node/selenium-webdriver:selenium-webdriver.publish')
491+
task :release, [:args] do |_task, arguments|
492+
args = Array(arguments[:args]) || ['--stamp']
493+
nightly = args.delete('nightly')
494+
Rake::Task['node:version'].invoke('nightly') if nightly
495+
496+
Bazel.execute('run', args, '//javascript/node/selenium-webdriver:selenium-webdriver.publish')
493497
end
494498

495499
desc 'Release Node npm package'
@@ -549,8 +553,10 @@ namespace :py do
549553

550554
desc 'Release Python wheel and sdist to pypi'
551555
task :release, [:args] do |_task, arguments|
552-
nightly = arguments[:args].delete('nightly')
553556
args = Array(arguments[:args]) || ['--stamp']
557+
nightly = args.delete('nightly')
558+
Rake::Task['py:version'].invoke('nightly') if nightly
559+
554560
command = nightly.nil? ? '//py:selenium-release' : '//py:selenium-release-nightly'
555561
Bazel.execute('run', args, command)
556562
end
@@ -717,8 +723,12 @@ namespace :rb do
717723
desc 'Push Ruby gems to rubygems'
718724
task :release, [:args] do |_task, arguments|
719725
args = Array(arguments[:args]) || ['--stamp']
720-
Bazel.execute('run', args, '//rb:selenium-webdriver-release')
721-
Bazel.execute('run', args, '//rb:selenium-devtools-release')
726+
nightly = args.delete('nightly')
727+
wd_target = nightly ? '//rb:selenium-webdriver-release' : '//rb:selenium-webdriver-release-nightly'
728+
cdp_target = nightly ? '//rb:selenium-devtools-release' : '//rb:selenium-devtools-release-nightly'
729+
730+
Bazel.execute('run', args, wd_target)
731+
Bazel.execute('run', args, cdp_target)
722732
end
723733

724734
desc 'Generate Ruby documentation'
@@ -787,6 +797,9 @@ namespace :dotnet do
787797
desc 'Upload nupkg files to Nuget'
788798
task :release, [:args] do |_task, arguments|
789799
args = Array(arguments[:args]) || ['--stamp']
800+
nightly = args.delete('nightly')
801+
Rake::Task['dotnet:version'].invoke('nightly') if nightly
802+
790803
Rake::Task['dotnet:package'].invoke(args)
791804

792805
release_version = dotnet_version

0 commit comments

Comments
 (0)