Skip to content

Commit c595b7a

Browse files
committed
[cdp][dotnet] add Chrome 118 and remove 115
1 parent c04855f commit c595b7a

17 files changed

+67
-67
lines changed

dotnet/selenium-dotnet-version.bzl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,9 @@ SUPPORTED_NET_STANDARD_VERSIONS = ["netstandard2.0"]
66

77
SUPPORTED_DEVTOOLS_VERSIONS = [
88
"v85",
9-
"v115",
109
"v116",
1110
"v117",
11+
"v118",
1212
]
1313

1414
ASSEMBLY_COMPANY = "Selenium Committers"

dotnet/src/webdriver/DevTools/DevToolsDomains.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,9 +37,9 @@ public abstract class DevToolsDomains
3737
// added to this dictionary.
3838
private static readonly Dictionary<int, Type> SupportedDevToolsVersions = new Dictionary<int, Type>()
3939
{
40+
{ 118, typeof(V118.V118Domains) },
4041
{ 117, typeof(V117.V117Domains) },
4142
{ 116, typeof(V116.V116Domains) },
42-
{ 115, typeof(V115.V115Domains) },
4343
{ 85, typeof(V85.V85Domains) }
4444
};
4545

dotnet/src/webdriver/DevTools/v115/V115Domains.cs renamed to dotnet/src/webdriver/DevTools/v118/V118Domains.cs

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// <copyright file="V115Domains.cs" company="WebDriver Committers">
1+
// <copyright file="V118Domains.cs" company="WebDriver Committers">
22
// Licensed to the Software Freedom Conservancy (SFC) under one
33
// or more contributor license agreements. See the NOTICE file
44
// distributed with this work for additional information
@@ -19,28 +19,28 @@
1919
using System.Collections.Generic;
2020
using System.Text;
2121

22-
namespace OpenQA.Selenium.DevTools.V115
22+
namespace OpenQA.Selenium.DevTools.V118
2323
{
2424
/// <summary>
25-
/// Class containing the domain implementation for version 115 of the DevTools Protocol.
25+
/// Class containing the domain implementation for version 118 of the DevTools Protocol.
2626
/// </summary>
27-
public class V115Domains : DevToolsDomains
27+
public class V118Domains : DevToolsDomains
2828
{
2929
private DevToolsSessionDomains domains;
3030

3131
/// <summary>
3232
/// Initializes a new instance of the V115Domains class.
3333
/// </summary>
3434
/// <param name="session">The DevToolsSession to use with this set of domains.</param>
35-
public V115Domains(DevToolsSession session)
35+
public V118Domains(DevToolsSession session)
3636
{
3737
this.domains = new DevToolsSessionDomains(session);
3838
}
3939

4040
/// <summary>
4141
/// Gets the DevTools Protocol version for which this class is valid.
4242
/// </summary>
43-
public static int DevToolsVersion => 115;
43+
public static int DevToolsVersion => 118;
4444

4545
/// <summary>
4646
/// Gets the version-specific domains for the DevTools session. This value must be cast to a version specific type to be at all useful.
@@ -50,21 +50,21 @@ public V115Domains(DevToolsSession session)
5050
/// <summary>
5151
/// Gets the object used for manipulating network information in the browser.
5252
/// </summary>
53-
public override DevTools.Network Network => new V115Network(domains.Network, domains.Fetch);
53+
public override DevTools.Network Network => new V118Network(domains.Network, domains.Fetch);
5454

5555
/// <summary>
5656
/// Gets the object used for manipulating the browser's JavaScript execution.
5757
/// </summary>
58-
public override JavaScript JavaScript => new V115JavaScript(domains.Runtime, domains.Page);
58+
public override JavaScript JavaScript => new V118JavaScript(domains.Runtime, domains.Page);
5959

6060
/// <summary>
6161
/// Gets the object used for manipulating DevTools Protocol targets.
6262
/// </summary>
63-
public override DevTools.Target Target => new V115Target(domains.Target);
63+
public override DevTools.Target Target => new V118Target(domains.Target);
6464

6565
/// <summary>
6666
/// Gets the object used for manipulating the browser's logs.
6767
/// </summary>
68-
public override DevTools.Log Log => new V115Log(domains.Log);
68+
public override DevTools.Log Log => new V118Log(domains.Log);
6969
}
7070
}

dotnet/src/webdriver/DevTools/v115/V115JavaScript.cs renamed to dotnet/src/webdriver/DevTools/v118/V118JavaScript.cs

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// <copyright file="V115JavaScript.cs" company="WebDriver Committers">
1+
// <copyright file="V118JavaScript.cs" company="WebDriver Committers">
22
// Licensed to the Software Freedom Conservancy (SFC) under one
33
// or more contributor license agreements. See the NOTICE file
44
// distributed with this work for additional information
@@ -18,25 +18,25 @@
1818
using System;
1919
using System.Collections.Generic;
2020
using System.Threading.Tasks;
21-
using OpenQA.Selenium.DevTools.V115.Page;
22-
using OpenQA.Selenium.DevTools.V115.Runtime;
21+
using OpenQA.Selenium.DevTools.V118.Page;
22+
using OpenQA.Selenium.DevTools.V118.Runtime;
2323

24-
namespace OpenQA.Selenium.DevTools.V115
24+
namespace OpenQA.Selenium.DevTools.V118
2525
{
2626
/// <summary>
27-
/// Class containing the JavaScript implementation for version 115 of the DevTools Protocol.
27+
/// Class containing the JavaScript implementation for version 118 of the DevTools Protocol.
2828
/// </summary>
29-
public class V115JavaScript : JavaScript
29+
public class V118JavaScript : JavaScript
3030
{
3131
private RuntimeAdapter runtime;
3232
private PageAdapter page;
3333

3434
/// <summary>
35-
/// Initializes a new instance of the <see cref="V115JavaScript"/> class.
35+
/// Initializes a new instance of the <see cref="V118JavaScript"/> class.
3636
/// </summary>
3737
/// <param name="runtime">The DevTools Protocol adapter for the Runtime domain.</param>
3838
/// <param name="page">The DevTools Protocol adapter for the Page domain.</param>
39-
public V115JavaScript(RuntimeAdapter runtime, PageAdapter page)
39+
public V118JavaScript(RuntimeAdapter runtime, PageAdapter page)
4040
{
4141
this.runtime = runtime;
4242
this.page = page;

dotnet/src/webdriver/DevTools/v115/V115Log.cs renamed to dotnet/src/webdriver/DevTools/v118/V118Log.cs

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// <copyright file="V115Log.cs" company="WebDriver Committers">
1+
// <copyright file="V118Log.cs" company="WebDriver Committers">
22
// Licensed to the Software Freedom Conservancy (SFC) under one
33
// or more contributor license agreements. See the NOTICE file
44
// distributed with this work for additional information
@@ -20,22 +20,22 @@
2020
using System.Text;
2121
using System.Threading;
2222
using System.Threading.Tasks;
23-
using OpenQA.Selenium.DevTools.V115.Log;
23+
using OpenQA.Selenium.DevTools.V118.Log;
2424

25-
namespace OpenQA.Selenium.DevTools.V115
25+
namespace OpenQA.Selenium.DevTools.V118
2626
{
2727
/// <summary>
28-
/// Class containing the browser's log as referenced by version 115 of the DevTools Protocol.
28+
/// Class containing the browser's log as referenced by version 118 of the DevTools Protocol.
2929
/// </summary>
30-
public class V115Log : DevTools.Log
30+
public class V118Log : DevTools.Log
3131
{
3232
private LogAdapter adapter;
3333

3434
/// <summary>
35-
/// Initializes a new instance of the <see cref="V115Log"/> class.
35+
/// Initializes a new instance of the <see cref="V118Log"/> class.
3636
/// </summary>
3737
/// <param name="adapter">The adapter for the Log domain.</param>
38-
public V115Log(LogAdapter adapter)
38+
public V118Log(LogAdapter adapter)
3939
{
4040
this.adapter = adapter;
4141
this.adapter.EntryAdded += OnAdapterEntryAdded;

dotnet/src/webdriver/DevTools/v115/V115Network.cs renamed to dotnet/src/webdriver/DevTools/v118/V118Network.cs

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// <copyright file="V115Network.cs" company="WebDriver Committers">
1+
// <copyright file="V118Network.cs" company="WebDriver Committers">
22
// Licensed to the Software Freedom Conservancy (SFC) under one
33
// or more contributor license agreements. See the NOTICE file
44
// distributed with this work for additional information
@@ -20,25 +20,25 @@
2020
using System.Collections.Generic;
2121
using System.Text;
2222
using System.Threading.Tasks;
23-
using OpenQA.Selenium.DevTools.V115.Fetch;
24-
using OpenQA.Selenium.DevTools.V115.Network;
23+
using OpenQA.Selenium.DevTools.V118.Fetch;
24+
using OpenQA.Selenium.DevTools.V118.Network;
2525

26-
namespace OpenQA.Selenium.DevTools.V115
26+
namespace OpenQA.Selenium.DevTools.V118
2727
{
2828
/// <summary>
29-
/// Class providing functionality for manipulating network calls using version 115 of the DevTools Protocol
29+
/// Class providing functionality for manipulating network calls using version 118 of the DevTools Protocol
3030
/// </summary>
31-
public class V115Network : DevTools.Network
31+
public class V118Network : DevTools.Network
3232
{
3333
private FetchAdapter fetch;
3434
private NetworkAdapter network;
3535

3636
/// <summary>
37-
/// Initializes a new instance of the <see cref="V115Network"/> class.
37+
/// Initializes a new instance of the <see cref="V118Network"/> class.
3838
/// </summary>
3939
/// <param name="network">The adapter for the Network domain.</param>
4040
/// <param name="fetch">The adapter for the Fetch domain.</param>
41-
public V115Network(NetworkAdapter network, FetchAdapter fetch)
41+
public V118Network(NetworkAdapter network, FetchAdapter fetch)
4242
{
4343
this.network = network;
4444
this.fetch = fetch;
@@ -216,9 +216,9 @@ public override async Task ContinueWithAuth(string requestId, string userName, s
216216
await fetch.ContinueWithAuth(new ContinueWithAuthCommandSettings()
217217
{
218218
RequestId = requestId,
219-
AuthChallengeResponse = new V115.Fetch.AuthChallengeResponse()
219+
AuthChallengeResponse = new V118.Fetch.AuthChallengeResponse()
220220
{
221-
Response = V115.Fetch.AuthChallengeResponseResponseValues.ProvideCredentials,
221+
Response = V118.Fetch.AuthChallengeResponseResponseValues.ProvideCredentials,
222222
Username = userName,
223223
Password = password
224224
}
@@ -235,9 +235,9 @@ public override async Task CancelAuth(string requestId)
235235
await fetch.ContinueWithAuth(new ContinueWithAuthCommandSettings()
236236
{
237237
RequestId = requestId,
238-
AuthChallengeResponse = new OpenQA.Selenium.DevTools.V115.Fetch.AuthChallengeResponse()
238+
AuthChallengeResponse = new OpenQA.Selenium.DevTools.V118.Fetch.AuthChallengeResponse()
239239
{
240-
Response = V115.Fetch.AuthChallengeResponseResponseValues.CancelAuth
240+
Response = V118.Fetch.AuthChallengeResponseResponseValues.CancelAuth
241241
}
242242
}).ConfigureAwait(false);
243243
}

dotnet/src/webdriver/DevTools/v115/V115Target.cs renamed to dotnet/src/webdriver/DevTools/v118/V118Target.cs

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// <copyright file="V115Target.cs" company="WebDriver Committers">
1+
// <copyright file="V118Target.cs" company="WebDriver Committers">
22
// Licensed to the Software Freedom Conservancy (SFC) under one
33
// or more contributor license agreements. See the NOTICE file
44
// distributed with this work for additional information
@@ -21,22 +21,22 @@
2121
using System.Collections.ObjectModel;
2222
using System.Text;
2323
using System.Threading.Tasks;
24-
using OpenQA.Selenium.DevTools.V115.Target;
24+
using OpenQA.Selenium.DevTools.V118.Target;
2525

26-
namespace OpenQA.Selenium.DevTools.V115
26+
namespace OpenQA.Selenium.DevTools.V118
2727
{
2828
/// <summary>
29-
/// Class providing functionality for manipulating targets for version 115 of the DevTools Protocol
29+
/// Class providing functionality for manipulating targets for version 118 of the DevTools Protocol
3030
/// </summary>
31-
public class V115Target : DevTools.Target
31+
public class V118Target : DevTools.Target
3232
{
3333
private TargetAdapter adapter;
3434

3535
/// <summary>
36-
/// Initializes a new instance of the <see cref="V115Target"/> class.
36+
/// Initializes a new instance of the <see cref="V118Target"/> class.
3737
/// </summary>
3838
/// <param name="adapter">The adapter for the Target domain.</param>
39-
public V115Target(TargetAdapter adapter)
39+
public V118Target(TargetAdapter adapter)
4040
{
4141
this.adapter = adapter;
4242
adapter.DetachedFromTarget += OnDetachedFromTarget;

dotnet/src/webdriver/WebDriver.csproj.prebuild.cmd

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -27,13 +27,6 @@ if not exist "%1..\..\..\bazel-bin\dotnet\src\webdriver\cdp\v85\DevToolsSession
2727
popd
2828
)
2929

30-
if not exist "%1..\..\..\bazel-bin\dotnet\src\webdriver\cdp\v115\DevToolsSessionDomains.cs" (
31-
echo Generating CDP code for version 115
32-
pushd "%1..\..\.."
33-
bazel build //dotnet/src/webdriver/cdp:generate-v115
34-
popd
35-
)
36-
3730
if not exist "%1..\..\..\bazel-bin\dotnet\src\webdriver\cdp\v116\DevToolsSessionDomains.cs" (
3831
echo Generating CDP code for version 116
3932
pushd "%1..\..\.."
@@ -47,3 +40,10 @@ if not exist "%1..\..\..\bazel-bin\dotnet\src\webdriver\cdp\v117\DevToolsSessio
4740
bazel build //dotnet/src/webdriver/cdp:generate-v117
4841
popd
4942
)
43+
44+
if not exist "%1..\..\..\bazel-bin\dotnet\src\webdriver\cdp\v118\DevToolsSessionDomains.cs" (
45+
echo Generating CDP code for version 118
46+
pushd "%1..\..\.."
47+
bazel build //dotnet/src/webdriver/cdp:generate-v118
48+
popd
49+
)

dotnet/src/webdriver/WebDriver.csproj.prebuild.sh

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -23,12 +23,6 @@ then
2323
bazel build //dotnet/src/webdriver/cdp:generate-v85
2424
fi
2525

26-
if [[ ! -f "$1../../../bazel-bin/dotnet/src/webdriver/cdp/v115/DevToolsSessionDomains.cs" ]]
27-
then
28-
echo "Generating CDP code for version 115"
29-
bazel build //dotnet/src/webdriver/cdp:generate-v115
30-
fi
31-
3226
if [[ ! -f "$1../../../bazel-bin/dotnet/src/webdriver/cdp/v116/DevToolsSessionDomains.cs" ]]
3327
then
3428
echo "Generating CDP code for version 116"
@@ -40,3 +34,9 @@ then
4034
echo "Generating CDP code for version 117"
4135
bazel build //dotnet/src/webdriver/cdp:generate-v117
4236
fi
37+
38+
if [[ ! -f "$1../../../bazel-bin/dotnet/src/webdriver/cdp/v118/DevToolsSessionDomains.cs" ]]
39+
then
40+
echo "Generating CDP code for version 118"
41+
bazel build //dotnet/src/webdriver/cdp:generate-v118
42+
fi

dotnet/test/common/CustomDriverConfigs/StableChannelChromeDriver.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ public StableChannelChromeDriver(ChromeDriverService service, ChromeOptions opti
2020

2121
public static ChromeOptions DefaultOptions
2222
{
23-
get { return new ChromeOptions() { BrowserVersion = "117" }; }
23+
get { return new ChromeOptions() { BrowserVersion = "118" }; }
2424
}
2525
}
2626
}

0 commit comments

Comments
 (0)