Merge branch 'trunk' into action-builder

Author: RenderMichael

MODULE.bazel

@@ -12,10 +12,11 @@ bazel_dep(name = "contrib_rules_jvm", version = "0.27.0")
 bazel_dep(name = "platforms", version = "0.0.10")
 
 # Required for the closure rules
-bazel_dep(name = "protobuf", dev_dependency = True, repo_name = "com_google_protobuf", version = "29.2")
+bazel_dep(name = "protobuf", version = "29.2", dev_dependency = True, repo_name = "com_google_protobuf")
 
 # Required for rules_rust to import the crates properly
-bazel_dep(name = "rules_cc", dev_dependency = True, version = "0.0.9")
+bazel_dep(name = "rules_cc", version = "0.0.9", dev_dependency = True)
+
 bazel_dep(name = "rules_dotnet", version = "0.17.5")
 bazel_dep(name = "rules_java", version = "7.12.4")
 bazel_dep(name = "rules_jvm_external", version = "6.6")
@@ -27,33 +28,27 @@ bazel_dep(name = "rules_proto", version = "6.0.2")
 bazel_dep(name = "rules_ruby", version = "0.13.0")
 
 linter = use_extension("@apple_rules_lint//lint:extensions.bzl", "linter")
-
 linter.configure(
     name = "java-spotbugs",
     config = "//java:spotbugs-config",
 )
-
 linter.configure(
     name = "rust-rustfmt",
     config = "//rust:enable-rustfmt",
 )
-
 linter.register(name = "rust-rustfmt")
 
 node = use_extension("@rules_nodejs//nodejs:extensions.bzl", "node")
-
 node.toolchain(node_version = "20.9.0")
 
 pnpm = use_extension(
     "@aspect_rules_js//npm:extensions.bzl",
     "pnpm",
     dev_dependency = True,
 )
-
 use_repo(pnpm, "pnpm")
 
 npm = use_extension("@aspect_rules_js//npm:extensions.bzl", "npm")
-
 npm.npm_translate_lock(
     name = "npm",
     data = [
@@ -68,76 +63,59 @@ npm.npm_translate_lock(
     update_pnpm_lock = True,
     verify_node_modules_ignored = "//:.bazelignore",
 )
-
 use_repo(npm, "npm")
 
 rules_ts_ext = use_extension(
     "@aspect_rules_ts//ts:extensions.bzl",
     "ext",
     dev_dependency = True,
 )
-
 rules_ts_ext.deps(
     ts_version = "4.9.5",
 )
-
 use_repo(rules_ts_ext, "npm_typescript")
 
 esbuild = use_extension("@aspect_rules_esbuild//esbuild:extensions.bzl", "esbuild")
-
 esbuild.toolchain(esbuild_version = "0.23.0")
-
 use_repo(esbuild, "esbuild_toolchains")
 
 register_toolchains("@esbuild_toolchains//:all")
 
 dotnet = use_extension("@rules_dotnet//dotnet:extensions.bzl", "dotnet")
-
 dotnet.toolchain(dotnet_version = "8.0.203")
-
 use_repo(dotnet, "dotnet_toolchains")
 
 selenium_paket = use_extension("//dotnet:paket.nuget_extension.bzl", "nuget_extension")
-
 use_repo(selenium_paket, "paket.nuget")
 
 register_toolchains("@dotnet_toolchains//:all")
 
 oci = use_extension("@rules_oci//oci:extensions.bzl", "oci")
-
 oci.pull(
     name = "java_image_base",
     digest = "sha256:161a1d97d592b3f1919801578c3a47c8e932071168a96267698f4b669c24c76d",
     image = "gcr.io/distroless/java17",
 )
-
 oci.pull(
     name = "firefox_standalone",
     digest = "sha256:b6d8279268b3183d0d33e667e82fec1824298902f77718764076de763673124f",
     image = "index.docker.io/selenium/standalone-firefox",
 )
-
 oci.pull(
     name = "chrome_standalone",
     digest = "sha256:1b809a961a0a77787a7cccac74ddc5570b7e89747f925b8469ddb9a6624d4ece",
     image = "index.docker.io/selenium/standalone-chrome",
 )
-
 use_repo(oci, "chrome_standalone", "firefox_standalone", "java_image_base")
 
 python = use_extension("@rules_python//python/extensions:python.bzl", "python")
-
 python.toolchain(
     is_default = True,
     python_version = "3.9",
 )
-
 python.toolchain(python_version = "3.10")
-
 python.toolchain(python_version = "3.11")
-
 python.toolchain(python_version = "3.12")
-
 use_repo(python, "pythons_hub")
 
 pip = use_extension("@rules_python//python/extensions:pip.bzl", "pip")
@@ -162,16 +140,15 @@ register_toolchains("@pythons_hub//:all")
 
 # https://github.com/bazelbuild/rules_jvm_external/pull/1079
 archive_override(
-    integrity = "sha256-yS8Qes1PLbYbe10b1WSgl0Auqn/1Wlxg8O3wSr7a/Sg=",
     module_name = "rules_jvm_external",
+    integrity = "sha256-yS8Qes1PLbYbe10b1WSgl0Auqn/1Wlxg8O3wSr7a/Sg=",
     patch_strip = 1,
     patches = ["//java:rules_jvm_external_javadoc.patch"],
     strip_prefix = "rules_jvm_external-f572a26116c7ef71d8842dd056c2605782f7be8d",
     urls = ["https://github.com/bazelbuild/rules_jvm_external/archive/f572a26116c7ef71d8842dd056c2605782f7be8d.tar.gz"],
 )
 
 java_toolchains = use_extension("@rules_java//java:extensions.bzl", "toolchains")
-
 use_repo(
     java_toolchains,
     "remote_java_tools",
@@ -188,7 +165,6 @@ use_repo(
 )
 
 maven = use_extension("@rules_jvm_external//:extensions.bzl", "maven")
-
 maven.install(
     name = "maven",
     artifacts = [
@@ -267,11 +243,9 @@ maven.install(
     resolver = "maven",
     strict_visibility = True,
 )
-
 use_repo(maven, "maven", "unpinned_maven")
 
 ruby = use_extension("@rules_ruby//ruby:extensions.bzl", "ruby")
-
 ruby.toolchain(
     name = "ruby",
     msys2_packages = [
@@ -280,7 +254,6 @@ ruby.toolchain(
     ],
     version_file = "//:rb/.ruby-version",
 )
-
 ruby.bundle_fetch(
     name = "bundle",
     srcs = [
@@ -371,13 +344,11 @@ ruby.bundle_fetch(
     gemfile = "//:rb/Gemfile",
     gemfile_lock = "//:rb/Gemfile.lock",
 )
-
 use_repo(ruby, "bundle", "ruby", "ruby_toolchains")
 
 register_toolchains("@ruby_toolchains//:all")
 
 selenium_manager_artifacts = use_extension("//common:selenium_manager.bzl", "selenium_manager_artifacts")
-
 use_repo(
     selenium_manager_artifacts,
     "download_sm_linux",
@@ -386,7 +357,6 @@ use_repo(
 )
 
 pin_browsers_extension = use_extension("//common:repositories.bzl", "pin_browsers_extension")
-
 use_repo(
     pin_browsers_extension,
     "linux_beta_firefox",

java/src/org/openqa/selenium/remote/service/DriverService.java

@@ -31,6 +31,7 @@
 import java.net.URL;
 import java.time.Duration;
 import java.util.List;
+import java.util.Locale;
 import java.util.Map;
 import java.util.concurrent.CompletableFuture;
 import java.util.concurrent.ExecutionException;
@@ -504,6 +505,17 @@ public DS build() {
         port = PortProber.findFreePort();
       }
 
+      if (Locale.getDefault(Locale.Category.FORMAT).getLanguage().equals("ar")) {
+        throw new NumberFormatException(
+            String.format(
+                "Couldn't format the port numbers because the System Language is arabic:"
+                    + " \"--port=%d\", please make sure to add the required arguments"
+                    + " \"-Duser.language=en -Duser.region=US\" to your JVM, for more info please"
+                    + " visit :%n"
+                    + "  https://www.selenium.dev/documentation/webdriver/browsers/",
+                getPort()));
+      }
+
       if (timeout == null) {
         timeout = getDefaultTimeout();
       }

java/test/org/openqa/selenium/chrome/ChromeDriverFunctionalTest.java

@@ -204,18 +204,23 @@ void canExecuteCdpCommands() {
 
   @Test
   @NoDriverBeforeTest
-  void shouldLaunchSuccessfullyWithArabicDate() {
+  void shouldThrowNumberFormatException() {
     Locale arabicLocale = new Locale("ar", "EG");
     Locale.setDefault(arabicLocale);
-    Locale.setDefault(Locale.US);
 
     int port = PortProber.findFreePort();
     ChromeDriverService.Builder builder = new ChromeDriverService.Builder();
     builder.usingPort(port);
-    ChromeDriverService service = builder.build();
 
-    driver = new ChromeDriver(service, (ChromeOptions) CHROME.getCapabilities());
-    driver.get(pages.simpleTestPage);
-    assertThat(driver.getTitle()).isEqualTo("Hello WebDriver");
+    assertThatExceptionOfType(NumberFormatException.class)
+        .isThrownBy(builder::build)
+        .withMessage(
+            "Couldn't format the port numbers because the System Language is arabic: \""
+                + String.format("--port=%d", port)
+                + "\", please make sure to add the required arguments \"-Duser.language=en"
+                + " -Duser.region=US\" to your JVM, for more info please visit :\n"
+                + "  https://www.selenium.dev/documentation/webdriver/browsers/");
+
+    Locale.setDefault(Locale.US);
   }
 }

java/test/org/openqa/selenium/edge/EdgeDriverFunctionalTest.java

@@ -198,19 +198,23 @@ void canExecuteCdpCommands() {
 
   @Test
   @NoDriverBeforeTest
-  void shouldLaunchSuccessfullyWithArabicDate() {
+  void shouldThrowNumberFormatException() {
     Locale arabicLocale = new Locale("ar", "EG");
     Locale.setDefault(arabicLocale);
-    Locale.setDefault(Locale.US);
 
     int port = PortProber.findFreePort();
     EdgeDriverService.Builder builder = new EdgeDriverService.Builder();
     builder.usingPort(port);
-    EdgeDriverService service = builder.build();
 
-    driver = new EdgeDriver(service, (EdgeOptions) EDGE.getCapabilities());
+    assertThatExceptionOfType(NumberFormatException.class)
+        .isThrownBy(builder::build)
+        .withMessage(
+            "Couldn't format the port numbers because the System Language is arabic: \""
+                + String.format("--port=%d", port)
+                + "\", please make sure to add the required arguments \"-Duser.language=en"
+                + " -Duser.region=US\" to your JVM, for more info please visit :\n"
+                + "  https://www.selenium.dev/documentation/webdriver/browsers/");
 
-    driver.get(pages.simpleTestPage);
-    assertThat(driver.getTitle()).isEqualTo("Hello WebDriver");
+    Locale.setDefault(Locale.US);
   }
 }

java/test/org/openqa/selenium/firefox/FirefoxDriverTest.java

@@ -18,6 +18,7 @@
 package org.openqa.selenium.firefox;
 
 import static org.assertj.core.api.Assertions.assertThat;
+import static org.assertj.core.api.AssertionsForClassTypes.assertThatExceptionOfType;
 import static org.assertj.core.api.AssertionsForClassTypes.assertThatThrownBy;
 import static org.junit.jupiter.api.Assertions.fail;
 import static org.junit.jupiter.api.Assumptions.assumeTrue;
@@ -272,19 +273,24 @@ void canSetContext() {
 
   @Test
   @NoDriverBeforeTest
-  void shouldLaunchSuccessfullyWithArabicDate() {
+  void shouldThrowNumberFormatException() {
     Locale arabicLocale = new Locale("ar", "EG");
     Locale.setDefault(arabicLocale);
-    Locale.setDefault(Locale.US);
 
     int port = PortProber.findFreePort();
     GeckoDriverService.Builder builder = new GeckoDriverService.Builder();
     builder.usingPort(port);
-    GeckoDriverService service = builder.build();
 
-    driver = new FirefoxDriver(service, (FirefoxOptions) FIREFOX.getCapabilities());
-    driver.get(pages.simpleTestPage);
-    assertThat(driver.getTitle()).isEqualTo("Hello WebDriver");
+    assertThatExceptionOfType(NumberFormatException.class)
+        .isThrownBy(builder::build)
+        .withMessage(
+            "Couldn't format the port numbers because the System Language is arabic: \""
+                + String.format("--port=%d", port)
+                + "\", please make sure to add the required arguments \"-Duser.language=en"
+                + " -Duser.region=US\" to your JVM, for more info please visit :\n"
+                + "  https://www.selenium.dev/documentation/webdriver/browsers/");
+
+    Locale.setDefault(Locale.US);
   }
 
   private static class CustomFirefoxProfile extends FirefoxProfile {}

java/test/org/openqa/selenium/ie/InternetExplorerDriverTest.java

@@ -24,6 +24,7 @@
 
 import java.awt.*;
 import java.time.Duration;
+import java.util.Locale;
 import org.junit.jupiter.api.Test;
 import org.openqa.selenium.By;
 import org.openqa.selenium.Capabilities;
@@ -33,6 +34,7 @@
 import org.openqa.selenium.WebDriver;
 import org.openqa.selenium.WebElement;
 import org.openqa.selenium.interactions.Actions;
+import org.openqa.selenium.net.PortProber;
 import org.openqa.selenium.remote.RemoteWebDriverBuilder;
 import org.openqa.selenium.remote.http.ClientConfig;
 import org.openqa.selenium.testing.JupiterTestBase;
@@ -143,6 +145,28 @@ void testPersistentHoverCanBeTurnedOff() throws Exception {
     assertThat(item.getText()).isEmpty();
   }
 
+  @Test
+  @NoDriverBeforeTest
+  void shouldThrowNumberFormatException() {
+    Locale arabicLocale = new Locale("ar", "EG");
+    Locale.setDefault(arabicLocale);
+
+    int port = PortProber.findFreePort();
+    InternetExplorerDriverService.Builder builder = new InternetExplorerDriverService.Builder();
+    builder.usingPort(port);
+
+    assertThatExceptionOfType(NumberFormatException.class)
+        .isThrownBy(builder::build)
+        .withMessage(
+            "Couldn't format the port numbers because the System Language is arabic: \""
+                + String.format("--port=%d", port)
+                + "\", please make sure to add the required arguments \"-Duser.language=en"
+                + " -Duser.region=US\" to your JVM, for more info please visit :\n"
+                + "  https://www.selenium.dev/documentation/webdriver/browsers/");
+
+    Locale.setDefault(Locale.US);
+  }
+
   private WebDriver newIeDriver() {
     return new WebDriverBuilder().get();
   }

java/test/org/openqa/selenium/safari/SafariDriverTest.java

@@ -27,6 +27,7 @@
 import java.nio.file.Path;
 import java.nio.file.Paths;
 import java.time.Duration;
+import java.util.Locale;
 import org.junit.jupiter.api.Test;
 import org.openqa.selenium.Capabilities;
 import org.openqa.selenium.SessionNotCreatedException;
@@ -133,4 +134,26 @@ public void canAttachDebugger() {
     localDriver = new WebDriverBuilder().get(new SafariOptions());
     ((HasDebugger) localDriver).attachDebugger();
   }
+
+  @Test
+  @NoDriverBeforeTest
+  void shouldThrowNumberFormatException() {
+    Locale arabicLocale = new Locale("ar", "EG");
+    Locale.setDefault(arabicLocale);
+
+    int port = PortProber.findFreePort();
+    SafariDriverService.Builder builder = new SafariDriverService.Builder();
+    builder.usingPort(port);
+
+    assertThatExceptionOfType(NumberFormatException.class)
+        .isThrownBy(builder::build)
+        .withMessage(
+            "Couldn't format the port numbers because the System Language is arabic: \""
+                + String.format("--port=%d", port)
+                + "\", please make sure to add the required arguments \"-Duser.language=en"
+                + " -Duser.region=US\" to your JVM, for more info please visit :\n"
+                + "  https://www.selenium.dev/documentation/webdriver/browsers/");
+
+    Locale.setDefault(Locale.US);
+  }
 }