Skip to content

Commit c6c3f95

Browse files
committed
All firefox-specific old-style capabilities begin with firefox_
Of course, the protocol handshake is flawed in the way that it constructs the W3C capabilities, since it doesn't transform some of the common objects (timeouts), and it automatically forwards known-bad capabilities (eg. `firefox.*` ones) to the remote end. Worse, it draws no distinction between required and desired capabilities, but it turns out that noone on the planet other than me cared, so I guess that's okay.
1 parent 8ec95cb commit c6c3f95

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

java/client/src/org/openqa/selenium/remote/ProtocolHandshake.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -141,8 +141,7 @@ private void amendW3cParameters(
141141
.flatMap(Collection::stream)
142142
.filter(entry ->
143143
("browserName".equals(entry.getKey()) && FIREFOX.equals(entry.getValue())) ||
144-
"firefox_binary".equals(entry.getKey()) ||
145-
"firefox_profile".equals(entry.getKey()) ||
144+
entry.getKey().startsWith("firefox_") ||
146145
entry.getKey().startsWith("moz:"))
147146
.distinct()
148147
.collect(Collectors.toMap(Map.Entry::getKey, Map.Entry::getValue));

0 commit comments

Comments
 (0)