Skip to content

Commit c769178

Browse files
Update GeckoDriver --port argument in all bindings. Fixes #2544
GeckoDriver updated the arguments to match that of IEDriver and ChromeDriver and now uses --port instead of --webdriver-port
1 parent 5cbc386 commit c769178

File tree

5 files changed

+7
-7
lines changed

5 files changed

+7
-7
lines changed

dotnet/src/webdriver/Firefox/FirefoxDriverService.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -154,7 +154,7 @@ protected override string CommandLineArguments
154154

155155
if (this.Port > 0)
156156
{
157-
argsBuilder.AppendFormat(CultureInfo.InvariantCulture, " --webdriver-port {0}", this.Port);
157+
argsBuilder.AppendFormat(CultureInfo.InvariantCulture, " --port {0}", this.Port);
158158
}
159159

160160
if (!string.IsNullOrEmpty(this.browserBinaryPath))

java/client/src/org/openqa/selenium/firefox/GeckoDriverService.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ protected File findDefaultExecutable() {
9797
@Override
9898
protected ImmutableList<String> createArgs() {
9999
ImmutableList.Builder<String> argsBuilder = ImmutableList.builder();
100-
argsBuilder.add(String.format("--webdriver-port=%d", getPort()));
100+
argsBuilder.add(String.format("--port=%d", getPort()));
101101
if (getLogFile() != null) {
102102
argsBuilder.add(String.format("--log-file=\"%s\"", getLogFile().getAbsolutePath()));
103103
}

javascript/node/selenium-webdriver/firefox/index.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -321,8 +321,8 @@ function createGeckoDriverService(binary) {
321321
loopback: true,
322322
port: port,
323323
args: Promise.all([exe, port, marionettePort]).then(args => {
324-
return ['-b', args[0],
325-
'--webdriver-port', args[1],
324+
return ['-b', args[0],
325+
'--port', args[1],
326326
'--marionette-port', args[2]];
327327
})
328328
// ,stdio: 'inherit'

py/selenium/webdriver/firefox/service.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,8 +50,8 @@ def __init__(self, executable_path, firefox_binary=None, port=0,
5050

5151
def command_line_args(self):
5252
if self.firefox_binary:
53-
return ["-b", self.firefox_binary, "--webdriver-port", "%d" % self.port]
54-
return ["--webdriver-port", "%d" % self.port]
53+
return ["-b", self.firefox_binary, "--port", "%d" % self.port]
54+
return ["--port", "%d" % self.port]
5555

5656
def send_remote_shutdown_command(self):
5757
pass

rb/lib/selenium/webdriver/firefox/service.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ class Service < WebDriver::Service
3030
private
3131

3232
def start_process
33-
server_command = [@executable_path, "--binary=#{Firefox::Binary.path}", "--webdriver-port=#{@port}", *@extra_args]
33+
server_command = [@executable_path, "--binary=#{Firefox::Binary.path}", "--port=#{@port}", *@extra_args]
3434
@process = ChildProcess.build(*server_command)
3535

3636
if $DEBUG

0 commit comments

Comments
 (0)