[dotnet] Remove JSON serialization from riverOptions.ToString()

Author: RenderMichael

dotnet/src/webdriver/DriverOptions.cs

@@ -22,7 +22,7 @@
 using System;
 using System.Collections.Generic;
 using System.Globalization;
-using System.Text.Json;
+using System.Text;
 
 namespace OpenQA.Selenium
 {
@@ -396,7 +396,36 @@ public void SetLoggingPreference(string logType, LogLevel logLevel)
         /// <returns>A string representation of this <see cref="DriverOptions"/>.</returns>
         public override string ToString()
         {
-            return JsonSerializer.Serialize(this.ToDictionary(), new JsonSerializerOptions { WriteIndented = true });
+            StringBuilder builder = new StringBuilder();
+            bool needComma = false;
+
+            string browserName = this.BrowserName;
+            if (!string.IsNullOrEmpty(browserName))
+            {
+                builder.Append("Browser: ").Append(browserName);
+
+                string browserVersion = this.BrowserVersion;
+                if (!string.IsNullOrEmpty(browserVersion))
+                {
+                    builder.Append(' ');
+                    builder.Append(browserVersion);
+                }
+
+                needComma = true;
+            }
+
+            string platformName = this.PlatformName;
+            if (!string.IsNullOrEmpty(platformName))
+            {
+                if (needComma)
+                {
+                    builder.Append(", ");
+                }
+
+                builder.Append("Platform: ").Append(platformName);
+            }
+
+            return builder.ToString();
         }
 
         /// <summary>

dotnet/test/chrome/ChromeSpecificTests.cs

@@ -31,5 +31,14 @@ public void RunAfterAnyTests()
             EnvironmentManager.Instance.CloseCurrentDriver();
             EnvironmentManager.Instance.WebServer.Stop();
         }
+
+        [Test]
+        public void ChromeOptionsToString()
+        {
+            var options = new ChromeOptions();
+            options.BrowserVersion = "128";
+            options.PlatformName = "windows";
+            Assert.That(options.ToString(), Is.EqualTo("Browser: chrome 128, Platform: windows"));
+        }
     }
 }

dotnet/test/edge/EdgeSpecificTests.cs

@@ -18,11 +18,27 @@
 // </copyright>
 
 using NUnit.Framework;
+using OpenQA.Selenium.Environment;
 
 namespace OpenQA.Selenium.Edge
 {
     [TestFixture]
     public class EdgeSpecificTests : DriverTestFixture
     {
+        [OneTimeTearDown]
+        public void RunAfterAnyTests()
+        {
+            EnvironmentManager.Instance.CloseCurrentDriver();
+            EnvironmentManager.Instance.WebServer.Stop();
+        }
+
+        [Test]
+        public void EdgeOptionsToString()
+        {
+            var options = new EdgeOptions();
+            options.BrowserVersion = "128";
+            options.PlatformName = "windows";
+            Assert.That(options.ToString(), Is.EqualTo("Browser: MicrosoftEdge 128, Platform: windows"));
+        }
     }
 }

dotnet/test/firefox/FirefoxDriverTest.cs

@@ -366,6 +366,15 @@ public void ShouldInstallAndUninstallUnSignedDirAddon()
             Assert.That(driver.FindElements(By.Id("webextensions-selenium-example")).Count, Is.Zero);
         }
 
+        [Test]
+        public void FirefoxOptionsToString()
+        {
+            var options = new FirefoxOptions();
+            options.BrowserVersion = "128";
+            options.PlatformName = "windows";
+            Assert.That(options.ToString(), Is.EqualTo("Browser: firefox 128, Platform: windows"));
+        }
+
         private string GetPath(string name)
         {
             string sCurrentDirectory = AppDomain.CurrentDomain.BaseDirectory;

dotnet/test/ie/IeSpecificTests.cs

@@ -360,6 +360,14 @@ public void TestInvisibleZOrder()
             element.Click();
         }
 
+        //[Test]
+        public void InternetExplorerOptionsToString()
+        {
+            var options = new InternetExplorerOptions();
+
+            Assert.That(options.ToString(), Is.EqualTo("Browser: internet explorer, Platform: windows"));
+        }
+
         private long GetScrollTop()
         {
             return (long)((IJavaScriptExecutor)driver).ExecuteScript("return document.body.scrollTop;");

dotnet/test/safari/SafariSpecificTests.cs

@@ -18,11 +18,28 @@
 // </copyright>
 
 using NUnit.Framework;
+using OpenQA.Selenium.Environment;
 
 namespace OpenQA.Selenium.Safari
 {
     [TestFixture]
     public class SafariSpecificTests : DriverTestFixture
     {
+        [OneTimeTearDown]
+        public void RunAfterAnyTests()
+        {
+            EnvironmentManager.Instance.CloseCurrentDriver();
+            EnvironmentManager.Instance.WebServer.Stop();
+        }
+
+        [Test]
+        public void SafariOptionsToString()
+        {
+            var options = new SafariOptions();
+
+            options.BrowserVersion = "5.1.7";
+            options.PlatformName = "macos";
+            Assert.That(options.ToString(), Is.EqualTo("Browser: safari 5.1.7, Platform: macos"));
+        }
     }
 }