Skip to content

Commit c9e057d

Browse files
committed
add telescoping constructors
1 parent a68bbfb commit c9e057d

File tree

3 files changed

+37
-1
lines changed

3 files changed

+37
-1
lines changed

java/src/org/openqa/selenium/bidi/emulation/GeolocationCoordinates.java

Lines changed: 32 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,38 @@ public GeolocationCoordinates(
4040
this(latitude, longitude, 1.0, altitude, altitudeAccuracy, heading, speed);
4141
}
4242

43+
// Constructor with no altitude, altitudeAccuracy, heading, or speed
44+
public GeolocationCoordinates(double latitude, double longitude, double accuracy) {
45+
this(latitude, longitude, accuracy, null, null, null, null);
46+
}
47+
48+
// Constructor with no altitudeAccuracy, heading, or speed
49+
public GeolocationCoordinates(
50+
double latitude, double longitude, double accuracy, Double altitude) {
51+
this(latitude, longitude, accuracy, altitude, null, null, null);
52+
}
53+
54+
// Constructor no heading or speed
55+
public GeolocationCoordinates(
56+
double latitude,
57+
double longitude,
58+
double accuracy,
59+
Double altitude,
60+
Double altitudeAccuracy) {
61+
this(latitude, longitude, accuracy, altitude, altitudeAccuracy, null, null);
62+
}
63+
64+
// Constructor with no speed
65+
public GeolocationCoordinates(
66+
double latitude,
67+
double longitude,
68+
double accuracy,
69+
Double altitude,
70+
Double altitudeAccuracy,
71+
Double heading) {
72+
this(latitude, longitude, accuracy, altitude, altitudeAccuracy, heading, null);
73+
}
74+
4375
public GeolocationCoordinates(
4476
double latitude,
4577
double longitude,

java/src/org/openqa/selenium/bidi/emulation/SetGeolocationOverrideParameters.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,11 @@ public SetGeolocationOverrideParameters(
5050
}
5151
}
5252

53+
public SetGeolocationOverrideParameters(
54+
GeolocationCoordinates coordinates, GeolocationPositionError error) {
55+
this(coordinates, error, null, null);
56+
}
57+
5358
public Map<String, Object> toMap() {
5459
Map<String, Object> param = new HashMap<>();
5560

java/test/org/openqa/selenium/bidi/emulation/EmulationTest.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,6 @@ Object getBrowserGeolocation(WebDriver driver, String userContext, String origin
6363
+ " });\n"
6464
+ " },\n"
6565
+ " error => {\n"
66-
+ " console.log('Geolocation error:', error);\n"
6766
+ " callback({ error: error.message });\n"
6867
+ " },\n"
6968
+ " { enableHighAccuracy: false, timeout: 10000, maximumAge: 0 }\n"

0 commit comments

Comments
 (0)