Storage

Author: nvborisenko

dotnet/src/webdriver/BiDi/Storage/DeleteCookiesCommand.cs

@@ -21,11 +21,11 @@
 
 namespace OpenQA.Selenium.BiDi.Storage;
 
-internal class DeleteCookiesCommand(DeleteCookiesCommandParameters @params)
+internal sealed class DeleteCookiesCommand(DeleteCookiesCommandParameters @params)
     : Command<DeleteCookiesCommandParameters, DeleteCookiesResult>(@params, "storage.deleteCookies");
 
-internal record DeleteCookiesCommandParameters(CookieFilter? Filter, PartitionDescriptor? Partition) : CommandParameters;
+internal sealed record DeleteCookiesCommandParameters(CookieFilter? Filter, PartitionDescriptor? Partition) : CommandParameters;
 
-public record DeleteCookiesOptions : GetCookiesOptions;
+public sealed record DeleteCookiesOptions : GetCookiesOptions;
 
-public record DeleteCookiesResult(PartitionKey PartitionKey) : EmptyResult;
+public sealed record DeleteCookiesResult(PartitionKey PartitionKey) : EmptyResult;

dotnet/src/webdriver/BiDi/Storage/GetCookiesCommand.cs

@@ -25,19 +25,19 @@
 
 namespace OpenQA.Selenium.BiDi.Storage;
 
-internal class GetCookiesCommand(GetCookiesCommandParameters @params)
+internal sealed class GetCookiesCommand(GetCookiesCommandParameters @params)
     : Command<GetCookiesCommandParameters, GetCookiesResult>(@params, "storage.getCookies");
 
-internal record GetCookiesCommandParameters(CookieFilter? Filter, PartitionDescriptor? Partition) : CommandParameters;
+internal sealed record GetCookiesCommandParameters(CookieFilter? Filter, PartitionDescriptor? Partition) : CommandParameters;
 
-public record GetCookiesOptions : CommandOptions
+public sealed record GetCookiesOptions : CommandOptions
 {
     public CookieFilter? Filter { get; set; }
 
     public PartitionDescriptor? Partition { get; set; }
 }
 
-public record GetCookiesResult : EmptyResult, IReadOnlyList<Network.Cookie>
+public sealed record GetCookiesResult : EmptyResult, IReadOnlyList<Network.Cookie>
 {
     private readonly IReadOnlyList<Network.Cookie> _cookies;
 
@@ -58,7 +58,7 @@ internal GetCookiesResult(IReadOnlyList<Network.Cookie> cookies, PartitionKey pa
     IEnumerator IEnumerable.GetEnumerator() => (_cookies as IEnumerable).GetEnumerator();
 }
 
-public class CookieFilter
+public sealed record CookieFilter
 {
     public string? Name { get; set; }
 
@@ -84,9 +84,9 @@ public class CookieFilter
 [JsonDerivedType(typeof(StorageKeyPartitionDescriptor), "storageKey")]
 public abstract record PartitionDescriptor;
 
-public record ContextPartitionDescriptor(BrowsingContext.BrowsingContext Context) : PartitionDescriptor;
+public sealed record ContextPartitionDescriptor(BrowsingContext.BrowsingContext Context) : PartitionDescriptor;
 
-public record StorageKeyPartitionDescriptor : PartitionDescriptor
+public sealed record StorageKeyPartitionDescriptor : PartitionDescriptor
 {
     public string? UserContext { get; set; }
 

dotnet/src/webdriver/BiDi/Storage/PartitionKey.cs

@@ -19,7 +19,7 @@
 
 namespace OpenQA.Selenium.BiDi.Storage;
 
-public class PartitionKey
+public sealed record PartitionKey
 {
     public Browser.UserContext? UserContext { get; set; }
 

dotnet/src/webdriver/BiDi/Storage/SetCookieCommand.cs

@@ -22,12 +22,12 @@
 
 namespace OpenQA.Selenium.BiDi.Storage;
 
-internal class SetCookieCommand(SetCookieCommandParameters @params)
+internal sealed class SetCookieCommand(SetCookieCommandParameters @params)
     : Command<SetCookieCommandParameters, SetCookieResult>(@params, "storage.setCookie");
 
-internal record SetCookieCommandParameters(PartialCookie Cookie, PartitionDescriptor? Partition) : CommandParameters;
+internal sealed record SetCookieCommandParameters(PartialCookie Cookie, PartitionDescriptor? Partition) : CommandParameters;
 
-public record PartialCookie(string Name, Network.BytesValue Value, string Domain)
+public sealed record PartialCookie(string Name, Network.BytesValue Value, string Domain)
 {
     public string? Path { get; set; }
 
@@ -40,9 +40,9 @@ public record PartialCookie(string Name, Network.BytesValue Value, string Domain
     public DateTimeOffset? Expiry { get; set; }
 }
 
-public record SetCookieOptions : CommandOptions
+public sealed record SetCookieOptions : CommandOptions
 {
     public PartitionDescriptor? Partition { get; set; }
 }
 
-public record SetCookieResult(PartitionKey PartitionKey) : EmptyResult;
+public sealed record SetCookieResult(PartitionKey PartitionKey) : EmptyResult;

dotnet/src/webdriver/BiDi/Storage/StorageModule.cs

@@ -22,7 +22,7 @@
 
 namespace OpenQA.Selenium.BiDi.Storage;
 
-public class StorageModule(Broker broker) : Module(broker)
+public sealed class StorageModule(Broker broker) : Module(broker)
 {
     public async Task<GetCookiesResult> GetCookiesAsync(GetCookiesOptions? options = null)
     {