Skip to content

Commit cec3855

Browse files
committed
Try to use ci? method
1 parent 68c1e73 commit cec3855

File tree

8 files changed

+15
-27
lines changed

8 files changed

+15
-27
lines changed
Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,7 @@
11
class Selenium::WebDriver::Remote::Bridge
2-
def execute: (Symbol, ?Hash[untyped, untyped], ?Hash[untyped, untyped]) -> nil
3-
| (Symbol, ?Hash[untyped, untyped], ?nil) -> Hash[untyped, untyped]
4-
| (Symbol, ?Hash[untyped, untyped], ?nil) -> nil
2+
def quit: () -> nil
53

6-
def session_id: () -> String
4+
def execute: (Symbol, ?Hash[untyped, untyped], ?nil) -> void
75

8-
def quit: () -> nil
6+
def session_id: () -> String
97
end

rb/sig/lib/selenium/webdriver/remote/http/common.rbs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
class Selenium::WebDriver::Remote::Http::Common
2-
def call: (Symbol, String, Hash[untyped, untyped]) -> Selenium::WebDriver::Remote::Response
3-
| (Symbol, String, nil) -> Selenium::WebDriver::Remote::Response
2+
def call: (Symbol, String, nil) -> Selenium::WebDriver::Remote::Response
43

54
def server_url: () -> URI::HTTP
65

rb/sig/lib/selenium/webdriver/remote/http/default.rbs

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,9 @@
11
class Selenium::WebDriver::Remote::Http::Default
2-
def request: (Symbol, URI::HTTP, Hash[untyped, untyped], String, ?Integer) -> Selenium::WebDriver::Remote::Response
3-
| (Symbol, URI::HTTP, Hash[untyped, untyped], nil, ?Integer) -> Selenium::WebDriver::Remote::Response
2+
def request: (Symbol, URI::HTTP, Hash[untyped, untyped], nil, ?Integer) -> Selenium::WebDriver::Remote::Response
43

5-
def new_request_for: (Symbol, URI::HTTP, Hash[untyped, untyped], String) -> Net::HTTP::Post
6-
| (Symbol, URI::HTTP, Hash[untyped, untyped], nil) -> Net::HTTP::Get
7-
| (Symbol, URI::HTTP, Hash[untyped, untyped], nil) -> Net::HTTP::Delete
4+
def new_request_for: (Symbol, URI::HTTP, Hash[untyped, untyped], nil) -> Net::HTTP::Delete
85

9-
def response_for: (Net::HTTP::Post) -> Net::HTTPOK
10-
| (Net::HTTP::Get) -> Net::HTTPOK
11-
| (Net::HTTP::Delete) -> Net::HTTPOK
6+
def response_for: (Net::HTTP::Delete) -> Net::HTTPOK
127

138
def http: () -> Net::HTTP
149

rb/sig/lib/selenium/webdriver/remote/response.rbs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,6 @@ class Selenium::WebDriver::Remote::Response
66
def error: () -> nil
77

88
def process_error: () -> nil
9-
| () -> Array[untyped]
109

1110
def []: (String) -> nil
12-
| (String) -> Hash[untyped, untyped]
1311
end

rb/sig/lib/selenium/webdriver/support/guards.rbs

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,9 @@ class Selenium::WebDriver::Support::Guards
77
| (Symbol, ?nil) -> void
88
| (Symbol, ?bool) -> void
99

10-
def disposition: () -> nil
10+
def disposition: () -> Array[untyped]
1111

12-
def skipping_guard: () -> nil
12+
def skipping_guard: () -> Selenium::WebDriver::Support::Guards::Guard
1313

1414
def satisfied?: (Selenium::WebDriver::Support::Guards::Guard) -> bool
15-
16-
def pending_guard: () -> nil
1715
end

rb/sig/lib/selenium/webdriver/support/guards/guard.rbs

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,5 @@ class Selenium::WebDriver::Support::Guards::Guard
33

44
def exclusive?: () -> bool
55

6-
def exclude?: () -> bool
7-
8-
def except?: () -> bool
9-
10-
def only?: () -> bool
6+
def message: () -> String
117
end

rb/spec/integration/selenium/webdriver/spec_helper.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ def example_finished(notification)
4545
module TraceHelper
4646
# @rbs () -> RBS::Trace
4747
def self.trace
48-
@trace ||= if GlobalTestEnv.send(:current_env)[:ci].nil?
48+
@trace ||= unless GlobalTestEnv.ci?
4949
require 'rbs-trace'
5050
RBS::Trace.new
5151
end

rb/spec/integration/selenium/webdriver/spec_support/test_environment.rb

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -197,6 +197,10 @@ def create_driver!(listener: nil, **opts, &block)
197197
raise e
198198
end
199199

200+
def ci?
201+
current_env[:ci]
202+
end
203+
200204
private
201205

202206
# @rbs (**Hash[untyped, untyped]) -> Selenium::WebDriver::Chrome::Options

0 commit comments

Comments
 (0)