Skip to content

Commit cfcc455

Browse files
committed
fix failing tests
1 parent 8977cf7 commit cfcc455

File tree

5 files changed

+9
-8
lines changed

5 files changed

+9
-8
lines changed

py/selenium/webdriver/common/actions/mouse_button.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,4 +23,3 @@ class MouseButton:
2323
RIGHT = 2
2424
BACK = 3
2525
FORWARD = 4
26-

rb/CHANGES

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@ ActionBuilder:
4141
* Add support for pointer event properties
4242
* Implement scroll wheel support
4343
* Deprecate ordered pair parameters for pause method in favor of keywords
44+
* Deprecate move to element with offset changing origin to top left of element
4445

4546
4.1.0 (2021-11-22)
4647
=========================

rb/spec/integration/selenium/webdriver/action_builder_spec.rb

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -260,7 +260,7 @@ module WebDriver
260260
end
261261
end
262262

263-
describe 'pen stylus' do
263+
describe 'pen stylus', except: {browser: :firefox, reason: 'Unknown pointerType'} do
264264
it 'sets pointer event properties' do
265265
driver.get 'https://titusfortner.com/examples/pointerActionsPage.html'
266266
pointer_area = driver.find_element(id: 'pointerArea')
@@ -374,6 +374,7 @@ module WebDriver
374374
iframe = driver.find_element(tag_name: 'iframe')
375375
driver.switch_to.frame(iframe)
376376
checkbox = driver.find_element(name: 'scroll_checkbox')
377+
sleep 0.5
377378
expect(in_viewport?(checkbox)).to eq true
378379
end
379380

rb/spec/integration/selenium/webdriver/element_spec.rb

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -45,39 +45,39 @@ module WebDriver
4545
driver.navigate.to url_for('formPage.html')
4646
driver.find_element(id: 'submitButton').submit
4747

48-
wait_for_new_url('formPage.html')
48+
sleep 0.5
4949
expect(driver.title).to eq('We Arrive Here')
5050
end
5151

5252
it 'any input element in form' do
5353
driver.navigate.to url_for('formPage.html')
5454
driver.find_element(id: 'checky').submit
5555

56-
wait_for_new_url('formPage.html')
56+
sleep 0.5
5757
expect(driver.title).to eq('We Arrive Here')
5858
end
5959

6060
it 'any element in form' do
6161
driver.navigate.to url_for('formPage.html')
6262
driver.find_element(css: 'form > p').submit
6363

64-
wait_for_new_url('formPage.html')
64+
sleep 0.5
6565
expect(driver.title).to eq('We Arrive Here')
6666
end
6767

6868
it 'button with id submit' do
6969
driver.navigate.to url_for('formPage.html')
7070
driver.find_element(id: 'submit').submit
7171

72-
wait_for_new_url('formPage.html')
72+
sleep 0.5
7373
expect(driver.title).to eq('We Arrive Here')
7474
end
7575

7676
it 'button with name submit' do
7777
driver.navigate.to url_for('formPage.html')
7878
driver.find_element(name: 'submit').submit
7979

80-
wait_for_new_url('formPage.html')
80+
sleep 0.5
8181
expect(driver.title).to eq('We Arrive Here')
8282
end
8383

rb/spec/integration/selenium/webdriver/spec_support/test_environment.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ def initialize
2929

3030
extract_browser_from_bazel_target_name
3131

32-
@driver = ENV.fetch('WD_SPEC_DRIVER', :chrome).to_sym
32+
@driver = ENV.fetch('WD_SPEC_DRIVER', :firefox).to_sym
3333
@driver_instance = nil
3434
end
3535

0 commit comments

Comments
 (0)